From d05206f4bef8ee569b8eb8f9c60d393a5265e307 Mon Sep 17 00:00:00 2001
From: Robert Dailey <git@rdailey.me>
Date: Thu, 27 Jun 2024 22:21:45 -0500
Subject: [PATCH] fix(sync): Unconditionally handle deleting custom formats
 when enabled.

When `delete_old_custom_formats` is enabled, deletion is no longer
skipped when there are no created or updated custom formats.

Fixes #237
---
 CHANGELOG.md                                               | 1 +
 .../CustomFormat/PipelinePhases/CustomFormatLogPhase.cs    | 7 +------
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bc0cc956..5d3da7aa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -42,6 +42,7 @@ changes you may need to make.
 - CLI: CFs with no Trash ID will no longer be displayed when running the `list custom-formats`
   command (#229).
 - Docker: Support running the container in read-only mode (#231).
+- Sync: Sometimes CFs weren't deleted even with `delete_old_custom_formats` enabled (#237).
 
 ## [6.0.2] - 2023-10-20
 
diff --git a/src/Recyclarr.Cli/Pipelines/CustomFormat/PipelinePhases/CustomFormatLogPhase.cs b/src/Recyclarr.Cli/Pipelines/CustomFormat/PipelinePhases/CustomFormatLogPhase.cs
index ff91e6ee..cf92bc74 100644
--- a/src/Recyclarr.Cli/Pipelines/CustomFormat/PipelinePhases/CustomFormatLogPhase.cs
+++ b/src/Recyclarr.Cli/Pipelines/CustomFormat/PipelinePhases/CustomFormatLogPhase.cs
@@ -13,12 +13,7 @@ public class CustomFormatLogPhase(ILogger log) : ILogPipelinePhase<CustomFormatP
                 context.InvalidFormats);
         }
 
-        if (context.ConfigOutput.Count == 0)
-        {
-            log.Debug("No custom formats to process");
-            return true;
-        }
-
+        // Do not exit when the config has zero custom formats. We still may need to delete old custom formats.
         return false;
     }