From de9cf9f149e1afdbf21ed5a8eec0f75ba49bdf3b Mon Sep 17 00:00:00 2001 From: Siddharth Dushantha Date: Thu, 9 Jul 2020 14:23:19 +0200 Subject: [PATCH] removed Coderwall Coderwall was removed because it returns false positives when a username contains a period --- data_bad_site.json | 9 +++++++++ removed_sites.md | 18 ++++++++++++++++++ sherlock/resources/data.json | 9 --------- 3 files changed, 27 insertions(+), 9 deletions(-) diff --git a/data_bad_site.json b/data_bad_site.json index b58a5f3c..5e3798a2 100644 --- a/data_bad_site.json +++ b/data_bad_site.json @@ -378,6 +378,15 @@ "urlMain": "https://radioskot.ru/", "username_claimed": "red", "username_unclaimed": "noonewouldeverusethis7" + }, + "Coderwall": { + "errorMsg": "404! Our feels when that url is used", + "errorType": "message", + "rank": 11256, + "url": "https://coderwall.com/{}", + "urlMain": "https://coderwall.com/", + "username_claimed": "jenny", + "username_unclaimed": "noonewouldeverusethis7" } } diff --git a/removed_sites.md b/removed_sites.md index 47a61afe..59117266 100644 --- a/removed_sites.md +++ b/removed_sites.md @@ -764,3 +764,21 @@ removed "username_unclaimed": "noonewouldeverusethis7" }, ``` + + + +## Coderwall +As of 2020-07-06, Coderwall returns false positives when checking for an username which contains a period. +I have tried to find out what Coderwall's criteria is for a valid username, but unfortunetly I have not been able to +find it and because of this, the best thing we can do now is to remove it. +``` + "Coderwall": { + "errorMsg": "404! Our feels when that url is used", + "errorType": "message", + "rank": 11256, + "url": "https://coderwall.com/{}", + "urlMain": "https://coderwall.com/", + "username_claimed": "jenny", + "username_unclaimed": "noonewouldeverusethis7" + } +``` diff --git a/sherlock/resources/data.json b/sherlock/resources/data.json index 4916aafd..9fdfc302 100644 --- a/sherlock/resources/data.json +++ b/sherlock/resources/data.json @@ -363,15 +363,6 @@ "username_claimed": "blue", "username_unclaimed": "noonewouldeverusethis7" }, - "Coderwall": { - "errorMsg": "404! Our feels when that url is used", - "errorType": "message", - "rank": 11256, - "url": "https://coderwall.com/{}", - "urlMain": "https://coderwall.com/", - "username_claimed": "jenny", - "username_unclaimed": "noonewouldeverusethis7" - }, "Codewars": { "errorType": "status_code", "rank": 19606,