From b237b8fe02fe22ee8e9d54e134045e7b03f9007b Mon Sep 17 00:00:00 2001 From: "Christopher K. Hoadley" Date: Wed, 23 Jan 2019 19:13:09 -0600 Subject: [PATCH 1/2] Problems with false positives on EyeEm/CreativeMarket/EVE Online. Add these sites to the tests to capture failure. --- tests/all.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index 3d06281d..c486c608 100644 --- a/tests/all.py +++ b/tests/all.py @@ -111,7 +111,8 @@ class SherlockSiteCoverageTests(SherlockBaseTest): self.username_check(['noonewouldeverusethis7'], ["Pinterest", "iMGSRC.RU", "Pastebin", - "WordPress", "devRant", "ImageShack", "MeetMe" + "WordPress", "devRant", "ImageShack", "MeetMe", + "EyeEm", "CreativeMarket", "EVE Online" ], exist_check=False ) @@ -134,7 +135,8 @@ class SherlockSiteCoverageTests(SherlockBaseTest): self.username_check(['blue'], ["Pinterest", "iMGSRC.RU", "Pastebin", - "WordPress", "devRant", "ImageShack", "MeetMe" + "WordPress", "devRant", "ImageShack", "MeetMe", + "EyeEm", "CreativeMarket", "EVE Online" ], exist_check=True ) From 0709fd39470e7d1509d96c96310c360828b987e1 Mon Sep 17 00:00:00 2001 From: "Christopher K. Hoadley" Date: Wed, 23 Jan 2019 19:16:55 -0600 Subject: [PATCH 2/2] Change EyeEm/CreativeMarket/EVE Online detection method to use the newly refurbished "response_url" detection method. --- data.json | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/data.json b/data.json index 84412975..94e7707f 100644 --- a/data.json +++ b/data.json @@ -153,7 +153,8 @@ "urlMain": "https://coroflot.com/" }, "CreativeMarket": { - "errorType": "status_code", + "errorType": "response_url", + "errorUrl": "https://www.creativemarket.com/", "url": "https://creativemarket.com/{}", "urlMain": "https://creativemarket.com/" }, @@ -197,9 +198,9 @@ "urlMain": "https://dribbble.com/" }, "EVE Online": { - "errorMsg": "No results found with your search...", - "errorType": "message", - "url": "https://evewho.com/search/{}", + "errorType": "response_url", + "errorUrl": "https://eveonline.com", + "url": "https://evewho.com/pilot/{}/", "urlMain": "https://eveonline.com" }, "Ebay": { @@ -220,7 +221,8 @@ "urlMain": "https://www.etsy.com/" }, "EyeEm": { - "errorType": "status_code", + "errorType": "response_url", + "errorUrl": "https://www.eyeem.com/", "url": "https://www.eyeem.com/u/{}", "urlMain": "https://www.eyeem.com/" },