Cleanup last PR

DiscordChatExporter.Domain/Discord/Models/Message.cs

@@ -11,14 +11,14 @@ namespace DiscordChatExporter.Domain.Discord.Models
     // https://discord.com/developers/docs/resources/channel#message-object-message-types
     public enum MessageType
     {
-        Default,
+        Default = 0,
-        RecipientAdd,
+        RecipientAdd = 1,
-        RecipientRemove,
+        RecipientRemove = 2,
-        Call,
+        Call = 3,
-        ChannelNameChange,
+        ChannelNameChange = 4,
-        ChannelIconChange,
+        ChannelIconChange = 5,
-        ChannelPinnedMessage,
+        ChannelPinnedMessage = 6,
-        GuildMemberJoin,
+        GuildMemberJoin = 7,
         Reply = 19
     }
 
@@ -49,9 +49,9 @@ namespace DiscordChatExporter.Domain.Discord.Models
 
         public IReadOnlyList<User> MentionedUsers { get; }
 
-        public MessageReference? Reference {get; }
+        public MessageReference? Reference { get; }
 
-        public Message? ReferencedMessage {get; }
+        public Message? ReferencedMessage { get; }
 
         public Message(
             Snowflake id,
@@ -107,7 +107,7 @@ namespace DiscordChatExporter.Domain.Discord.Models
                 MessageType.RecipientAdd => "Added a recipient.",
                 MessageType.RecipientRemove => "Removed a recipient.",
                 MessageType.Call =>
-                $"Started a call that lasted {callEndedTimestamp?.Pipe(t => t - timestamp).Pipe(t => (int) t.TotalMinutes) ?? 0} minutes.",
+                    $"Started a call that lasted {callEndedTimestamp?.Pipe(t => t - timestamp).Pipe(t => (int) t.TotalMinutes) ?? 0} minutes.",
                 MessageType.ChannelNameChange => "Changed the channel name.",
                 MessageType.ChannelIconChange => "Changed the channel icon.",
                 MessageType.ChannelPinnedMessage => "Pinned a message.",

DiscordChatExporter.Domain/Discord/Models/MessageReference.cs

@@ -1,37 +1,37 @@
 using System.Text.Json;
+using DiscordChatExporter.Domain.Utilities;
 using JsonExtensions.Reading;
 
 namespace DiscordChatExporter.Domain.Discord.Models
 {
-    // reference data sent with crossposted messages and replies
     // https://discord.com/developers/docs/resources/channel#message-object-message-reference-structure
     public partial class MessageReference
     {
-        public string? MessageId { get; }
+        public Snowflake? MessageId { get; }
 
-        public string? ChannelId { get; }
+        public Snowflake? ChannelId { get; }
 
-        public string? GuildId { get; }
+        public Snowflake? GuildId { get; }
 
-        public MessageReference(string? message_id, string? channel_id, string? guild_id)
+        public MessageReference(Snowflake? messageId, Snowflake? channelId, Snowflake? guildId)
         {
-            MessageId = message_id;
+            MessageId = messageId;
-            ChannelId = channel_id;
+            ChannelId = channelId;
-            GuildId = guild_id;
+            GuildId = guildId;
         }
 
-        public override string ToString() => MessageId ?? "?";
+        public override string ToString() => MessageId?.ToString() ?? "<unknown reference>";
     }
 
     public partial class MessageReference
     {
         public static MessageReference Parse(JsonElement json)
         {
-            var message_id = json.GetPropertyOrNull("message_id")?.GetString();
+            var messageId = json.GetPropertyOrNull("message_id")?.GetString().Pipe(Snowflake.Parse);
-            var channel_id = json.GetPropertyOrNull("channel_id")?.GetString();
+            var channelId = json.GetPropertyOrNull("channel_id")?.GetString().Pipe(Snowflake.Parse);
-            var guild_id = json.GetPropertyOrNull("guild_id")?.GetString();
+            var guildId = json.GetPropertyOrNull("guild_id")?.GetString().Pipe(Snowflake.Parse);
 
-            return new MessageReference(message_id, channel_id, guild_id);
+            return new MessageReference(messageId, channelId, guildId);
         }
     }
 }

DiscordChatExporter.Domain/Exporting/Writers/Html/MessageGroup.cs

@@ -22,13 +22,13 @@ namespace DiscordChatExporter.Domain.Exporting.Writers.Html
             User author,
             DateTimeOffset timestamp,
             MessageReference? reference,
-            Message? referenced_message,
+            Message? referencedMessage,
             IReadOnlyList<Message> messages)
         {
             Author = author;
             Timestamp = timestamp;
             Reference = reference;
-            ReferencedMessage = referenced_message;
+            ReferencedMessage = referencedMessage;
             Messages = messages;
         }
     }