Qstick
5 years ago
parent
23316329ed
commit
2f1290d488
@ -0,0 +1,203 @@
|
|||||||
|
using System.Collections.Generic;
|
||||||
|
using System.Linq;
|
||||||
|
using FizzWare.NBuilder;
|
||||||
|
using FluentAssertions;
|
||||||
|
using NUnit.Framework;
|
||||||
|
using NzbDrone.Core.Qualities;
|
||||||
|
using NzbDrone.Core.DecisionEngine.Specifications;
|
||||||
|
using NzbDrone.Core.MediaFiles;
|
||||||
|
using NzbDrone.Core.Test.Framework;
|
||||||
|
using NzbDrone.Core.Parser.Model;
|
||||||
|
using NzbDrone.Core.Music;
|
||||||
|
using Moq;
|
||||||
|
|
||||||
|
namespace NzbDrone.Core.Test.DecisionEngineTests
|
||||||
|
{
|
||||||
|
[TestFixture]
|
||||||
|
public class RepackSpecificationFixture : CoreTest<RepackSpecification>
|
||||||
|
{
|
||||||
|
private ParsedAlbumInfo _parsedAlbumInfo;
|
||||||
|
private List<Album> _albums;
|
||||||
|
private List<TrackFile> _trackFiles;
|
||||||
|
|
||||||
|
[SetUp]
|
||||||
|
public void Setup()
|
||||||
|
{
|
||||||
|
Mocker.Resolve<UpgradableSpecification>();
|
||||||
|
|
||||||
|
_parsedAlbumInfo = Builder<ParsedAlbumInfo>.CreateNew()
|
||||||
|
.With(p => p.Quality = new QualityModel(Quality.FLAC,
|
||||||
|
new Revision(2, 0, false)))
|
||||||
|
.With(p => p.ReleaseGroup = "Lidarr")
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
_albums = Builder<Album>.CreateListOfSize(1)
|
||||||
|
.All()
|
||||||
|
.BuildList();
|
||||||
|
|
||||||
|
_trackFiles = Builder<TrackFile>.CreateListOfSize(3)
|
||||||
|
.All()
|
||||||
|
.With(t => t.AlbumId = _albums.First().Id)
|
||||||
|
.BuildList();
|
||||||
|
|
||||||
|
Mocker.GetMock<IMediaFileService>()
|
||||||
|
.Setup(c => c.GetFilesByAlbum(It.IsAny<int>()))
|
||||||
|
.Returns(_trackFiles);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_true_if_it_is_not_a_repack()
|
||||||
|
{
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_true_if_there_are_is_no_track_files()
|
||||||
|
{
|
||||||
|
Mocker.GetMock<IMediaFileService>()
|
||||||
|
.Setup(c => c.GetFilesByAlbum(It.IsAny<int>()))
|
||||||
|
.Returns(new List<TrackFile>());
|
||||||
|
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_true_if_is_a_repack_for_a_different_quality()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = "Lidarr"; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.MP3_256); return c; }).ToList();
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_true_if_is_a_repack_for_all_existing_files()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = "Lidarr"; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.FLAC); return c; }).ToList();
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_false_if_is_a_repack_for_some_but_not_all_trackfiles()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = "Lidarr"; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.FLAC); return c; }).ToList();
|
||||||
|
|
||||||
|
_trackFiles.First().ReleaseGroup = "NotLidarr";
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_false_if_is_a_repack_for_different_group()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = "NotLidarr"; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.FLAC); return c; }).ToList();
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_false_if_release_group_for_existing_file_is_unknown()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = ""; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.FLAC); return c; }).ToList();
|
||||||
|
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Test]
|
||||||
|
public void should_return_false_if_release_group_for_release_is_unknown()
|
||||||
|
{
|
||||||
|
_parsedAlbumInfo.Quality.Revision.IsRepack = true;
|
||||||
|
_parsedAlbumInfo.ReleaseGroup = null;
|
||||||
|
|
||||||
|
_trackFiles.Select(c => { c.ReleaseGroup = "Lidarr"; return c; }).ToList();
|
||||||
|
_trackFiles.Select(c => { c.Quality = new QualityModel(Quality.FLAC); return c; }).ToList();
|
||||||
|
|
||||||
|
|
||||||
|
var remoteAlbum = Builder<RemoteAlbum>.CreateNew()
|
||||||
|
.With(e => e.ParsedAlbumInfo = _parsedAlbumInfo)
|
||||||
|
.With(e => e.Albums = _albums)
|
||||||
|
.Build();
|
||||||
|
|
||||||
|
Subject.IsSatisfiedBy(remoteAlbum, null)
|
||||||
|
.Accepted
|
||||||
|
.Should()
|
||||||
|
.BeFalse();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@ -0,0 +1,43 @@
|
|||||||
|
using System.Data;
|
||||||
|
using FluentMigrator;
|
||||||
|
using NzbDrone.Core.Datastore.Migration.Framework;
|
||||||
|
|
||||||
|
namespace NzbDrone.Core.Datastore.Migration
|
||||||
|
{
|
||||||
|
[Migration(033)]
|
||||||
|
public class download_propers_config : NzbDroneMigrationBase
|
||||||
|
{
|
||||||
|
protected override void MainDbUpgrade()
|
||||||
|
{
|
||||||
|
Execute.WithConnection(SetConfigValue);
|
||||||
|
Execute.Sql("DELETE FROM Config WHERE Key = 'autodownloadpropers'");
|
||||||
|
}
|
||||||
|
|
||||||
|
private void SetConfigValue(IDbConnection conn, IDbTransaction tran)
|
||||||
|
{
|
||||||
|
using (var cmd = conn.CreateCommand())
|
||||||
|
{
|
||||||
|
cmd.Transaction = tran;
|
||||||
|
cmd.CommandText = "SELECT Value FROM Config WHERE Key = 'autodownloadpropers'";
|
||||||
|
|
||||||
|
using (var reader = cmd.ExecuteReader())
|
||||||
|
{
|
||||||
|
while (reader.Read())
|
||||||
|
{
|
||||||
|
var value = reader.GetString(0);
|
||||||
|
var newValue = bool.Parse(value) ? "PreferAndUpgrade" : "DoNotUpgrade";
|
||||||
|
|
||||||
|
using (var updateCmd = conn.CreateCommand())
|
||||||
|
{
|
||||||
|
updateCmd.Transaction = tran;
|
||||||
|
updateCmd.CommandText = "INSERT INTO Config (key, value) VALUES ('downloadpropersandrepacks', ?)";
|
||||||
|
updateCmd.AddParameter(newValue);
|
||||||
|
|
||||||
|
updateCmd.ExecuteNonQuery();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@ -0,0 +1,67 @@
|
|||||||
|
using System;
|
||||||
|
using NLog;
|
||||||
|
using NzbDrone.Common.Extensions;
|
||||||
|
using NzbDrone.Core.IndexerSearch.Definitions;
|
||||||
|
using NzbDrone.Core.MediaFiles;
|
||||||
|
using NzbDrone.Core.Parser.Model;
|
||||||
|
|
||||||
|
namespace NzbDrone.Core.DecisionEngine.Specifications
|
||||||
|
{
|
||||||
|
public class RepackSpecification : IDecisionEngineSpecification
|
||||||
|
{
|
||||||
|
private readonly IMediaFileService _mediaFileService;
|
||||||
|
private readonly UpgradableSpecification _upgradableSpecification;
|
||||||
|
private readonly Logger _logger;
|
||||||
|
|
||||||
|
public RepackSpecification(IMediaFileService mediaFileService, UpgradableSpecification upgradableSpecification, Logger logger)
|
||||||
|
{
|
||||||
|
_mediaFileService = mediaFileService;
|
||||||
|
_upgradableSpecification = upgradableSpecification;
|
||||||
|
_logger = logger;
|
||||||
|
}
|
||||||
|
|
||||||
|
public SpecificationPriority Priority => SpecificationPriority.Database;
|
||||||
|
public RejectionType Type => RejectionType.Permanent;
|
||||||
|
|
||||||
|
public Decision IsSatisfiedBy(RemoteAlbum subject, SearchCriteriaBase searchCriteria)
|
||||||
|
{
|
||||||
|
if (!subject.ParsedAlbumInfo.Quality.Revision.IsRepack)
|
||||||
|
{
|
||||||
|
return Decision.Accept();
|
||||||
|
}
|
||||||
|
|
||||||
|
foreach (var album in subject.Albums)
|
||||||
|
{
|
||||||
|
var releaseGroup = subject.ParsedAlbumInfo.ReleaseGroup;
|
||||||
|
var trackFiles = _mediaFileService.GetFilesByAlbum(album.Id);
|
||||||
|
|
||||||
|
foreach (var file in trackFiles)
|
||||||
|
{
|
||||||
|
if (_upgradableSpecification.IsRevisionUpgrade(file.Quality, subject.ParsedAlbumInfo.Quality))
|
||||||
|
{
|
||||||
|
var fileReleaseGroup = file.ReleaseGroup;
|
||||||
|
|
||||||
|
if (fileReleaseGroup.IsNullOrWhiteSpace())
|
||||||
|
{
|
||||||
|
return Decision.Reject("Unable to determine release group for the existing file");
|
||||||
|
}
|
||||||
|
|
||||||
|
if (releaseGroup.IsNullOrWhiteSpace())
|
||||||
|
{
|
||||||
|
return Decision.Reject("Unable to determine release group for this release");
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!fileReleaseGroup.Equals(releaseGroup, StringComparison.InvariantCultureIgnoreCase))
|
||||||
|
{
|
||||||
|
_logger.Debug("Release is a repack for a different release group. Release Group: {0}. File release group: {0}", releaseGroup, fileReleaseGroup);
|
||||||
|
return Decision.Reject("Release is a repack for a different release group. Release Group: {0}. File release group: {0}", releaseGroup, fileReleaseGroup);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
return Decision.Accept();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@ -0,0 +1,9 @@
|
|||||||
|
namespace NzbDrone.Core.Qualities
|
||||||
|
{
|
||||||
|
public enum ProperDownloadTypes
|
||||||
|
{
|
||||||
|
PreferAndUpgrade,
|
||||||
|
DoNotUpgrade,
|
||||||
|
DoNotPrefer
|
||||||
|
}
|
||||||
|
}
|
||||||
Loading…
Reference in new issue