cleaned up some jslint errors

UI/.idea/dictionaries/Keivan_Beigi.xml

@@ -0,0 +1,9 @@
+<component name="ProjectDictionaryState">
+  <dictionary name="Keivan.Beigi">
+    <words>
+      <w>bnzbd</w>
+      <w>mouseenter</w>
+      <w>mouseleave</w>
+    </words>
+  </dictionary>
+</component>

UI/.idea/inspectionProfiles/Project_Default.xml

@@ -5,17 +5,21 @@
     <inspection_tool class="AssignmentResultUsedJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="AssignmentToForLoopParameterJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="AssignmentToFunctionParameterJS" enabled="true" level="WEAK WARNING" enabled_by_default="true" />
+    <inspection_tool class="BreakStatementJS" enabled="true" level="SERVER PROBLEM" enabled_by_default="true" />
+    <inspection_tool class="BreakStatementWithLabelJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ChainedEqualityJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="CheckEmptyScriptTag" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="ConditionalExpressionWithIdenticalBranchesJS" enabled="true" level="ERROR" enabled_by_default="true" />
+    <inspection_tool class="ConstantIfStatementJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ConstantOnLHSOfComparisonJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ContinueStatementWithLabelJS" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="CssUnusedSymbolInspection" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="CssMissingSemicolonInspection" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="CyclomaticComplexityJS" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="m_limit" value="10" />
     </inspection_tool>
     <inspection_tool class="DefaultNotLastCaseInSwitchJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="DuplicateConditionJS" enabled="true" level="WARNING" enabled_by_default="true" />
+    <inspection_tool class="DynamicallyGeneratedCodeJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="EmptyTryBlockJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ExceptionCaughtLocallyJS" enabled="true" level="ERROR" enabled_by_default="true" />
     <inspection_tool class="ForLoopReplaceableByWhileJS" enabled="true" level="INFO" enabled_by_default="true">
@@ -41,7 +45,7 @@
     <inspection_tool class="HtmlUnknownTag" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="myValues">
         <value>
-          <list size="7">
+          <list size="8">
             <item index="0" class="java.lang.String" itemvalue="nobr" />
             <item index="1" class="java.lang.String" itemvalue="noembed" />
             <item index="2" class="java.lang.String" itemvalue="comment" />
@@ -49,16 +53,18 @@
             <item index="4" class="java.lang.String" itemvalue="embed" />
             <item index="5" class="java.lang.String" itemvalue="script" />
             <item index="6" class="java.lang.String" itemvalue="icon" />
+            <item index="7" class="java.lang.String" itemvalue="p" />
           </list>
         </value>
       </option>
       <option name="myCustomValuesEnabled" value="true" />
     </inspection_tool>
-    <inspection_tool class="IfStatementWithIdenticalBranchesJS" enabled="true" level="WARNING" enabled_by_default="true" />
+    <inspection_tool class="IfStatementWithIdenticalBranchesJS" enabled="true" level="ERROR" enabled_by_default="true" />
-    <inspection_tool class="IfStatementWithTooManyBranchesJS" enabled="true" level="WARNING" enabled_by_default="true">
+    <inspection_tool class="IfStatementWithTooManyBranchesJS" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="m_limit" value="3" />
     </inspection_tool>
     <inspection_tool class="JSHint" enabled="true" level="ERROR" enabled_by_default="true" />
+    <inspection_tool class="JSPotentiallyInvalidUsageOfThis" enabled="true" level="SERVER PROBLEM" enabled_by_default="true" />
     <inspection_tool class="JSUnresolvedVariable" enabled="false" level="WEAK WARNING" enabled_by_default="false" />
     <inspection_tool class="JSUnusedGlobalSymbols" enabled="false" level="INFO" enabled_by_default="false" />
     <inspection_tool class="LabeledStatementJS" enabled="true" level="ERROR" enabled_by_default="true" />
@@ -68,6 +74,7 @@
       <option name="m_maxLength" value="32" />
     </inspection_tool>
     <inspection_tool class="LossyEncoding" enabled="true" level="WARNING" enabled_by_default="true" />
+    <inspection_tool class="NegatedIfStatementJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="NestedAssignmentJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="NestedFunctionCallJS" enabled="false" level="ERROR" enabled_by_default="false" />
     <inspection_tool class="NestedSwitchStatementJS" enabled="true" level="WARNING" enabled_by_default="true" />
@@ -80,7 +87,6 @@
       <option name="m_minLength" value="1" />
       <option name="m_maxLength" value="32" />
     </inspection_tool>
-    <inspection_tool class="ReplaceAssignmentWithOperatorAssignmentJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="ReuseOfLocalVariableJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="StatementsPerFunctionJS" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="m_limit" value="30" />
@@ -94,6 +100,7 @@
         </set>
       </option>
     </inspection_tool>
+    <inspection_tool class="ThreeNegationsPerFunctionJS" enabled="true" level="WARNING" enabled_by_default="true" />
     <inspection_tool class="UnterminatedStatementJS" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="ignoreSemicolonAtEndOfBlock" value="true" />
     </inspection_tool>

UI/Mixins/handlebars.mixin.js

@@ -1,6 +1,6 @@
 'use strict';
 
-Handlebars.registerHelper('partial', function(templateName, context){
+Handlebars.registerHelper('partial', function (templateName) {
     //TODO: We should be able to pass in the context, either an object or a property
 
     var templateFunction = Marionette.TemplateCache.get(templateName);
@@ -17,4 +17,4 @@ Handlebars.registerHelper("debug", function(optionalValue) {
         console.log("====================");
         console.log(optionalValue);
     }
-});
+});

UI/Mixins/tablesorter.extensions.js

@@ -1,7 +1,7 @@
 $.tablesorter.addParser({
     // set a unique id 
     id    : 'title',
-    is    : function (s) {
+    is    : function () {
         // return false so this parser is not auto detected 
         return false;
     },
@@ -16,7 +16,7 @@ $.tablesorter.addParser({
 $.tablesorter.addParser({
     // set a unique id 
     id    : 'date',
-    is    : function (s) {
+    is    : function () {
         // return false so this parser is not auto detected 
         return false;
     },
@@ -37,7 +37,7 @@ $.tablesorter.addParser({
 $.tablesorter.addParser({
     // set a unique id 
     id    : 'innerHtml',
-    is    : function (s) {
+    is    : function () {
         // return false so this parser is not auto detected 
         return false;
     },
@@ -47,4 +47,4 @@ $.tablesorter.addParser({
     },
     // set type, either numeric or text 
     type  : 'text'
-});
+});

UI/Quality/QualitySizeCollection.js

@@ -1,6 +1,7 @@
-define(['app', 'Quality/QualitySizeModel'], function () {
+"use strict";
+define(['app', 'Quality/QualitySizeModel'], function () {
     NzbDrone.Quality.QualitySizeCollection = Backbone.Collection.extend({
         model: NzbDrone.Quality.QualitySizeModel,
         url  : NzbDrone.Constants.ApiRoot + '/qualitysizes'
     });
-});
+});

UI/Quality/QualitySizeModel.js

@@ -1,4 +1,5 @@
-define(['app'], function () {
+"use strict";
+define(['app'], function () {
     NzbDrone.Quality.QualitySizeModel = Backbone.Model.extend({
 
         initialize: function () {
@@ -14,4 +15,4 @@
             }
         }
     });
-});
+});

UI/Quality/qualityProfileCollection.js

@@ -1,4 +1,5 @@
-define(['app', 'Quality/QualityProfileModel'], function () {
+"use strict";
+define(['app', 'Quality/QualityProfileModel'], function () {
 
     var qualityProfileCollection = Backbone.Collection.extend({
         model: NzbDrone.Quality.QualityProfileModel,

UI/Quality/qualityProfileModel.js

@@ -1,4 +1,5 @@
-define(['app'], function () {
+"use strict";
+define(['app'], function () {
     NzbDrone.Quality.QualityProfileModel = Backbone.Model.extend({
 
         mutators: {

UI/Series/Index/EmptyView.js

@@ -1,8 +1,8 @@
 'use strict';
 
-define(['app'], function (app) {
+define(['app'], function () {
 
     NzbDrone.Series.Index.EmptyView = Backbone.Marionette.CompositeView.extend({
         template: 'Series/Index/EmptyTemplate'
     });
-});
+});

UI/Series/Index/Table/AirDateCell.js

@@ -1,3 +1,4 @@
+"use strict";
 Backgrid.AirDateCell = Backgrid.Cell.extend({
     className: "air-date-cell",
 
@@ -9,4 +10,4 @@ Backgrid.AirDateCell = Backgrid.Cell.extend({
 
         return this;
     }
-});
+});

UI/Series/Index/Table/SeriesStatusCell.js

@@ -1,3 +1,4 @@
+"use strict";
 Backgrid.SeriesStatusCell = Backgrid.Cell.extend({
     className: "series-status-cell",
 
@@ -19,4 +20,4 @@ Backgrid.SeriesStatusCell = Backgrid.Cell.extend({
 
         return this;
     }
-});
+});

UI/Series/SeasonModel.js

@@ -1,4 +1,5 @@
-define(['app'], function () {
+"use strict";
+define(['app'], function () {
     NzbDrone.Series.SeasonModel = Backbone.Model.extend({
 
         mutators: {

UI/Series/SeriesCollection.js

@@ -1,4 +1,5 @@
-define(['app', 'Series/SeriesModel'], function () {
+"use strict";
+define(['app', 'Series/SeriesModel'], function () {
     NzbDrone.Series.SeriesCollection = Backbone.Collection.extend({
         url  : NzbDrone.Constants.ApiRoot + '/series',
         model: NzbDrone.Series.SeriesModel,
@@ -10,4 +11,4 @@
             return model.get(this.defaultSortKey);
         }
     });
-});
+});

UI/Series/SeriesModel.js

@@ -47,11 +47,7 @@ define(['app', 'Quality/QualityProfileCollection', 'AddSeries/RootFolders/RootFo
                 return "http://trakt.tv/show/" + this.get('titleSlug');
             },
             isContinuing     : function () {
-                if (this.get('status') === 0) {
+                return this.get('status') === 0;
-                    return true;
-                }
-
-                return false;
             },
             statusText       : function () {
                 if (this.get('status') === 0) {

UI/Settings/Indexers/Collection.js

@@ -1,6 +1,7 @@
-define(['app', 'Settings/Indexers/Model'], function () {
+"use strict";
+define(['app', 'Settings/Indexers/Model'], function () {
     NzbDrone.Settings.Indexers.Collection = Backbone.Collection.extend({
         url  : NzbDrone.Constants.ApiRoot + '/indexer',
         model: NzbDrone.Settings.Indexers.Model
     });
-});
+});

UI/Settings/Indexers/ItemView.js

@@ -18,7 +18,7 @@ define([
         },
 
         saveSettings: function () {
-            var test = 1;
+
             //this.model.save(undefined, this.syncNotification("Naming Settings Saved", "Couldn't Save Naming Settings"));
         },
 

UI/Settings/Notifications/NotificationsView.js

@@ -6,6 +6,6 @@ define([
 ], function () {
 
     NzbDrone.Settings.Notifications.NotificationsView = Backbone.Marionette.ItemView.extend({
-        template: 'Settings/Notifications/NotificationsTemplate',
+        template: 'Settings/Notifications/NotificationsTemplate'
     });
 });

UI/Settings/Quality/Profile/QualityProfileCollectionView.js

@@ -1,6 +1,6 @@
 'use strict';
 
-define(['app', 'Settings/Quality/Profile/QualityProfileView'], function (app) {
+define(['app', 'Settings/Quality/Profile/QualityProfileView'], function () {
     NzbDrone.Settings.Quality.Profile.QualityProfileCollectionView = Backbone.Marionette.CompositeView.extend({
         itemView         : NzbDrone.Settings.Quality.Profile.QualityProfileView,
         itemViewContainer: 'tbody',
@@ -17,4 +17,4 @@ define(['app', 'Settings/Quality/Profile/QualityProfileView'], function (app) {
 
         }
     });
-});
+});

UI/Settings/Quality/QualityLayout.js

@@ -1,4 +1,5 @@
-define([
+"use strict";
+define([
     'app',
     'Quality/QualityProfileCollection',
     'Quality/QualitySizeCollection',

UI/Settings/Quality/Size/QualitySizeCollectionView.js

@@ -1,13 +1,13 @@
 'use strict';
 
-define(['app', 'Settings/Quality/Size/QualitySizeView'], function (app) {
+define(['app', 'Settings/Quality/Size/QualitySizeView'], function () {
     NzbDrone.Settings.Quality.Size.QualitySizeCollectionView = Backbone.Marionette.CompositeView.extend({
         itemView         : NzbDrone.Settings.Quality.Size.QualitySizeView,
         itemViewContainer: '#quality-sizes-container',
         template         : 'Settings/Quality/Size/QualitySizeCollectionTemplate',
 
         initialize: function () {
-            var test = 1;
+
         },
 
         ui: {
@@ -18,4 +18,4 @@ define(['app', 'Settings/Quality/Size/QualitySizeView'], function (app) {
 
         }
     });
-});
+});

UI/Settings/SettingsModel.js

@@ -1,5 +1,6 @@
-define(['app'], function (app) {
+"use strict";
+define(['app'], function () {
     NzbDrone.Settings.SettingsModel = Backbone.Model.extend({
         url: NzbDrone.Constants.ApiRoot + '/settings'
     });
-});
+});

UI/Settings/System/SystemView.js

@@ -6,6 +6,6 @@ define([
 ], function () {
 
     NzbDrone.Settings.System.SystemView = Backbone.Marionette.ItemView.extend({
-        template: 'Settings/System/SystemTemplate',
+        template: 'Settings/System/SystemTemplate'
     });
 });