Fixed: Unclear UI on quality definitions (#483)

pull/478/head
gismo2004 6 years ago committed by Qstick
parent 91767c1462
commit 65a1581057

@ -12,6 +12,7 @@ class QualityDefinitions extends Component {
render() { render() {
const { const {
advancedSettings,
items, items,
...otherProps ...otherProps
} = this.props; } = this.props;
@ -26,7 +27,9 @@ class QualityDefinitions extends Component {
<div className={styles.quality}>Quality</div> <div className={styles.quality}>Quality</div>
<div className={styles.title}>Title</div> <div className={styles.title}>Title</div>
<div className={styles.sizeLimit}>Size Limit</div> <div className={styles.sizeLimit}>Size Limit</div>
<div className={styles.kilobitsPerSecond}>Kilobits Per Second</div> {advancedSettings &&
<div className={styles.kilobitsPerSecond}>Kilobits Per Second</div>
}
</div> </div>
<div className={styles.definitions}> <div className={styles.definitions}>
@ -54,6 +57,7 @@ class QualityDefinitions extends Component {
} }
QualityDefinitions.propTypes = { QualityDefinitions.propTypes = {
advancedSettings: PropTypes.bool.isRequired,
isFetching: PropTypes.bool.isRequired, isFetching: PropTypes.bool.isRequired,
error: PropTypes.object, error: PropTypes.object,
defaultProfile: PropTypes.object, defaultProfile: PropTypes.object,

@ -9,7 +9,8 @@ import QualityDefinitions from './QualityDefinitions';
function createMapStateToProps() { function createMapStateToProps() {
return createSelector( return createSelector(
(state) => state.settings.qualityDefinitions, (state) => state.settings.qualityDefinitions,
(qualityDefinitions) => { (state) => state.settings.advancedSettings,
(qualityDefinitions, advancedSettings) => {
const items = qualityDefinitions.items.map((item) => { const items = qualityDefinitions.items.map((item) => {
const pendingChanges = qualityDefinitions.pendingChanges[item.id] || {}; const pendingChanges = qualityDefinitions.pendingChanges[item.id] || {};
@ -17,6 +18,7 @@ function createMapStateToProps() {
}); });
return { return {
advancedSettings,
...qualityDefinitions, ...qualityDefinitions,
items, items,
hasPendingChanges: !_.isEmpty(qualityDefinitions.pendingChanges) hasPendingChanges: !_.isEmpty(qualityDefinitions.pendingChanges)

Loading…
Cancel
Save