Fixed: Don't buffer update package to memory when downloading

(cherry picked from commit 63654b99f22b87b42acd699ac5b453f2de20211f)

Closes #3639
Closes #3641

src/NzbDrone.Common.Test/Http/HttpClientFixture.cs

@@ -148,7 +148,7 @@ namespace NzbDrone.Common.Test.Http
             var request = new HttpRequest($"https://expired.badssl.com");
 
             Assert.Throws<HttpRequestException>(() => Subject.Execute(request));
-            ExceptionVerification.ExpectedErrors(2);
+            ExceptionVerification.ExpectedErrors(1);
         }
 
         [Test]

src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Net;
 using System.Net.Http;
@@ -8,7 +7,6 @@ using System.Net.Sockets;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using NLog;
 using NzbDrone.Common.Cache;
 using NzbDrone.Common.Extensions;
 using NzbDrone.Common.Http.Proxy;
@@ -28,21 +26,18 @@ namespace NzbDrone.Common.Http.Dispatchers
         private readonly ICertificateValidationService _certificateValidationService;
         private readonly IUserAgentBuilder _userAgentBuilder;
         private readonly ICached<System.Net.Http.HttpClient> _httpClientCache;
-        private readonly Logger _logger;
         private readonly ICached<CredentialCache> _credentialCache;
 
         public ManagedHttpDispatcher(IHttpProxySettingsProvider proxySettingsProvider,
             ICreateManagedWebProxy createManagedWebProxy,
             ICertificateValidationService certificateValidationService,
             IUserAgentBuilder userAgentBuilder,
-                                     ICacheManager cacheManager,
+            ICacheManager cacheManager)
-                                     Logger logger)
         {
             _proxySettingsProvider = proxySettingsProvider;
             _createManagedWebProxy = createManagedWebProxy;
             _certificateValidationService = certificateValidationService;
             _userAgentBuilder = userAgentBuilder;
-            _logger = logger;
 
             _httpClientCache = cacheManager.GetCache<System.Net.Http.HttpClient>(typeof(ManagedHttpDispatcher));
             _credentialCache = cacheManager.GetCache<CredentialCache>(typeof(ManagedHttpDispatcher), "credentialcache");
@@ -103,43 +98,25 @@ namespace NzbDrone.Common.Http.Dispatchers
 
             var httpClient = GetClient(request.Url);
 
-            HttpResponseMessage responseMessage;
+            using var responseMessage = httpClient.Send(requestMessage, HttpCompletionOption.ResponseHeadersRead, cts.Token);
-
-            try
-            {
-                responseMessage = httpClient.Send(requestMessage, cts.Token);
-            }
-            catch (HttpRequestException e)
             {
-                _logger.Error(e, "HttpClient error");
-                throw;
-            }
-
                 byte[] data = null;
 
-            using (var responseStream = responseMessage.Content.ReadAsStream())
-            {
-                if (responseStream != null && responseStream != Stream.Null)
-                {
                 try
                 {
                     if (request.ResponseStream != null && responseMessage.StatusCode == HttpStatusCode.OK)
                     {
-                            // A target ResponseStream was specified, write to that instead.
+                        responseMessage.Content.CopyTo(request.ResponseStream, null, cts.Token);
-                            // But only on the OK status code, since we don't want to write failures and redirects.
-                            responseStream.CopyTo(request.ResponseStream);
                     }
                     else
                     {
-                            data = responseStream.ToBytes();
+                        data = responseMessage.Content.ReadAsByteArrayAsync(cts.Token).GetAwaiter().GetResult();
                     }
                 }
                 catch (Exception ex)
                 {
                     throw new WebException("Failed to read complete http response", ex, WebExceptionStatus.ReceiveFailure, null);
                 }
-                }
-            }
 
                 var headers = responseMessage.Headers.ToNameValueCollection();
 
@@ -147,6 +124,7 @@ namespace NzbDrone.Common.Http.Dispatchers
 
                 return new HttpResponse(request, new HttpHeader(headers), data, responseMessage.StatusCode);
             }
+        }
 
         protected virtual System.Net.Http.HttpClient GetClient(HttpUri uri)
         {

src/NzbDrone.Core.Test/Framework/CoreTest.cs

@@ -26,7 +26,7 @@ namespace NzbDrone.Core.Test.Framework
             Mocker.SetConstant<IHttpProxySettingsProvider>(new HttpProxySettingsProvider(Mocker.Resolve<ConfigService>()));
             Mocker.SetConstant<ICreateManagedWebProxy>(new ManagedWebProxyFactory(Mocker.Resolve<CacheManager>()));
             Mocker.SetConstant<ICertificateValidationService>(new X509CertificateValidationService(Mocker.Resolve<ConfigService>(), TestLogger));
-            Mocker.SetConstant<IHttpDispatcher>(new ManagedHttpDispatcher(Mocker.Resolve<IHttpProxySettingsProvider>(), Mocker.Resolve<ICreateManagedWebProxy>(), Mocker.Resolve<ICertificateValidationService>(), Mocker.Resolve<UserAgentBuilder>(), Mocker.Resolve<CacheManager>(), TestLogger));
+            Mocker.SetConstant<IHttpDispatcher>(new ManagedHttpDispatcher(Mocker.Resolve<IHttpProxySettingsProvider>(), Mocker.Resolve<ICreateManagedWebProxy>(), Mocker.Resolve<ICertificateValidationService>(), Mocker.Resolve<UserAgentBuilder>(), Mocker.Resolve<CacheManager>()));
             Mocker.SetConstant<IHttpClient>(new HttpClient(Array.Empty<IHttpRequestInterceptor>(), Mocker.Resolve<CacheManager>(), Mocker.Resolve<RateLimitService>(), Mocker.Resolve<IHttpDispatcher>(), TestLogger));
             Mocker.SetConstant<ILidarrCloudRequestBuilder>(new LidarrCloudRequestBuilder());
             Mocker.SetConstant<IMetadataRequestBuilder>(Mocker.Resolve<MetadataRequestBuilder>());