New: Root folder exists validation for import lists

Closes #4820

src/Lidarr.Api.V1/ImportLists/ImportListController.cs

@@ -1,3 +1,4 @@
+using FluentValidation;
 using Lidarr.Http;
 using NzbDrone.Core.ImportLists;
 using NzbDrone.Core.Validation;
@@ -12,16 +13,22 @@ namespace Lidarr.Api.V1.ImportLists
         public static readonly ImportListBulkResourceMapper BulkResourceMapper = new ();
 
         public ImportListController(IImportListFactory importListFactory,
+                                    RootFolderExistsValidator rootFolderExistsValidator,
                                     QualityProfileExistsValidator qualityProfileExistsValidator,
                                     MetadataProfileExistsValidator metadataProfileExistsValidator)
             : base(importListFactory, "importlist", ResourceMapper, BulkResourceMapper)
         {
-            Http.Validation.RuleBuilderExtensions.ValidId(SharedValidator.RuleFor(s => s.QualityProfileId));
+            SharedValidator.RuleFor(c => c.RootFolderPath).Cascade(CascadeMode.Stop)
-            Http.Validation.RuleBuilderExtensions.ValidId(SharedValidator.RuleFor(s => s.MetadataProfileId));
+                .IsValidPath()
+                .SetValidator(rootFolderExistsValidator);
 
-            SharedValidator.RuleFor(c => c.RootFolderPath).IsValidPath();
+            SharedValidator.RuleFor(c => c.QualityProfileId).Cascade(CascadeMode.Stop)
-            SharedValidator.RuleFor(c => c.QualityProfileId).SetValidator(qualityProfileExistsValidator);
+                .ValidId()
-            SharedValidator.RuleFor(c => c.MetadataProfileId).SetValidator(metadataProfileExistsValidator);
+                .SetValidator(qualityProfileExistsValidator);
+
+            SharedValidator.RuleFor(c => c.MetadataProfileId).Cascade(CascadeMode.Stop)
+                .ValidId()
+                .SetValidator(metadataProfileExistsValidator);
         }
     }
 }

src/NzbDrone.Core/Validation/MetadataProfileExistsValidator.cs

@@ -5,28 +5,23 @@ namespace NzbDrone.Core.Validation
 {
     public class MetadataProfileExistsValidator : PropertyValidator
     {
-        private readonly IMetadataProfileService _profileService;
+        private readonly IMetadataProfileService _metadataProfileService;
 
-        public MetadataProfileExistsValidator(IMetadataProfileService profileService)
+        public MetadataProfileExistsValidator(IMetadataProfileService metadataProfileService)
         {
-            _profileService = profileService;
+            _metadataProfileService = metadataProfileService;
         }
 
         protected override string GetDefaultMessageTemplate() => "Metadata profile does not exist";
 
         protected override bool IsValid(PropertyValidatorContext context)
         {
-            if (context.PropertyValue == null)
+            if (context?.PropertyValue == null || (int)context.PropertyValue == 0)
             {
                 return true;
             }
 
-            if ((int)context.PropertyValue == 0)
+            return _metadataProfileService.Exists((int)context.PropertyValue);
-            {
-                return true;
-            }
-
-            return _profileService.Exists((int)context.PropertyValue);
         }
     }
 }

src/NzbDrone.Core/Validation/Paths/RootFolderExistsValidator.cs

@@ -0,0 +1,25 @@
+using FluentValidation.Validators;
+using NzbDrone.Common.Extensions;
+using NzbDrone.Core.RootFolders;
+
+namespace NzbDrone.Core.Validation.Paths
+{
+    public class RootFolderExistsValidator : PropertyValidator
+    {
+        private readonly IRootFolderService _rootFolderService;
+
+        public RootFolderExistsValidator(IRootFolderService rootFolderService)
+        {
+            _rootFolderService = rootFolderService;
+        }
+
+        protected override string GetDefaultMessageTemplate() => "Root folder '{path}' does not exist";
+
+        protected override bool IsValid(PropertyValidatorContext context)
+        {
+            context.MessageFormatter.AppendArgument("path", context.PropertyValue?.ToString());
+
+            return context.PropertyValue == null || _rootFolderService.All().Exists(r => r.Path.PathEquals(context.PropertyValue.ToString()));
+        }
+    }
+}