Fixed: Size on disk sorting and display

Co-Authored-By: Mark McDowall <markus101@users.noreply.github.com>

frontend/src/Album/Details/AlbumDetails.js

@@ -416,7 +416,7 @@ class AlbumDetails extends Component {
 
                     <span className={styles.sizeOnDisk}>
                       {
-                        formatBytes(statistics.sizeOnDisk)
+                        formatBytes(statistics.sizeOnDisk || 0)
                       }
                     </span>
                   </Label>

frontend/src/Artist/Details/ArtistDetails.js

@@ -460,7 +460,7 @@ class ArtistDetails extends Component {
 
                     <span className={styles.sizeOnDisk}>
                       {
-                        formatBytes(sizeOnDisk)
+                        formatBytes(sizeOnDisk || 0)
                       }
                     </span>
                   </Label>

frontend/src/Store/Actions/artistActions.js

@@ -114,7 +114,9 @@ export const filterPredicates = {
 
   sizeOnDisk: function(item, filterValue, type) {
     const predicate = filterTypePredicates[type];
-    const sizeOnDisk = item.statistics ? item.statistics.sizeOnDisk : 0;
+    const sizeOnDisk = item.statistics && item.statistics.sizeOnDisk ?
+      item.statistics.sizeOnDisk :
+      0;
 
     return predicate(sizeOnDisk, filterValue);
   }
@@ -133,6 +135,12 @@ export const sortPredicates = {
     }
 
     return result;
+  },
+
+  sizeOnDisk: function(item) {
+    const { statistics = {} } = item;
+
+    return statistics.sizeOnDisk || 0;
   }
 };
 

frontend/src/Store/Actions/artistIndexActions.js

@@ -207,12 +207,6 @@ export const defaultState = {
       return statistics.totalTrackCount || 0;
     },
 
-    sizeOnDisk: function(item) {
-      const { statistics = {} } = item;
-
-      return statistics.sizeOnDisk;
-    },
-
     ratings: function(item) {
       const { ratings = {} } = item;