Quick fix for email false positive message. ISSUE: #1286

pull/1287/head
Dhruv Bhavsar 8 years ago
parent 3be69cbd61
commit 3f0cc99f56

@ -227,6 +227,7 @@ namespace Ombi.Services.Notification
catch (Exception e)
{
Log.Error(e);
throw new InvalidOperationException(e.Message);
}
}

@ -97,6 +97,7 @@ namespace Ombi.Services.Notification
catch (Exception ex)
{
Log.Error(ex, $"Notification '{notification.NotificationName}' failed with exception");
throw new InvalidOperationException(ex.Message);
}
}
}

@ -642,9 +642,11 @@ namespace Ombi.UI.Modules.Admin
await NotificationService.Publish(notificationModel, settings);
Log.Info("Sent email notification test");
}
catch (Exception)
catch (Exception ex)
{
Log.Error("Failed to subscribe and publish test Email Notification");
var msg = "Failed: " + ex.Message;
return Response.AsJson(new JsonResponseModel { Result = false, Message = msg });
}
finally
{
@ -653,7 +655,9 @@ namespace Ombi.UI.Modules.Admin
NotificationService.UnSubscribe(new EmailMessageNotification(EmailService));
}
}
return Response.AsJson(new JsonResponseModel { Result = true, Message = "Successfully sent a test Email Notification!" });
}
private Response SaveEmailNotifications()
@ -1299,7 +1303,8 @@ namespace Ombi.UI.Modules.Admin
{
var settings = this.Bind<MassEmailSettings>();
Log.Debug("Clicked Admin Mass Email Test");
if (settings.Subject == null) {
if (settings.Subject == null)
{
return Response.AsJson(new JsonResponseModel { Result = false, Message = "Please Set a Subject" });
}
if (settings.Body == null)

@ -122,8 +122,7 @@ namespace Ombi.UI.Modules.Admin
}
catch (Exception e)
{
throw;
throw e;
}
}
}

Loading…
Cancel
Save