Added some additional logging to the metadata refresh

src/Ombi.Helpers/OmbiQuartz.cs

@@ -4,6 +4,7 @@ using System.Linq;
 using System.Threading.Tasks;
 using Quartz;
 using Quartz.Impl;
+using Quartz.Impl.Matchers;
 using Quartz.Spi;
 
 namespace Ombi.Helpers

src/Ombi.Schedule/Jobs/Emby/EmbyAvaliabilityChecker.cs

@@ -66,11 +66,13 @@ namespace Ombi.Schedule.Jobs.Emby
 
         public async Task Execute(IJobExecutionContext job)
         {
+            _log.LogInformation("Starting Emby Availability Check");
             await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)
                 .SendAsync(NotificationHub.NotificationEvent, "Emby Availability Checker Started");
             await ProcessMovies();
             await ProcessTv();
 
+            _log.LogInformation("Finished Emby Availability Check");
             await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)
                 .SendAsync(NotificationHub.NotificationEvent, "Emby Availability Checker Finished");
         }

src/Ombi.Schedule/Jobs/Emby/EmbyEpisodeSync.cs

@@ -78,6 +78,7 @@ namespace Ombi.Schedule.Jobs.Emby
 
             await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)
                 .SendAsync(NotificationHub.NotificationEvent, "Emby Episode Sync Finished");
+            _logger.LogInformation("Emby Episode Sync Finished - Triggering Metadata refresh");
             await OmbiQuartz.TriggerJob(nameof(IRefreshMetadata), "System");
         }
 

src/Ombi.Schedule/Jobs/Ombi/RefreshMetadata.cs

@@ -69,19 +69,19 @@ namespace Ombi.Schedule.Jobs.Ombi
                 if (embySettings.Enable)
                 {
                     await StartEmby(embySettings);
-                    
                     await OmbiQuartz.TriggerJob(nameof(IEmbyAvaliabilityChecker), "Emby");
                 }
             }
             catch (Exception e)
             {
-                _log.LogError(e, "Exception when refreshing the Plex Metadata");
+                _log.LogError(e, $"Exception when refreshing the Metadata Refresh");
 
                 await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)
                     .SendAsync(NotificationHub.NotificationEvent, "Metadata Refresh Failed");
-                throw;
+                return;
             }
 
+            _log.LogInformation("Metadata refresh finished");
             await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)
                 .SendAsync(NotificationHub.NotificationEvent, "Metadata Refresh Finished");
         }

src/Ombi.Schedule/Jobs/Plex/PlexEpisodeSync.cs

@@ -64,6 +64,7 @@ namespace Ombi.Schedule.Jobs.Plex
             }
 
 
+            _log.LogInformation("Plex Episode Sync Finished - Triggering Metadata refresh");
             await OmbiQuartz.TriggerJob(nameof(IRefreshMetadata), "System");
 
             await _notification.Clients.Clients(NotificationHub.AdminConnectionIds)

src/Ombi.Settings/Settings/Models/JobSettings.cs

@@ -11,7 +11,6 @@
         public string AutomaticUpdater { get; set; }
         public string UserImporter { get; set; }
         public string SickRageSync { get; set; }
-        public string RefreshMetadata { get; set; }
         public string Newsletter { get; set; }
         public string LidarrArtistSync { get; set; }
         public string IssuesPurge { get; set; }

src/Ombi.Settings/Settings/Models/JobSettingsHelper.cs

@@ -56,11 +56,6 @@ namespace Ombi.Settings.Settings.Models
             return ValidateCron(Get(s.SickRageSync, Cron.Hourly(35)));
         }
 
-        public static string RefreshMetadata(JobSettings s)
-        {
-            return ValidateCron(Get(s.RefreshMetadata, Cron.DayInterval(3)));
-        }
-
         public static string LidarrArtistSync(JobSettings s)
         {
             return ValidateCron(Get(s.LidarrArtistSync, Cron.Hourly(40)));

src/Ombi/ClientApp/src/app/interfaces/ISettings.ts

@@ -140,7 +140,6 @@ export interface IJobSettings {
   automaticUpdater: string;
   userImporter: string;
   sickRageSync: string;
-  refreshMetadata: string;
   newsletter: string;
   plexRecentlyAddedSync: string;
   lidarrArtistSync: string;

src/Ombi/ClientApp/src/app/settings/jobs/jobs.component.html

@@ -85,14 +85,6 @@
                         <button type="button" class="btn btn-sm btn-primary-outline" (click)="testCron(form.get('userImporter')?.value)">Test</button>
                 </div>
                     
-                <div class="form-group">
-                        <label for="userImporter" class="control-label">Refresh Metadata</label>              
-                            <input type="text" class="form-control form-control-custom" [ngClass]="{'form-error': form.get('refreshMetadata').hasError('required')}" id="refreshMetadata" name="refreshMetadata" formControlName="refreshMetadata">
-                            <small *ngIf="form.get('refreshMetadata').hasError('required')" class="error-text">The Refresh Metadata is required</small>
-                            <button type="button" class="btn btn-sm btn-primary-outline" (click)="testCron(form.get('refreshMetadata')?.value)">Test</button>
-                    </div>
-
-                    
                     <div class="form-group">
                         <label for="userImporter" class="control-label">Newsletter</label>              
                             <input type="text" class="form-control form-control-custom" [ngClass]="{'form-error': form.get('newsletter').hasError('required')}" id="newsletter" name="newsletter" formControlName="newsletter">

src/Ombi/ClientApp/src/app/settings/jobs/jobs.component.ts

@@ -28,7 +28,6 @@ export class JobsComponent implements OnInit {
                 sonarrSync:               [x.sonarrSync, Validators.required],
                 radarrSync:               [x.radarrSync, Validators.required],
                 sickRageSync:             [x.sickRageSync, Validators.required],  
-                refreshMetadata:          [x.refreshMetadata, Validators.required],
                 newsletter:               [x.newsletter, Validators.required],
                 plexRecentlyAddedSync:    [x.plexRecentlyAddedSync, Validators.required],
                 lidarrArtistSync:         [x.lidarrArtistSync, Validators.required],

src/Ombi/Controllers/V1/SettingsController.cs

@@ -569,7 +569,6 @@ namespace Ombi.Controllers.V1
             j.PlexContentSync = j.PlexContentSync.HasValue() ? j.PlexContentSync : JobSettingsHelper.PlexContent(j);
             j.UserImporter = j.UserImporter.HasValue() ? j.UserImporter : JobSettingsHelper.UserImporter(j);
             j.SickRageSync = j.SickRageSync.HasValue() ? j.SickRageSync : JobSettingsHelper.SickRageSync(j);
-            j.RefreshMetadata = j.RefreshMetadata.HasValue() ? j.RefreshMetadata : JobSettingsHelper.RefreshMetadata(j);
             j.PlexRecentlyAddedSync = j.PlexRecentlyAddedSync.HasValue() ? j.PlexRecentlyAddedSync : JobSettingsHelper.PlexRecentlyAdded(j);
             j.Newsletter = j.Newsletter.HasValue() ? j.Newsletter : JobSettingsHelper.Newsletter(j);
             j.LidarrArtistSync = j.LidarrArtistSync.HasValue() ? j.LidarrArtistSync : JobSettingsHelper.LidarrArtistSync(j);