Fixed some warnings

src/.editorconfig

@@ -0,0 +1,10 @@
+[*.cs]
+
+# CS1591: Missing XML comment for publicly visible type or member
+dotnet_diagnostic.CS1591.severity = none
+
+# RCS1090: Add call to 'ConfigureAwait' (or vice versa).
+dotnet_diagnostic.RCS1090.severity = none
+
+# RCS1036: Remove redundant empty line.
+dotnet_diagnostic.RCS1036.severity = none

src/Ombi/Attributes/AdminAttribute.cs

@@ -8,6 +8,5 @@ namespace Ombi.Attributes
         {
             Roles = "Admin";
         }
-        
     }
 }

src/Ombi/Ombi.csproj

@@ -46,6 +46,10 @@
     <None Remove="wwwroot\dist\**" />
   </ItemGroup>
   
+  <ItemGroup>
+    <None Include="..\.editorconfig" Link=".editorconfig" />
+  </ItemGroup>
+
  
   <ItemGroup>
     <PackageReference Include="AspNetCore.HealthChecks.MySql" Version="3.0.0" />

src/Ombi/Program.cs

@@ -49,8 +49,6 @@ namespace Ombi
                     }
                 });
 
-
-
             Console.WriteLine(HelpOutput(result));
             if (baseUrl.HasValue())
             {
@@ -64,11 +62,9 @@ namespace Ombi
             demoInstance.Demo = demo;
             instance.StoragePath = storagePath ?? string.Empty;
 
-
             var services = new ServiceCollection();
             services.ConfigureDatabases(null);
-            using (var provider = services.BuildServiceProvider())
+            using var provider = services.BuildServiceProvider();
-            {
             var settingsDb = provider.GetRequiredService<SettingsContext>();
             var ombiDb = provider.GetRequiredService<OmbiContext>();
 
@@ -103,12 +99,10 @@ namespace Ombi
                 var strat = settingsDb.Database.CreateExecutionStrategy();
                 await strat.ExecuteAsync(async () =>
                 {
-                        using (var tran = await settingsDb.Database.BeginTransactionAsync())
+                    using var tran = await settingsDb.Database.BeginTransactionAsync();
-                        {
                     settingsDb.ApplicationConfigurations.Add(url);
                     await settingsDb.SaveChangesAsync();
                     await tran.CommitAsync();
-                        }
                 });
 
                 urlValue = url.Value;
@@ -120,11 +114,9 @@ namespace Ombi
                 var strat = settingsDb.Database.CreateExecutionStrategy();
                 await strat.ExecuteAsync(async () =>
                 {
-                        using (var tran = await settingsDb.Database.BeginTransactionAsync())
+                    using var tran = await settingsDb.Database.BeginTransactionAsync();
-                        {
                     await settingsDb.SaveChangesAsync();
                     await tran.CommitAsync();
-                        }
                 });
 
                 urlValue = url.Value;
@@ -140,7 +132,6 @@ namespace Ombi
 
             CreateHostBuilder(args).Build().Run();
         }
-        }
 
         private static async Task CheckSecurityToken(ApplicationConfiguration securityToken, SettingsContext ctx, StartupSingleton instance)
         {
@@ -154,12 +145,10 @@ namespace Ombi
                 var strat = ctx.Database.CreateExecutionStrategy();
                 await strat.ExecuteAsync(async () =>
                 {
-                    using (var tran = await ctx.Database.BeginTransactionAsync())
+                    using var tran = await ctx.Database.BeginTransactionAsync();
-                    {
                     ctx.ApplicationConfigurations.Add(securityToken);
                     await ctx.SaveChangesAsync();
                     await tran.CommitAsync();
-                    }
                 });
             }
 
@@ -170,7 +159,7 @@ namespace Ombi
             Host.CreateDefaultBuilder(args)
                 .ConfigureWebHostDefaults(webBuilder =>
                 {
-                    webBuilder.ConfigureKestrel(serverOptions =>
+                    webBuilder.ConfigureKestrel(_ =>
                     {
                         // Set properties and call methods on options
                     });
@@ -204,12 +193,10 @@ namespace Ombi
                 var strat = settingsDb.Database.CreateExecutionStrategy();
                 await strat.ExecuteAsync(async () =>
                 {
-                    using (var tran = await settingsDb.Database.BeginTransactionAsync())
+                    using var tran = await settingsDb.Database.BeginTransactionAsync();
-                    {
                     settingsDb.Add(ombiSettingsContent);
                     await settingsDb.SaveChangesAsync();
                     await tran.CommitAsync();
-                    }
                 });
             }
             var ombiSettings = JsonConvert.DeserializeObject<OmbiSettings>(ombiSettingsContent.Content);

src/Ombi/Properties/launchSettings.json

@@ -14,7 +14,7 @@
   "profiles": {
     "IIS Express": {
       "commandName": "IISExpress",
-      "commandLineArgs": "--host http://*:3577",
+      "commandLineArgs": "--host http://*:3577" ,
       "launchBrowser": true,
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"
@@ -22,7 +22,7 @@
     },
     "Ombi": {
       "commandName": "Project",
-      "commandLineArgs": "--host http://localhost:3577 ",
+      "commandLineArgs": "--host http://localhost:3577 --baseUrl /ombi/",
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"
       },

src/Ombi/Startup.cs

@@ -93,7 +93,7 @@ namespace Ombi
                 .AddNewtonsoftJson(x => x.SerializerSettings.ReferenceLoopHandling = ReferenceLoopHandling.Ignore);
 
             services.AddOmbiMappingProfile();
-            services.AddAutoMapper(expression => { expression.AddCollectionMappers(); });
+            services.AddAutoMapper(expression => expression.AddCollectionMappers());
 
             services.RegisterApplicationDependencies(); // Ioc and EF
             services.AddSwagger();
@@ -110,10 +110,7 @@ namespace Ombi
 
             services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Latest);
             services.AddSignalR();
-            services.AddSpaStaticFiles(configuration =>
+            services.AddSpaStaticFiles(configuration => configuration.RootPath = "ClientApp/dist");
-            {
-                configuration.RootPath = "ClientApp/dist";
-            });
 
         }