Merge pull request #1039 from tidusjar/dev

Bunch of fixes around Emby

Ombi.Api.Models/Emby/EmbyUserdata.cs

@@ -31,7 +31,7 @@ namespace Ombi.Api.Models.Emby
 {
     public class EmbyUserdata
     {
-        public int PlaybackPositionTicks { get; set; }
+        public double PlaybackPositionTicks { get; set; }
         public int PlayCount { get; set; }
         public bool IsFavorite { get; set; }
         public bool Played { get; set; }

Ombi.Services/Jobs/EmbyAvailabilityChecker.cs

@@ -81,7 +81,10 @@ namespace Ombi.Services.Jobs
         public void CheckAndUpdateAll()
         {
             var embySettings = Emby.GetSettings();
-
+            if (!embySettings.Enable)
+            {
+                return;
+            }
             if (!ValidateSettings(embySettings))
             {
                 Log.Debug("Validation of the Emby settings failed.");

Ombi.Services/Jobs/EmbyContentCacher.cs

@@ -69,7 +69,10 @@ namespace Ombi.Services.Jobs
         public void CacheContent()
         {
             var embySettings = Emby.GetSettings();
-
+            if (!embySettings.Enable)
+            {
+                return;
+            }
             if (!ValidateSettings(embySettings))
             {
                 Log.Debug("Validation of emby settings failed.");

Ombi.Services/Jobs/PlexAvailabilityChecker.cs

@@ -82,6 +82,11 @@ namespace Ombi.Services.Jobs
 
             var plexSettings = Plex.GetSettings();
 
+            if (!plexSettings.Enable)
+            {
+                return;
+            }
+
             if (!ValidateSettings(plexSettings))
             {
                 Log.Debug("Validation of the plex settings failed.");

Ombi.Services/Jobs/PlexContentCacher.cs

@@ -77,7 +77,10 @@ namespace Ombi.Services.Jobs
         public void CacheContent()
         {
             var plexSettings = Plex.GetSettings();
-
+            if (!plexSettings.Enable)
+            {
+                return;
+            }
             if (!ValidateSettings(plexSettings))
             {
                 Log.Debug("Validation of the plex settings failed.");

Ombi.Services/Notification/EmbyNotificationEngine.cs

@@ -130,6 +130,7 @@ namespace Ombi.Services.Notification
                 var embySettings = await EmbySettings.GetSettingsAsync();
                 var embyUsers = EmbyApi.GetUsers(embySettings.FullUri, embySettings.ApiKey);
                 var userAccount = embyUsers.FirstOrDefault(x => x.Policy.IsAdministrator);
+                var localUsers = UserHelper.GetUsers().ToList();
 
                 var adminUsername = userAccount.Name ?? string.Empty;
 
@@ -179,9 +180,15 @@ namespace Ombi.Services.Notification
                     var email = embyUsers.FirstOrDefault(x => x.Name.Equals(user, StringComparison.CurrentCultureIgnoreCase));
                     if (email == null)
                     {
-                        Log.Info("There is no email address for this Emby user, cannot send notification");
+                        // Local User?
-                        // We do not have a emby user that requested this!
+                        var local = localUsers.FirstOrDefault(x => x.UsernameOrAlias.Equals(user));
-                        continue;
+                        if (local != null)
+                        {
+
+                            Log.Info("Sending notification to: {0} at: {1}, for title: {2}", local.UsernameOrAlias, local.EmailAddress, model.Title);
+                            await PublishUserNotification(local.UsernameOrAlias, local.EmailAddress, model.Title, model.PosterPath, type, model.Type);
+                            continue;
+                        }
                     }
 
                     Log.Info("Sending notification to: {0} at: {1}, for title: {2}", email.Name, embyUser.EmailAddress, model.Title); 

Ombi.Services/Notification/PlexNotificationEngine.cs

@@ -171,8 +171,10 @@ namespace Ombi.Services.Notification
             try
             {
                 var settings = await PlexSettings.GetSettingsAsync();
-                var plexUser = PlexApi.GetUsers(settings.PlexAuthToken);
+                
+                var plexUser = PlexApi.GetUsers(settings.PlexAuthToken); // TODO emby
                 var userAccount = PlexApi.GetAccount(settings.PlexAuthToken);
+                var localUsers = UserHelper.GetUsers().ToList();
 
                 var adminUsername = userAccount.Username ?? string.Empty;
 
@@ -219,11 +221,17 @@ namespace Ombi.Services.Notification
                     }
 
                     var email = plexUser.User.FirstOrDefault(x => x.Username.Equals(user, StringComparison.CurrentCultureIgnoreCase));
-                    if (email == null)
+                    if (email == null) // This is not a Plex User
                     {
-                        Log.Info("There is no email address for this Plex user, cannot send notification");
+                        // Local User?
-                        // We do not have a plex user that requested this!
+                        var local = localUsers.FirstOrDefault(x => x.UsernameOrAlias.Equals(user));
-                        continue;
+                        if (local != null)
+                        {
+
+                            Log.Info("Sending notification to: {0} at: {1}, for title: {2}", local.UsernameOrAlias, local.EmailAddress, model.Title);
+                            await PublishUserNotification(local.UsernameOrAlias, local.EmailAddress, model.Title, model.PosterPath, type, model.Type);
+                            continue;
+                        }
                     }
 
                     Log.Info("Sending notification to: {0} at: {1}, for title: {2}", email.Username, email.Email, model.Title);

Ombi.UI/Modules/RequestsModule.cs

@@ -66,8 +66,10 @@ namespace Ombi.UI.Modules
             ICacheProvider cache,
             IAnalytics an,
             IPlexNotificationEngine engine,
+            IEmbyNotificationEngine embyEngine,
             ISecurityExtensions security,
-            ISettingsService<CustomizationSettings> customSettings) : base("requests", prSettings, security)
+            ISettingsService<CustomizationSettings> customSettings,
+            ISettingsService<EmbySettings> embyS) : base("requests", prSettings, security)
         {
             Service = service;
             PrSettings = prSettings;
@@ -81,8 +83,10 @@ namespace Ombi.UI.Modules
             CpApi = cpApi;
             Cache = cache;
             Analytics = an;
-            NotificationEngine = engine;
+            PlexNotificationEngine = engine;
+            EmbyNotificationEngine = embyEngine;
             CustomizationSettings = customSettings;
+            EmbySettings = embyS;
 
             Get["/", true] = async (x, ct) => await LoadRequests();
             Get["/movies", true] = async (x, ct) => await GetMovies();
@@ -111,11 +115,13 @@ namespace Ombi.UI.Modules
         private ISettingsService<SickRageSettings> SickRageSettings { get; }
         private ISettingsService<CouchPotatoSettings> CpSettings { get; }
         private ISettingsService<CustomizationSettings> CustomizationSettings { get; }
+        private ISettingsService<EmbySettings> EmbySettings { get; }
         private ISonarrApi SonarrApi { get; }
         private ISickRageApi SickRageApi { get; }
         private ICouchPotatoApi CpApi { get; }
         private ICacheProvider Cache { get; }
-        private INotificationEngine NotificationEngine { get; }
+        private INotificationEngine PlexNotificationEngine { get; }
+        private INotificationEngine EmbyNotificationEngine { get; }
 
         private async Task<Negotiator> LoadRequests()
         {
@@ -438,7 +444,21 @@ namespace Ombi.UI.Modules
             originalRequest.Available = available;
 
             var result = await Service.UpdateRequestAsync(originalRequest);
-            await NotificationEngine.NotifyUsers(originalRequest, available ? NotificationType.RequestAvailable : NotificationType.RequestDeclined);
+
+            var plexSettings = await PlexSettings.GetSettingsAsync();
+            if (plexSettings.Enable)
+            {
+                await
+                    PlexNotificationEngine.NotifyUsers(originalRequest,
+                        available ? NotificationType.RequestAvailable : NotificationType.RequestDeclined);
+            }
+
+            var embySettings = await EmbySettings.GetSettingsAsync();
+            if (embySettings.Enable)
+            {
+                await EmbyNotificationEngine.NotifyUsers(originalRequest,
+                        available ? NotificationType.RequestAvailable : NotificationType.RequestDeclined);
+            }
             return Response.AsJson(result
                                        ? new { Result = true, Available = available, Message = string.Empty }
                                        : new { Result = false, Available = false, Message = "Could not update the availability, please try again or check the logs" });

Ombi.UI/Views/Admin/NewsletterSettings.cshtml

@@ -20,7 +20,7 @@
                     }
                     else
                     {
-                        <input type="checkbox" id="SendRecentlyAddedEmail" name="SendRecentlyAddedEmail"><label for="SendRecentlyAddedEmail">Enable newslette</label>
+                        <input type="checkbox" id="SendRecentlyAddedEmail" name="SendRecentlyAddedEmail"><label for="SendRecentlyAddedEmail">Enable newsletter</label>
                     }
 
 
@@ -30,7 +30,7 @@
 
               <br>
                 <label for="CustomUsers" class="control-label">Email Addresses to Send to (For users that are not in your User Management section)</label>
-              <small>You can add multiple email address by using the ; delimiter</small>
+              <small>You can add multiple email addresses by using the ; delimiter</small>
 <div>
                     <input type="text" class="form-control form-control-custom " placeholder="first@address.com;second@address.com" id="CustomUsers" name="CustomUsers" value="@Model.CustomUsers">
                 </div>
@@ -115,4 +115,4 @@
         });
 
     });
-</script>
+</script>