added input validation to quality profiles

NzbDrone.Api/Qualities/QualityProfileModule.cs

@@ -1,20 +1,11 @@
 using System.Collections.Generic;
-using NzbDrone.Core.Datastore;
 using NzbDrone.Core.Qualities;
 using NzbDrone.Api.Mapping;
 using System.Linq;
+using FluentValidation;
 
 namespace NzbDrone.Api.Qualities
 {
-
-    public static class LazyLoadedExtensions
-    {
-        public static IEnumerable<int> GetForeignKeys(this IEnumerable<ModelBase> models)
-        {
-            return models.Select(c => c.Id).Distinct();
-        }
-    }
-
     public class QualityProfileModule : NzbDroneRestModule<QualityProfileResource>
     {
         private readonly QualityProfileService _qualityProfileService;
@@ -24,6 +15,10 @@ namespace NzbDrone.Api.Qualities
         {
             _qualityProfileService = qualityProfileService;
 
+            SharedValidator.RuleFor(c => c.Name).NotEmpty();
+            SharedValidator.RuleFor(c => c.Cutoff).NotNull();
+            SharedValidator.RuleFor(c => c.Allowed).NotEmpty();
+
             GetResourceAll = GetAll;
 
             GetResourceById = GetById;

UI/Settings/Quality/Profile/EditQualityProfileTemplate.html

@@ -20,7 +20,7 @@
         <div class="control-group">
             <label class="control-label">Cutoff</label>
             <div class="controls">
-                <select class="x-cutoff" name="cutoff.id">
+                <select class="x-cutoff" name="cutoff.id" validation-name="cutoff">
                     {{#each allowed}}
                     <option value="{{id}}">{{name}}</option>
                     {{/each}}
@@ -41,8 +41,10 @@
             </select>
         </div>
         <div class="span3">
+            <div class="control-group">
+                <div class="controls">
                     <h3>Allowed</h3>
-            <select multiple="multiple" class="x-allowed-list">
+                    <select multiple="multiple" class="x-allowed-list" validation-name="allowed">
                         {{#each allowed}}
                         <option value="{{id}}">{{name}}</option>
                         {{/each}}
@@ -50,6 +52,8 @@
                 </div>
             </div>
         </div>
+    </div>
+</div>
 <div class="modal-footer">
     {{#if id}}
         <button class="btn btn-danger pull-left x-delete">delete</button>

UI/Settings/Quality/Profile/EditQualityProfileView.js

@@ -1,5 +1,11 @@
 'use strict';
-define(['app', 'marionette', 'Mixins/AsModelBoundView'], function (App, Marionette, AsModelBoundView) {
+define(
+    [
+        'app',
+        'marionette',
+        'Mixins/AsModelBoundView',
+        'Mixins/AsValidatedView'
+    ], function (App, Marionette, AsModelBoundView, AsValidatedView) {
 
         var view = Marionette.ItemView.extend({
             template: 'Settings/Quality/Profile/EditQualityProfileTemplate',
@@ -69,6 +75,7 @@ define(['app', 'marionette', 'Mixins/AsModelBoundView'], function (App, Marionet
             }
         });
 
+        AsValidatedView.call(view);
         return AsModelBoundView.call(view);
 
     });