New: (Cardigann) Paging Support

src/NzbDrone.Core/IndexerVersions/IndexerDefinitionUpdateService.cs

@@ -29,7 +29,7 @@ namespace NzbDrone.Core.IndexerVersions
         /* Update Service will fall back if version # does not exist for an indexer  per Ta */
 
         private const string DEFINITION_BRANCH = "master";
-        private const int DEFINITION_VERSION = 8;
+        private const int DEFINITION_VERSION = 9;
 
         // Used when moving yml to C#
         private readonly List<string> _definitionBlocklist = new ()

src/NzbDrone.Core/Indexers/Definitions/Cardigann/Cardigann.cs

@@ -28,10 +28,6 @@ namespace NzbDrone.Core.Indexers.Cardigann
         public override DownloadProtocol Protocol => DownloadProtocol.Torrent;
         public override IndexerPrivacy Privacy => IndexerPrivacy.Private;
 
-        // Page size is different per indexer, setting to 1 ensures we don't break out of paging logic
-        // thinking its a partial page and instead all search_path requests are run for each indexer
-        public override int PageSize => 1;
-
         public override TimeSpan RateLimit
         {
             get
@@ -47,6 +43,21 @@ namespace NzbDrone.Core.Indexers.Cardigann
             }
         }
 
+        public override int PageSize
+        {
+            get
+            {
+                var definition = _definitionService.GetCachedDefinition(Settings.DefinitionFile);
+
+                if (definition.Search != null && definition.Search.PageSize > 0)
+                {
+                    return definition.Search.PageSize;
+                }
+
+                return 0;
+            }
+        }
+
         public override IIndexerRequestGenerator GetRequestGenerator()
         {
             var generator = _generatorCache.Get(Settings.DefinitionFile, () =>
@@ -88,6 +99,25 @@ namespace NzbDrone.Core.Indexers.Cardigann
                 cleanReleases = FilterReleasesByQuery(releases, searchCriteria).ToList();
             }
 
+            // Only take the request results using Offset and Limit from the search
+            var pageSize = PageSize;
+
+            if (pageSize > 0)
+            {
+                var minPage = searchCriteria.Offset / pageSize;
+                var firstResult = searchCriteria.Offset - (pageSize * minPage);
+
+                cleanReleases = cleanReleases
+                    .Skip(firstResult)
+                    .Take(searchCriteria.Limit).ToList();
+            }
+            else
+            {
+                cleanReleases = cleanReleases
+                    .Skip(searchCriteria.Offset)
+                    .Take(searchCriteria.Limit).ToList();
+            }
+
             return cleanReleases;
         }
 

src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannDefinition.cs

@@ -142,6 +142,8 @@ namespace NzbDrone.Core.Indexers.Cardigann
 
     public class SearchBlock
     {
+        public int PageSize { get; set; }
+        public int FirstPageNumber { get; set; }
         public string Path { get; set; }
         public List<SearchPathBlock> Paths { get; set; }
         public Dictionary<string, List<string>> Headers { get; set; }

src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannRequestGenerator.cs

@@ -997,15 +997,6 @@ namespace NzbDrone.Core.Indexers.Cardigann
 
         private IEnumerable<IndexerRequest> GetRequest(Dictionary<string, object> variables, SearchCriteriaBase searchCriteria)
         {
-            var limit = searchCriteria.Limit;
-            var offset = searchCriteria.Offset;
-
-            if (offset > 0 && limit > 0 && offset / limit > 0)
-            {
-                // Pagination doesn't work yet, this is to prevent fetching the first page multiple times.
-                yield break;
-            }
-
             var search = _definition.Search;
 
             var mappedCategories = _categories.MapTorznabCapsToTrackers((int[])variables[".Query.Categories"]);
@@ -1035,8 +1026,31 @@ namespace NzbDrone.Core.Indexers.Cardigann
             variables[".Query.Keywords"] = string.Join(" ", keywordTokens);
             variables[".Keywords"] = ApplyFilters((string)variables[".Query.Keywords"], search.Keywordsfilters, variables);
 
+            var pageSize = search.PageSize;
+            var minPage = 0;
+            var maxPage = 0;
+
+            if (pageSize > 0)
+            {
+                variables[".PageSize"] = pageSize;
+                minPage = (searchCriteria.Offset / pageSize) + search.FirstPageNumber;
+                maxPage = ((searchCriteria.Offset + searchCriteria.Limit - 1) / pageSize) + search.FirstPageNumber;
+            }
+
+            if (pageSize == 0 && searchCriteria.Offset >= 100)
+            {
+                // Indexer doesn't support pagination
+                yield break;
+            }
+
             // TODO: prepare queries first and then send them parallel
             var searchPaths = search.Paths;
+
+            // Grab all pages we will need to return user requested limit and offset
+            for (var page = minPage; page <= maxPage; page++)
+            {
+                variables[".Query.Page"] = page;
+
                 foreach (var searchPath in searchPaths)
                 {
                     // skip path if categories don't match
@@ -1157,4 +1171,5 @@ namespace NzbDrone.Core.Indexers.Cardigann
                 }
             }
         }
+    }
 }