Fixed: Prevent endless loop when calling IndexerUrls for Newznab

Fixes #982

src/NzbDrone.Core/Indexers/Definitions/Newznab/Newznab.cs

@@ -57,6 +57,11 @@ namespace NzbDrone.Core.Indexers.Newznab
             return new string[] { Settings.BaseUrl };
         }
 
+        protected override NewznabSettings GetDefaultBaseUrl(NewznabSettings settings)
+        {
+            return settings;
+        }
+
         public IndexerCapabilities GetCapabilitiesFromSettings()
         {
             var caps = new IndexerCapabilities();

src/NzbDrone.Core/Indexers/IndexerBase.cs

@@ -146,7 +146,7 @@ namespace NzbDrone.Core.Indexers
             return result.DistinctBy(v => v.Guid).ToList();
         }
 
-        protected TSettings GetDefaultBaseUrl(TSettings settings)
+        protected virtual TSettings GetDefaultBaseUrl(TSettings settings)
         {
             var defaultLink = IndexerUrls.FirstOrDefault();
 
@@ -154,8 +154,7 @@ namespace NzbDrone.Core.Indexers
             {
                 settings.BaseUrl = defaultLink;
             }
-
+            else if (settings.BaseUrl.IsNotNullOrWhiteSpace() && LegacyUrls.Contains(settings.BaseUrl))
-            if (settings.BaseUrl.IsNotNullOrWhiteSpace() && LegacyUrls.Contains(settings.BaseUrl))
             {
                 _logger.Debug(string.Format("Changing legacy site link from {0} to {1}", settings.BaseUrl, defaultLink));
                 settings.BaseUrl = defaultLink;