Fixed: (Apps) Prevent null reference exception on sync failure

src/NzbDrone.Core/Applications/LazyLibrarian/LazyLibrarian.cs

@@ -78,6 +78,14 @@ namespace NzbDrone.Core.Applications.LazyLibrarian
             var lazyLibrarianIndexer = BuildLazyLibrarianIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _lazyLibrarianV1Proxy.AddIndexer(lazyLibrarianIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerName = $"{remoteIndexer.Type},{remoteIndexer.Name}" });
         }
 

src/NzbDrone.Core/Applications/Lidarr/Lidarr.cs

@@ -95,6 +95,14 @@ namespace NzbDrone.Core.Applications.Lidarr
             var lidarrIndexer = BuildLidarrIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _lidarrV1Proxy.AddIndexer(lidarrIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerId = remoteIndexer.Id });
         }
 

src/NzbDrone.Core/Applications/Mylar/Mylar.cs

@@ -78,6 +78,14 @@ namespace NzbDrone.Core.Applications.Mylar
             var mylarIndexer = BuildMylarIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _mylarV3Proxy.AddIndexer(mylarIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerName = $"{remoteIndexer.Type},{remoteIndexer.Name}" });
         }
 

src/NzbDrone.Core/Applications/Radarr/Radarr.cs

@@ -95,6 +95,14 @@ namespace NzbDrone.Core.Applications.Radarr
             var radarrIndexer = BuildRadarrIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _radarrV3Proxy.AddIndexer(radarrIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerId = remoteIndexer.Id });
         }
 

src/NzbDrone.Core/Applications/Readarr/Readarr.cs

@@ -96,6 +96,14 @@ namespace NzbDrone.Core.Applications.Readarr
             var readarrIndexer = BuildReadarrIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _readarrV1Proxy.AddIndexer(readarrIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerId = remoteIndexer.Id });
         }
 

src/NzbDrone.Core/Applications/Sonarr/Sonarr.cs

@@ -96,6 +96,14 @@ namespace NzbDrone.Core.Applications.Sonarr
             var sonarrIndexer = BuildSonarrIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _sonarrV3Proxy.AddIndexer(sonarrIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerId = remoteIndexer.Id });
         }
 

src/NzbDrone.Core/Applications/Whisparr/Whisparr.cs

@@ -96,6 +96,14 @@ namespace NzbDrone.Core.Applications.Whisparr
             var whisparrIndexer = BuildWhisparrIndexer(indexer, indexer.Protocol);
 
             var remoteIndexer = _whisparrV3Proxy.AddIndexer(whisparrIndexer, Settings);
+
+            if (remoteIndexer == null)
+            {
+                _logger.Debug("Failed to add {0} [{1}]", indexer.Name, indexer.Id);
+
+                return;
+            }
+
             _appIndexerMapService.Insert(new AppIndexerMap { AppId = Definition.Id, IndexerId = indexer.Id, RemoteIndexerId = remoteIndexer.Id });
         }