Display naming example errors when all fields are empty

frontend/src/Settings/MediaManagement/Naming/Naming.js

@@ -112,17 +112,13 @@ class Naming extends Component {
       if (examples.movieExample) {
         standardMovieFormatHelpTexts.push(`${translate('Movie')}: ${examples.movieExample}`);
       } else {
-        standardMovieFormatErrors.push({ get message() {
+        standardMovieFormatErrors.push({ message: translate('MovieInvalidFormat') });
-          return translate('MovieInvalidFormat');
-        } });
       }
 
       if (examples.movieFolderExample) {
         movieFolderFormatHelpTexts.push(`${translate('Example')}: ${examples.movieFolderExample}`);
       } else {
-        movieFolderFormatErrors.push({ get message() {
+        movieFolderFormatErrors.push({ message: translate('InvalidFormat') });
-          return translate('InvalidFormat');
-        } });
       }
     }
 

frontend/src/Settings/MediaManagement/Naming/NamingConnector.js

@@ -1,4 +1,3 @@
-import _ from 'lodash';
 import PropTypes from 'prop-types';
 import React, { Component } from 'react';
 import { connect } from 'react-redux';
@@ -15,11 +14,11 @@ function createMapStateToProps() {
     (state) => state.settings.advancedSettings,
     (state) => state.settings.namingExamples,
     createSettingsSectionSelector(SECTION),
-    (advancedSettings, examples, sectionSettings) => {
+    (advancedSettings, namingExamples, sectionSettings) => {
       return {
         advancedSettings,
-        examples: examples.item,
+        examples: namingExamples.item,
-        examplesPopulated: !_.isEmpty(examples.item),
+        examplesPopulated: namingExamples.isPopulated,
         ...sectionSettings
       };
     }

src/NzbDrone.Core/Organizer/FileNameBuilder.cs

@@ -107,7 +107,13 @@ namespace NzbDrone.Core.Organizer
                 return GetOriginalTitle(movieFile, false);
             }
 
+            if (namingConfig.StandardMovieFormat.IsNullOrWhiteSpace())
+            {
+                throw new NamingFormatException("Standard movie format cannot be empty");
+            }
+
             var pattern = namingConfig.StandardMovieFormat;
+
             var tokenHandlers = new Dictionary<string, Func<TokenMatch, string>>(FileNameBuilderTokenEqualityComparer.Instance);
             var multipleTokens = TitleRegex.Matches(pattern).Count > 1;
 

src/NzbDrone.Core/Organizer/FileNameSampleService.cs

@@ -90,6 +90,8 @@ namespace NzbDrone.Core.Organizer
             var result = new SampleResult
             {
                 FileName = BuildSample(_movie, _movieFile, nameSpec),
+                Movie = _movie,
+                MovieFile = _movieFile
             };
 
             return result;

src/Radarr.Api.V3/Config/NamingConfigController.cs

@@ -17,17 +17,14 @@ namespace Radarr.Api.V3.Config
         private readonly INamingConfigService _namingConfigService;
         private readonly IFilenameSampleService _filenameSampleService;
         private readonly IFilenameValidationService _filenameValidationService;
-        private readonly IBuildFileNames _filenameBuilder;
 
         public NamingConfigController(INamingConfigService namingConfigService,
                                   IFilenameSampleService filenameSampleService,
-                                  IFilenameValidationService filenameValidationService,
+                                  IFilenameValidationService filenameValidationService)
-                                  IBuildFileNames filenameBuilder)
         {
             _namingConfigService = namingConfigService;
             _filenameSampleService = filenameSampleService;
             _filenameValidationService = filenameValidationService;
-            _filenameBuilder = filenameBuilder;
 
             SharedValidator.RuleFor(c => c.StandardMovieFormat).ValidMovieFormat();
             SharedValidator.RuleFor(c => c.MovieFolderFormat).ValidMovieFolderFormat();
@@ -72,11 +69,11 @@ namespace Radarr.Api.V3.Config
             var movieSampleResult = _filenameSampleService.GetMovieSample(nameSpec);
 
             sampleResource.MovieExample = nameSpec.StandardMovieFormat.IsNullOrWhiteSpace()
-                ? "Invalid Format"
+                ? null
                 : movieSampleResult.FileName;
 
             sampleResource.MovieFolderExample = nameSpec.MovieFolderFormat.IsNullOrWhiteSpace()
-                ? "Invalid format"
+                ? null
                 : _filenameSampleService.GetMovieFolderSample(nameSpec);
 
             return sampleResource;
@@ -90,6 +87,8 @@ namespace Radarr.Api.V3.Config
 
             var validationFailures = new List<ValidationFailure>();
 
+            validationFailures.AddIfNotNull(standardMovieValidationResult);
+
             if (validationFailures.Any())
             {
                 throw new ValidationException(validationFailures.DistinctBy(v => v.PropertyName).ToArray());