Fixed: Rendering Tweaks to UI

pull/6/head
Qstick 6 years ago
parent 2c8b137349
commit 795a445b52

@ -1,5 +1,5 @@
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import React from 'react'; import React, { PureComponent } from 'react';
import classNames from 'classnames'; import classNames from 'classnames';
import formatBytes from 'Utilities/Number/formatBytes'; import formatBytes from 'Utilities/Number/formatBytes';
import { ColorImpairedConsumer } from 'App/ColorImpairedContext'; import { ColorImpairedConsumer } from 'App/ColorImpairedContext';
@ -7,7 +7,13 @@ import DescriptionList from 'Components/DescriptionList/DescriptionList';
import DescriptionListItem from 'Components/DescriptionList/DescriptionListItem'; import DescriptionListItem from 'Components/DescriptionList/DescriptionListItem';
import styles from './ArtistIndexFooter.css'; import styles from './ArtistIndexFooter.css';
function ArtistIndexFooter({ artist }) { class ArtistIndexFooter extends PureComponent {
//
// Render
render() {
const { artist } = this.props;
const count = artist.length; const count = artist.length;
let tracks = 0; let tracks = 0;
let trackFiles = 0; let trackFiles = 0;
@ -142,6 +148,7 @@ function ArtistIndexFooter({ artist }) {
}} }}
</ColorImpairedConsumer> </ColorImpairedConsumer>
); );
}
} }
ArtistIndexFooter.propTypes = { ArtistIndexFooter.propTypes = {

@ -1,11 +1,16 @@
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import React from 'react'; import React, { PureComponent } from 'react';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { kinds } from 'Helpers/Props'; import { kinds } from 'Helpers/Props';
import classNames from 'classnames'; import classNames from 'classnames';
import styles from './Icon.css'; import styles from './Icon.css';
function Icon(props) { class Icon extends PureComponent {
//
// Render
render() {
const { const {
containerClassName, containerClassName,
className, className,
@ -15,7 +20,7 @@ function Icon(props) {
title, title,
isSpinning, isSpinning,
...otherProps ...otherProps
} = props; } = this.props;
const icon = ( const icon = (
<FontAwesomeIcon <FontAwesomeIcon
@ -44,6 +49,7 @@ function Icon(props) {
} }
return icon; return icon;
}
} }
Icon.propTypes = { Icon.propTypes = {

@ -26,6 +26,13 @@ class PageJumpBar extends Component {
this.computeVisibleItems(); this.computeVisibleItems();
} }
shouldComponentUpdate(nextProps, nextState) {
return (
nextProps.items !== this.props.items ||
nextState.height !== this.state.height
);
}
componentDidUpdate(prevProps, prevState) { componentDidUpdate(prevProps, prevState) {
if ( if (
prevProps.items !== this.props.items || prevProps.items !== this.props.items ||

Loading…
Cancel
Save