Sort tags by label

Co-authored-by: Mark McDowall <markus.mcd5@gmail.com>
(cherry picked from commit f32a3cd41c17bb9cb829ac24732cfeec6a18d569)

Fixes #2500

frontend/src/Author/Details/AuthorTagsConnector.js

@@ -1,4 +1,3 @@
-import _ from 'lodash';
 import { connect } from 'react-redux';
 import { createSelector } from 'reselect';
 import createAuthorSelector from 'Store/Selectors/createAuthorSelector';
@@ -10,15 +9,11 @@ function createMapStateToProps() {
     createAuthorSelector(),
     createTagsSelector(),
     (author, tagList) => {
-      const tags = _.reduce(author.tags, (acc, tag) => {
+      const tags = author.tags
-        const matchingTag = _.find(tagList, { id: tag });
+        .map((tagId) => tagList.find((tag) => tag.id === tagId))
-
+        .filter((tag) => !!tag)
-        if (matchingTag) {
+        .map((tag) => tag.label)
-          acc.push(matchingTag.label);
+        .sort((a, b) => a.localeCompare(b));
-        }
-
-        return acc;
-      }, []);
 
       return {
         tags

frontend/src/Components/TagList.js

@@ -1,4 +1,3 @@
-import _ from 'lodash';
 import PropTypes from 'prop-types';
 import React from 'react';
 import { kinds } from 'Helpers/Props';
@@ -6,16 +5,15 @@ import Label from './Label';
 import styles from './TagList.css';
 
 function TagList({ tags, tagList }) {
+  const sortedTags = tags
+    .map((tagId) => tagList.find((tag) => tag.id === tagId))
+    .filter((tag) => !!tag)
+    .sort((a, b) => a.label.localeCompare(b.label));
+
   return (
     <div className={styles.tags}>
       {
-        tags.map((t) => {
+        sortedTags.map((tag) => {
-          const tag = _.find(tagList, { id: t });
-
-          if (!tag) {
-            return null;
-          }
-
           return (
             <Label
               key={tag.id}