More episode update fixes, tests

NzbDrone.Core.Test/EpisodeProviderTest.cs

@@ -66,9 +66,12 @@ namespace NzbDrone.Core.Test
             const int seriesId = 71663;
             var fakeEpisodes = Builder<TvdbSeries>.CreateNew()
                 .With(c => c.Episodes = new List<TvdbEpisode>(Builder<TvdbEpisode>.CreateListOfSize(6).
-                                         WhereAll().Have(l => l.Language = new TvdbLanguage(0, "eng", "a"))
-                                         .WhereTheFirst(3).Have(d => d.SeasonNumber = 1).And(d => d.SeasonId = 11)
-                                         .AndTheRemaining().Have(d => d.SeasonNumber = 2).And(d => d.SeasonId = 22)
+                                                                  WhereAll().Have(
+                                                                      l => l.Language = new TvdbLanguage(0, "eng", "a"))
+                                                                  .WhereTheFirst(3).Have(d => d.SeasonNumber = 1).And(
+                                                                      d => d.SeasonId = 11)
+                                                                  .AndTheRemaining().Have(d => d.SeasonNumber = 2).And(
+                                                                      d => d.SeasonId = 22)
                                                                   .Build())
                 ).With(c => c.Id = seriesId).Build();
 
@@ -113,8 +116,10 @@ namespace NzbDrone.Core.Test
             mocker.Resolve<EpisodeProvider>().RefreshEpisodeInfo(fakeSeries);
 
             //Assert
-            mocker.GetMock<IRepository>().Verify(c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == fakeEpisodes.Episodes.Count)), Times.Once());
-            mocker.GetMock<IRepository>().Verify(c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)), Times.AtMostOnce());
+            mocker.GetMock<IRepository>().Verify(
+                c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == fakeEpisodes.Episodes.Count)), Times.Once());
+            mocker.GetMock<IRepository>().Verify(c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)),
+                                                 Times.AtMostOnce());
             mocker.VerifyAllMocks();
         }
 
@@ -144,12 +149,95 @@ namespace NzbDrone.Core.Test
             mocker.Resolve<EpisodeProvider>().RefreshEpisodeInfo(fakeSeries);
 
             //Assert
-            mocker.GetMock<IRepository>().Verify(c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)), Times.AtMostOnce());
-            mocker.GetMock<IRepository>().Verify(c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == fakeEpisodes.Episodes.Count)), Times.Once());
+            mocker.GetMock<IRepository>().Verify(c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)),
+                                                 Times.AtMostOnce());
+            mocker.GetMock<IRepository>().Verify(
+                c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == fakeEpisodes.Episodes.Count)),
+                Times.Once());
             mocker.VerifyAllMocks();
         }
 
 
+        [Test]
+        public void should_try_to_get_existing_episode_using_tvdbid_first()
+        {
+            const int seriesId = 71663;
+            var fakeEpisodes = Builder<TvdbSeries>.CreateNew()
+                .With(c => c.Id = seriesId)
+                .With(c => c.Episodes = new List<TvdbEpisode>(
+                                                                Builder<TvdbEpisode>.CreateListOfSize(1)
+                                                                .WhereAll().Have(g => g.Id = 99)
+                                                                .Build())
+                                                             )
+                .Build();
+
+            var fakeSeries = Builder<Series>.CreateNew().With(c => c.SeriesId = seriesId).Build();
+
+
+            var mocker = new AutoMoqer();
+
+            var repo = MockLib.GetEmptyRepository();
+            repo.Add<Episode>(
+                Builder<Episode>.CreateNew().With(c => c.TvDbEpisodeId = fakeEpisodes.Episodes[0].Id).Build());
+            mocker.SetConstant(repo);
+
+            mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
+                .Setup(c => c.GetSeries(seriesId, true))
+                .Returns(fakeEpisodes);
+
+            //Act
+            mocker.Resolve<EpisodeProvider>().RefreshEpisodeInfo(fakeSeries);
+
+            //Assert
+            mocker.VerifyAllMocks();
+            Assert.Count(1, repo.All<Episode>());
+        }
+
+        [Test]
+        public void should_try_to_get_existing_episode_using_tvdbid_first_then_season_episode()
+        {
+            const int seriesId = 71663;
+            var fakeEpisodes = Builder<TvdbSeries>.CreateNew()
+                .With(c => c.Id = seriesId)
+                .With(c => c.Episodes = new List<TvdbEpisode>{
+                                                                Builder<TvdbEpisode>.CreateNew()
+                                                                .With(g => g.Id = 99)
+                                                                .With(g => g.SeasonNumber = 4)
+                                                                .With(g => g.EpisodeNumber = 15)
+                                                                .With(g=>g.SeriesId = seriesId)
+                                                                .Build()
+                                                               })
+                .Build();
+
+            var localEpisode = Builder<Episode>.CreateNew()
+                .With(c => c.SeriesId = seriesId)
+                .With(c => c.SeasonNumber = 4)
+                .With(c => c.EpisodeNumber = 15)
+                .Build();
+              
+
+            var fakeSeries = Builder<Series>.CreateNew().With(c => c.SeriesId = seriesId).Build();
+
+
+            var mocker = new AutoMoqer();
+
+            var repo = MockLib.GetEmptyRepository();
+            repo.Add<Episode>(localEpisode);
+            mocker.SetConstant(repo);
+
+            mocker.GetMock<TvDbProvider>(MockBehavior.Strict)
+                .Setup(c => c.GetSeries(seriesId, true))
+                .Returns(fakeEpisodes);
+
+            //Act
+            mocker.Resolve<EpisodeProvider>().RefreshEpisodeInfo(fakeSeries);
+
+            //Assert
+            mocker.VerifyAllMocks();
+            Assert.Count(1, repo.All<Episode>());
+        }
+
+
         [Test]
         public void existing_episodes_keep_their_episodeId_file_id()
         {
@@ -159,7 +247,8 @@ namespace NzbDrone.Core.Test
                 ).With(c => c.Id = seriesId).Build();
 
             var fakeSeries = Builder<Series>.CreateNew().With(c => c.SeriesId = seriesId).Build();
-            var fakeEpisode = Builder<Episode>.CreateNew().With(c => c.EpisodeFileId = 69).And(c => c.EpisodeId = 99).Build();
+            var fakeEpisode =
+                Builder<Episode>.CreateNew().With(c => c.EpisodeFileId = 69).And(c => c.EpisodeId = 99).Build();
 
             var mocker = new AutoMoqer();
 
@@ -178,27 +267,28 @@ namespace NzbDrone.Core.Test
                 .Returns(faketvDbResponse.Episodes.Count)
                 .Callback<IEnumerable<Episode>>(r => updatedEpisodes = r);
 
-
-
-
             //Act
             mocker.Resolve<EpisodeProvider>().RefreshEpisodeInfo(fakeSeries);
 
             //Assert
-            mocker.GetMock<IRepository>().Verify(c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)), Times.AtMostOnce());
-            mocker.GetMock<IRepository>().Verify(c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == faketvDbResponse.Episodes.Count)), Times.Once());
-            mocker.GetMock<IRepository>().Verify(c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Where(g => g.EpisodeFileId == 69).Count() == faketvDbResponse.Episodes.Count)), Times.Once());
+            mocker.GetMock<IRepository>().Verify(c => c.AddMany(It.Is<IEnumerable<Episode>>(e => e.Count() == 0)),
+                                                 Times.AtMostOnce());
+            mocker.GetMock<IRepository>().Verify(
+                c => c.UpdateMany(It.Is<IEnumerable<Episode>>(e => e.Count() == faketvDbResponse.Episodes.Count)),
+                Times.Once());
+            mocker.GetMock<IRepository>().Verify(
+                c =>
+                c.UpdateMany(
+                    It.Is<IEnumerable<Episode>>(
+                        e => e.Where(g => g.EpisodeFileId == 69).Count() == faketvDbResponse.Episodes.Count)),
+                Times.Once());
 
             Assert.Count(faketvDbResponse.Episodes.Count, updatedEpisodes);
             Assert.ForAll(updatedEpisodes, c => Assert.AreEqual(99, c.EpisodeId));
             Assert.ForAll(updatedEpisodes, c => Assert.AreEqual(69, c.EpisodeFileId));
-
-
         }
 
 
-
-
         [Test]
         [Explicit]
         public void Add_daily_show_episodes()
@@ -219,8 +309,5 @@ namespace NzbDrone.Core.Test
             var episodes = episodeProvider.GetEpisodeBySeries(tvDbSeriesId);
             Assert.IsNotEmpty(episodes);
         }
-
-
-
     }
-}
+}