Improve matches and readability for Argenteam provider

libs/subliminal_patch/providers/argenteam.py

@@ -9,141 +9,45 @@ from zipfile import ZipFile
 from guessit import guessit
 from requests import Session
 from subliminal import Episode, Movie
-from subliminal.score import get_equivalent_release_groups
+from subliminal.utils import sanitize
-from subliminal.utils import sanitize_release_group, sanitize
 from subliminal_patch.providers import Provider
 from subliminal_patch.subtitle import Subtitle, guess_matches
 from subliminal_patch.providers.mixins import ProviderSubtitleArchiveMixin
 from subzero.language import Language
 
+BASE_URL = "https://argenteam.net/"
+API_URL = BASE_URL + "api/v1/"
+
 logger = logging.getLogger(__name__)
 
 
 class ArgenteamSubtitle(Subtitle):
-    provider_name = 'argenteam'
+    provider_name = "argenteam"
     hearing_impaired_verifiable = False
-    _release_info = None
 
-    def __init__(self, language, page_link, download_link, movie_kind, title, season, episode, year, release, version, source,
+    def __init__(self, language, page_link, download_link, release_info, matches):
-                 video_codec, tvdb_id, imdb_id, asked_for_episode=None, asked_for_release_group=None, *args, **kwargs):
+        super(ArgenteamSubtitle, self).__init__(language, page_link=page_link)
-        super(ArgenteamSubtitle, self).__init__(language, page_link=page_link, *args, **kwargs)
         self.page_link = page_link
         self.download_link = download_link
-        self.movie_kind = movie_kind
+        self.found_matches = matches
-        self.title = title
+        self.release_info = release_info
-        self.year = year
-        self.season = season
-        self.episode = episode
-        self.release = release
-        self.version = version
-        self.asked_for_release_group = asked_for_release_group
-        self.asked_for_episode = asked_for_episode
-        self.matches = None
-        self.source = source
-        self.video_codec = video_codec
-        self.tvdb_id = tvdb_id
-        self.imdb_id = "tt" + imdb_id if imdb_id else None
-        self.releases = self.release_info
 
     @property
     def id(self):
         return self.download_link
 
-    @property
-    def release_info(self):
-        if self._release_info:
-            return self._release_info
-
-        combine = []
-        for attr in ("source", "version"):
-            value = getattr(self, attr)
-            if value:
-                combine.append(value)
-
-        self._release_info = u".".join(combine) + (u"-"+self.release if self.release else "")
-        return self._release_info
-
-    def __repr__(self):
-        ep_addon = (" S%02dE%02d" % (self.season, self.episode)) if self.episode else ""
-        return '<%s %r [%s]>' % (
-            self.__class__.__name__, u"%s%s%s." % (self.title, " (%s)" % self.year if self.year else "", ep_addon) +
-            self.release_info, self.language)
-
     def get_matches(self, video):
-        matches = set()
+        # Download links always have the srt filename with the release info.
-        # series
+        # We combine it with the release info as guessit will return the first key match.
-        if isinstance(video, Episode) and self.movie_kind == 'episode':
+        new_file = self.download_link.split("/")[-1] + self.release_info
-            if video.series and (sanitize(self.title) in (
+        self.found_matches |= guess_matches(video, guessit(new_file))
-                     sanitize(name) for name in [video.series] + video.alternative_series)):
+        return self.found_matches
-                matches.add('series')
-
-            # season
-            if video.season and self.season == video.season:
-                matches.add('season')
-
-            # episode
-            if video.episode and self.episode == video.episode:
-                matches.add('episode')
-
-            # tvdb_id
-            if video.tvdb_id and str(self.tvdb_id) == str(video.tvdb_id):
-                matches.add('tvdb_id')
-
-            # year (year is not available for series, but we assume it matches)
-            matches.add('year')
-
-        elif isinstance(video, Movie) and self.movie_kind == 'movie':
-            # title
-            if video.title and (sanitize(self.title) in (
-                     sanitize(name) for name in [video.title] + video.alternative_titles)):
-                matches.add('title')
-
-            # imdb_id
-            if video.imdb_id and self.imdb_id and str(self.imdb_id) == str(video.imdb_id):
-                matches.add('imdb_id')
-
-            # year
-            if video.year and self.year == video.year:
-                matches.add('year')
-        else:
-            logger.info('%r is not a valid movie_kind', self.movie_kind)
-            return matches
-
-        # release_group
-        if video.release_group and self.release:
-            rg = sanitize_release_group(video.release_group)
-            if any(r in sanitize_release_group(self.release) for r in get_equivalent_release_groups(rg)):
-                matches.add('release_group')
-
-                # blatantly assume we've got a matching source if the release group matches
-                # fixme: smart?
-                #matches.add('source')
-
-        # resolution
-        if video.resolution and self.version and str(video.resolution) in self.version.lower():
-            matches.add('resolution')
-        # source
-        if video.source and self.source:
-            formats = [video.source]
-            if video.source == "Web":
-                formats.append("WEB")
-
-            for fmt in formats:
-                if fmt.lower() in self.source.lower():
-                    matches.add('source')
-                    break
-
-        matches |= guess_matches(video, guessit(self.release_info), partial=True)
-        self.matches = matches
-        return matches
 
 
 class ArgenteamProvider(Provider, ProviderSubtitleArchiveMixin):
-    provider_name = 'argenteam'
+    provider_name = "argenteam"
-    languages = {Language.fromalpha2(l) for l in ['es']}
+    languages = {Language.fromalpha2(l) for l in ["es"]}
     video_types = (Episode, Movie)
-    BASE_URL = "https://argenteam.net/"
-    API_URL = BASE_URL + "api/v1/"
     subtitle_class = ArgenteamSubtitle
     hearing_impaired_verifiable = False
     language_list = list(languages)
@@ -155,77 +59,130 @@ class ArgenteamProvider(Provider, ProviderSubtitleArchiveMixin):
 
     def initialize(self):
         self.session = Session()
-        self.session.headers = {'User-Agent': os.environ.get("SZ_USER_AGENT", "Sub-Zero/2")}
+        self.session.headers = {
+            "User-Agent": os.environ.get("SZ_USER_AGENT", "Sub-Zero/2")
+        }
 
     def terminate(self):
         self.session.close()
 
-    def search_ids(self, title, year=None, imdb_id=None, season=None, episode=None, titles=None):
+    def search_ids(self, title, **kwargs):
-        """Search movie or episode id from the `title`, `season` and `episode`.
-
-        :param imdb_id: imdb id of the given movie
-        :param titles: all titles of the given series or movie
-        :param year: release year of the given movie
-        :param str title: series of the episode or movie name
-        :param int season: season of the episode.
-        :param int episode: episode number.
-        :return: list of ids
-        :rtype: list
-
-        """
-        # make the search
         query = title
-        titles = titles or []
+        titles = kwargs.get("titles") or []
 
         is_episode = False
-        if season and episode:
+        if kwargs.get("season") and kwargs.get("episode"):
             is_episode = True
-            query = '%s S%#02dE%#02d' % (title, season, episode)
+            query = f"{title} S{kwargs['season']:02}E{kwargs['episode']:02}"
 
-        logger.info(u'Searching %s ID for %r', "episode" if is_episode else "movie", query)
+        logger.info(f"Searching ID (episode: {is_episode}) for {query}")
-        r = self.session.get(self.API_URL + 'search', params={'q': query}, timeout=10)
+
+        r = self.session.get(API_URL + "search", params={"q": query}, timeout=10)
         r.raise_for_status()
+
         results = r.json()
         match_ids = []
-        if results['total'] >= 1:
+        if results["total"] >= 1:
             for result in results["results"]:
-                if (result['type'] == "episode" and not is_episode) or (result['type'] == "movie" and is_episode):
+                if (result["type"] == "episode" and not is_episode) or (
+                    result["type"] == "movie" and is_episode
+                ):
                     continue
 
-                # shortcut in case of matching imdb id
+                # shortcut in case of matching imdb id (don't match NoneType)
-                if not is_episode and imdb_id and "imdb" in result and "tt%s" % result["imdb"] == str(imdb_id):
+                if not is_episode and f"tt{result.get('imdb', 'n/a')}" == kwargs.get(
-                    logger.debug("Movie matched by IMDB ID %s, taking shortcut", imdb_id)
+                    "imdb_id"
-                    match_ids = [result['id']]
+                ):
+                    logger.debug(f"Movie matched by IMDB ID, taking shortcut")
+                    match_ids = [result["id"]]
                     break
 
                 # advanced title check in case of multiple movie results
-                if results['total'] > 1:
+                if results["total"] > 1:
-                    if not is_episode and year:
+                    if not is_episode and kwargs.get("year"):
-                        if result["title"] and not (sanitize(result["title"]) in (u"%s %s" % (sanitize(name), year)
+                        if result["title"] and not (
-                                                                                  for name in titles)):
+                            sanitize(result["title"])
+                            in (
+                                "%s %s" % (sanitize(name), kwargs.get("year"))
+                                for name in titles
+                            )
+                        ):
                             continue
 
-                match_ids.append(result['id'])
+                match_ids.append(result["id"])
         else:
-            logger.error(u'No episode ID found for %r', query)
+            logger.error(f"No episode ID found for {query}")
 
         if match_ids:
-            logger.debug(u"Found matching IDs: %s", ", ".join(str(id) for id in match_ids))
+            logger.debug(
+                f"Found matching IDs: {', '.join(str(id) for id in match_ids)}"
+            )
 
         return match_ids
 
+    def get_query_matches(self, video, **kwargs):
+        matches = set()
+        if isinstance(video, Episode) and kwargs.get("movie_kind") == "episode":
+            if video.series and (
+                sanitize(kwargs.get("title"))
+                in (
+                    sanitize(name) for name in [video.series] + video.alternative_series
+                )
+            ):
+                matches.add("series")
+
+            if video.season and kwargs.get("season") == video.season:
+                matches.add("season")
+
+            if video.episode and kwargs.get("episode") == video.episode:
+                matches.add("episode")
+
+            if video.tvdb_id and kwargs.get("tvdb_id") == str(video.tvdb_id):
+                matches.add("tvdb_id")
+
+            # year (year is not available for series, but we assume it matches)
+            matches.add("year")
+
+        elif isinstance(video, Movie) and kwargs.get("movie_kind") == "movie":
+            if video.title and (
+                sanitize(kwargs.get("title"))
+                in (sanitize(name) for name in [video.title] + video.alternative_titles)
+            ):
+                matches.add("title")
+
+            if video.imdb_id and f"tt{kwargs.get('imdb_id')}" == str(video.imdb_id):
+                matches.add("imdb_id")
+
+            if video.year and kwargs.get("year") == video.year:
+                matches.add("year")
+        else:
+            logger.info(f"{kwargs.get('movie_kind')} is not a valid movie_kind")
+
+        return matches
+
+    def combine_release_info(self, release_dict):
+        keys = ("source", "codec", "tags", "team")
+        combine = [release_dict.get(key) for key in keys if release_dict.get(key)]
+        if combine:
+            return ".".join(combine)
+        return "Unknown"
+
     def query(self, title, video, titles=None):
         is_episode = isinstance(video, Episode)
         season = episode = None
-        url = self.API_URL + 'movie'
+        url = API_URL + "movie"
         if is_episode:
             season = video.season
             episode = video.episode
-            url = self.API_URL + 'episode'
+            url = API_URL + "episode"
-            argenteam_ids = self.search_ids(title, season=season, episode=episode, titles=titles)
+            argenteam_ids = self.search_ids(
+                title, season=season, episode=episode, titles=titles
+            )
 
         else:
-            argenteam_ids = self.search_ids(title, year=video.year, imdb_id=video.imdb_id, titles=titles)
+            argenteam_ids = self.search_ids(
+                title, year=video.year, imdb_id=video.imdb_id, titles=titles
+            )
 
         if not argenteam_ids:
             return []
@@ -234,11 +191,12 @@ class ArgenteamProvider(Provider, ProviderSubtitleArchiveMixin):
         subtitles = []
         has_multiple_ids = len(argenteam_ids) > 1
         for aid in argenteam_ids:
-            response = self.session.get(url, params={'id': aid}, timeout=10)
+            response = self.session.get(url, params={"id": aid}, timeout=10)
             response.raise_for_status()
             content = response.json()
+            if not content:
+                continue
 
-            if content is not None:  # eg https://argenteam.net/api/v1/episode?id=11534
             imdb_id = year = None
             returned_title = title
             if not is_episode and "info" in content:
@@ -246,18 +204,32 @@ class ArgenteamProvider(Provider, ProviderSubtitleArchiveMixin):
                 year = content["info"].get("year")
                 returned_title = content["info"].get("title", title)
 
-                for r in content['releases']:
+            for r in content["releases"]:
-                    for s in r['subtitles']:
+                for s in r["subtitles"]:
                     movie_kind = "episode" if is_episode else "movie"
-                        page_link = self.BASE_URL + movie_kind + "/" + str(aid)
+                    page_link = f"{BASE_URL}{movie_kind}/{aid}"
-                        # use https and new domain
+                    release_info = self.combine_release_info(r)
-                        download_link = s['uri'].replace('http://www.argenteam.net/', self.BASE_URL)
+                    download_link = s["uri"].replace("http", "https")
-                        sub = ArgenteamSubtitle(language, page_link, download_link, movie_kind, returned_title,
+
-                                                season, episode, year, r.get('team'), r.get('tags'),
+                    matches_ = self.get_query_matches(
-                                                r.get('source'), r.get('codec'), content.get("tvdb"), imdb_id,
+                        video,
-                                                asked_for_release_group=video.release_group,
+                        movie_kind=movie_kind,
-                                                asked_for_episode=episode)
+                        season=season,
-                        subtitles.append(sub)
+                        episode=episode,
+                        title=returned_title,
+                        year=year,
+                        imdb_id=imdb_id,
+                        tvdb_id=content.get("tvdb"),
+                    )
+                    subtitles.append(
+                        ArgenteamSubtitle(
+                            language,
+                            page_link,
+                            download_link,
+                            release_info,
+                            matches_,
+                        )
+                    )
 
             if has_multiple_ids:
                 time.sleep(self.multi_result_throttle)
@@ -280,7 +252,7 @@ class ArgenteamProvider(Provider, ProviderSubtitleArchiveMixin):
 
     def download_subtitle(self, subtitle):
         # download as a zip
-        logger.info('Downloading subtitle %r', subtitle)
+        logger.info("Downloading subtitle %r", subtitle)
         r = self.session.get(subtitle.download_link, timeout=10)
         r.raise_for_status()