Feature/harmonize axis style of charts (#1768)

* Harmonize axis style

* Update changelog
pull/1773/head^2
Thomas Kaul 2 years ago committed by GitHub
parent 002ac29f2f
commit 1e42d6bffa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Harmonized the axis style of charts
- Removed the environment variable `ENABLE_FEATURE_CUSTOM_SYMBOLS` - Removed the environment variable `ENABLE_FEATURE_CUSTOM_SYMBOLS`
## 1.242.0 - 2023-03-04 ## 1.242.0 - 2023-03-04

@ -1,6 +1,7 @@
<div> <div>
<gf-line-chart <gf-line-chart
class="mb-4" class="mb-4"
[colorScheme]="user?.settings?.colorScheme"
[historicalDataItems]="historicalDataItems" [historicalDataItems]="historicalDataItems"
[isAnimated]="true" [isAnimated]="true"
[locale]="locale" [locale]="locale"
@ -28,7 +29,7 @@
}" }"
[title]=" [title]="
(itemByMonth.key + '-' + (i + 1 < 10 ? '0' + (i + 1) : i + 1) (itemByMonth.key + '-' + (i + 1 < 10 ? '0' + (i + 1) : i + 1)
| date: defaultDateFormat) ?? '' | date : defaultDateFormat) ?? ''
" "
(click)=" (click)="
onOpenMarketDataDetail({ onOpenMarketDataDetail({

@ -166,7 +166,6 @@ export class BenchmarkComparatorComponent implements OnChanges, OnDestroy {
}, },
display: true, display: true,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`,
display: false display: false
}, },
type: 'time', type: 'time',
@ -177,13 +176,21 @@ export class BenchmarkComparatorComponent implements OnChanges, OnDestroy {
}, },
y: { y: {
border: { border: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.1)`, width: 0
display: false
}, },
display: true, display: true,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`, color: ({ scale, tick }) => {
display: false if (
tick.value === 0 ||
tick.value === scale.max ||
tick.value === scale.min
) {
return `rgba(${getTextColor(this.colorScheme)}, 0.1)`;
}
return 'transparent';
}
}, },
position: 'right', position: 'right',
ticks: { ticks: {

@ -10,6 +10,7 @@
symbol="Fear & Greed Index" symbol="Fear & Greed Index"
yMax="100" yMax="100"
yMin="0" yMin="0"
[colorScheme]="user?.settings?.colorScheme"
[historicalDataItems]="historicalDataItems" [historicalDataItems]="historicalDataItems"
[isAnimated]="true" [isAnimated]="true"
[locale]="user?.settings?.locale" [locale]="user?.settings?.locale"

@ -283,7 +283,6 @@ export class InvestmentChartComponent implements OnChanges, OnDestroy {
}, },
display: true, display: true,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`,
display: false display: false
}, },
min: this.daysInMarket min: this.daysInMarket
@ -298,13 +297,21 @@ export class InvestmentChartComponent implements OnChanges, OnDestroy {
}, },
y: { y: {
border: { border: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.1)`,
display: false display: false
}, },
display: !this.isInPercent, display: !this.isInPercent,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`, color: ({ scale, tick }) => {
display: false if (
tick.value === 0 ||
tick.value === scale.max ||
tick.value === scale.min
) {
return `rgba(${getTextColor(this.colorScheme)}, 0.1)`;
}
return 'transparent';
}
}, },
position: 'right', position: 'right',
ticks: { ticks: {

@ -217,7 +217,6 @@ export class LineChartComponent implements AfterViewInit, OnChanges, OnDestroy {
}, },
display: this.showXAxis, display: this.showXAxis,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`,
display: false display: false
}, },
time: { time: {
@ -228,12 +227,23 @@ export class LineChartComponent implements AfterViewInit, OnChanges, OnDestroy {
}, },
y: { y: {
border: { border: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.1)` width: 0
}, },
display: this.showYAxis, display: this.showYAxis,
grid: { grid: {
color: `rgba(${getTextColor(this.colorScheme)}, 0.8)`, color: ({ scale, tick }) => {
display: false if (
tick.value === 0 ||
tick.value === scale.max ||
tick.value === scale.min ||
tick.value === this.yMax ||
tick.value === this.yMin
) {
return `rgba(${getTextColor(this.colorScheme)}, 0.1)`;
}
return 'transparent';
}
}, },
max: this.yMax, max: this.yMax,
min: this.yMin, min: this.yMin,

Loading…
Cancel
Save