add errors in case gross performance is not set

3 years ago · 9b1e9397a8
parent b779964adb
commit 9b1e9397a8
1 changed files with 4 additions and 2 deletions
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@ -474,16 +474,18 @@ export class PortfolioService {
        new Big(currentPosition.marketPrice).mul(currentPosition.quantity)
      );
      if (currentPosition.grossPerformance) {
-        hasErrors = true;
        grossPerformance = grossPerformance.plus(
          currentPosition.grossPerformance
        );
+      } else {
+        hasErrors = true;
      }
      if (currentPosition.grossPerformancePercentage) {
-        hasErrors = true;
        grossPerformancePercentage = grossPerformancePercentage.mul(
          currentPosition.grossPerformancePercentage.plus(1)
        );
+      } else {
+        hasErrors = true;
      }
    }