Feature/minor improvements in chart components (#1353)

* Move y axis to the right

* Update changelog
pull/1355/head
Thomas Kaul 2 years ago committed by GitHub
parent 246de7aa86
commit ccb8c86596
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Respected the current date in the _FIRE_ calculator
- Simplified the settings management in the admin control panel - Simplified the settings management in the admin control panel
- Renamed the data source type `RAKUTEN` to `RAPID_API` - Renamed the data source type `RAKUTEN` to `RAPID_API`

@ -51,8 +51,6 @@ export class FireCalculatorComponent
@ViewChild('chartCanvas') chartCanvas; @ViewChild('chartCanvas') chartCanvas;
private readonly CONTRIBUTION_PERIOD = 12;
public calculatorForm = this.formBuilder.group({ public calculatorForm = this.formBuilder.group({
annualInterestRate: new FormControl<number>(undefined), annualInterestRate: new FormControl<number>(undefined),
paymentPerPeriod: new FormControl<number>(undefined), paymentPerPeriod: new FormControl<number>(undefined),
@ -63,6 +61,7 @@ export class FireCalculatorComponent
public isLoading = true; public isLoading = true;
public projectedTotalAmount: number; public projectedTotalAmount: number;
private readonly CONTRIBUTION_PERIOD = 12;
private unsubscribeSubject = new Subject<void>(); private unsubscribeSubject = new Subject<void>();
public constructor( public constructor(
@ -235,6 +234,7 @@ export class FireCalculatorComponent
grid: { grid: {
display: false display: false
}, },
position: 'right',
stacked: true, stacked: true,
ticks: { ticks: {
callback: (value: number) => { callback: (value: number) => {

@ -231,8 +231,8 @@ export class LineChartComponent implements AfterViewInit, OnChanges, OnDestroy {
}, },
max: this.yMax, max: this.yMax,
min: this.yMin, min: this.yMin,
position: 'right',
ticks: { ticks: {
display: this.showYAxis,
callback: (tickValue, index, ticks) => { callback: (tickValue, index, ticks) => {
if (index === 0 || index === ticks.length - 1) { if (index === 0 || index === ticks.length - 1) {
// Only print last and first legend entry // Only print last and first legend entry
@ -254,6 +254,7 @@ export class LineChartComponent implements AfterViewInit, OnChanges, OnDestroy {
return ''; return '';
}, },
display: this.showYAxis,
mirror: true, mirror: true,
z: 1 z: 1
}, },

Loading…
Cancel
Save