Apply review suggestions

pull/9254/head
Shadowghost 1 year ago
parent 47aa07c342
commit 0da5255f12

@ -329,7 +329,7 @@ public class TranscodingJobHelper : IDisposable
if (File.Exists(concatFilePath)) if (File.Exists(concatFilePath))
{ {
_logger.LogInformation("Deleting ffmpeg concat configuration at {Path}", concatFilePath); _logger.LogInformation("Deleting ffmpeg concat configuration at {Path}", concatFilePath);
_fileSystem.DeleteFile(concatFilePath); File.Delete(concatFilePath);
} }
} }
} }

@ -533,19 +533,12 @@ namespace MediaBrowser.Controller.MediaEncoding
public string GetInputPathArgument(EncodingJobInfo state) public string GetInputPathArgument(EncodingJobInfo state)
{ {
var mediaPath = state.MediaPath ?? string.Empty; return state.MediaSource.VideoType switch
if (state.MediaSource.VideoType == VideoType.Dvd)
{ {
return _mediaEncoder.GetInputArgument(_mediaEncoder.GetPrimaryPlaylistVobFiles(state.MediaPath, null).ToList(), state.MediaSource); VideoType.Dvd => _mediaEncoder.GetInputArgument(_mediaEncoder.GetPrimaryPlaylistVobFiles(state.MediaPath, null).ToList(), state.MediaSource),
} VideoType.BluRay => _mediaEncoder.GetInputArgument(_mediaEncoder.GetPrimaryPlaylistM2tsFiles(state.MediaPath).ToList(), state.MediaSource),
_ => _mediaEncoder.GetInputArgument(state.MediaPath, state.MediaSource)
if (state.MediaSource.VideoType == VideoType.BluRay) };
{
return _mediaEncoder.GetInputArgument(_mediaEncoder.GetPrimaryPlaylistM2tsFiles(state.MediaPath).ToList(), state.MediaSource);
}
return _mediaEncoder.GetInputArgument(mediaPath, state.MediaSource);
} }
/// <summary> /// <summary>
@ -945,10 +938,8 @@ namespace MediaBrowser.Controller.MediaEncoding
{ {
var tmpConcatPath = Path.Join(options.TranscodingTempPath, state.MediaSource.Id + ".concat"); var tmpConcatPath = Path.Join(options.TranscodingTempPath, state.MediaSource.Id + ".concat");
_mediaEncoder.GenerateConcatConfig(state.MediaSource, tmpConcatPath); _mediaEncoder.GenerateConcatConfig(state.MediaSource, tmpConcatPath);
arg.Append(" -f concat -safe 0 ") arg.Append(" -f concat -safe 0 -i ")
.Append(" -i ") .Append(tmpConcatPath);
.Append(tmpConcatPath)
.Append(' ');
} }
else else
{ {

@ -202,14 +202,14 @@ namespace MediaBrowser.Controller.MediaEncoding
/// <param name="path">The to the .vob files.</param> /// <param name="path">The to the .vob files.</param>
/// <param name="titleNumber">The title number to start with.</param> /// <param name="titleNumber">The title number to start with.</param>
/// <returns>A playlist.</returns> /// <returns>A playlist.</returns>
IEnumerable<string> GetPrimaryPlaylistVobFiles(string path, uint? titleNumber); IReadOnlyList<string> GetPrimaryPlaylistVobFiles(string path, uint? titleNumber);
/// <summary> /// <summary>
/// Gets the primary playlist of .m2ts files. /// Gets the primary playlist of .m2ts files.
/// </summary> /// </summary>
/// <param name="path">The to the .m2ts files.</param> /// <param name="path">The to the .m2ts files.</param>
/// <returns>A playlist.</returns> /// <returns>A playlist.</returns>
IEnumerable<string> GetPrimaryPlaylistM2tsFiles(string path); IReadOnlyList<string> GetPrimaryPlaylistM2tsFiles(string path);
/// <summary> /// <summary>
/// Generates a FFmpeg concat config for the source. /// Generates a FFmpeg concat config for the source.

@ -1,83 +1,123 @@
#pragma warning disable CS1591
using System; using System;
using System.IO;
using System.Linq; using System.Linq;
using BDInfo.IO; using BDInfo.IO;
using MediaBrowser.Model.IO; using MediaBrowser.Model.IO;
namespace MediaBrowser.MediaEncoding.BdInfo namespace MediaBrowser.MediaEncoding.BdInfo;
/// <summary>
/// Class BdInfoDirectoryInfo.
/// </summary>
public class BdInfoDirectoryInfo : IDirectoryInfo
{ {
public class BdInfoDirectoryInfo : IDirectoryInfo private readonly IFileSystem _fileSystem;
{
private readonly IFileSystem _fileSystem;
private readonly FileSystemMetadata _impl; private readonly FileSystemMetadata _impl;
public BdInfoDirectoryInfo(IFileSystem fileSystem, string path) /// <summary>
{ /// Initializes a new instance of the <see cref="BdInfoDirectoryInfo" /> class.
_fileSystem = fileSystem; /// </summary>
_impl = _fileSystem.GetDirectoryInfo(path); /// <param name="fileSystem">The filesystem.</param>
} /// <param name="path">The path.</param>
public BdInfoDirectoryInfo(IFileSystem fileSystem, string path)
{
_fileSystem = fileSystem;
_impl = _fileSystem.GetDirectoryInfo(path);
}
private BdInfoDirectoryInfo(IFileSystem fileSystem, FileSystemMetadata impl) private BdInfoDirectoryInfo(IFileSystem fileSystem, FileSystemMetadata impl)
{ {
_fileSystem = fileSystem; _fileSystem = fileSystem;
_impl = impl; _impl = impl;
} }
public string Name => _impl.Name; /// <summary>
/// Gets the name.
/// </summary>
public string Name => _impl.Name;
public string FullName => _impl.FullName; /// <summary>
/// Gets the full name.
/// </summary>
public string FullName => _impl.FullName;
public IDirectoryInfo? Parent /// <summary>
/// Gets the parent directory information.
/// </summary>
public IDirectoryInfo? Parent
{
get
{ {
get var parentFolder = Path.GetDirectoryName(_impl.FullName);
if (parentFolder is not null)
{ {
var parentFolder = System.IO.Path.GetDirectoryName(_impl.FullName); return new BdInfoDirectoryInfo(_fileSystem, parentFolder);
if (parentFolder is not null)
{
return new BdInfoDirectoryInfo(_fileSystem, parentFolder);
}
return null;
} }
}
public IDirectoryInfo[] GetDirectories() return null;
{
return Array.ConvertAll(
_fileSystem.GetDirectories(_impl.FullName).ToArray(),
x => new BdInfoDirectoryInfo(_fileSystem, x));
} }
}
public IFileInfo[] GetFiles() /// <summary>
{ /// Gets the directories.
return Array.ConvertAll( /// </summary>
_fileSystem.GetFiles(_impl.FullName).ToArray(), /// <returns>An array with all directories.</returns>
x => new BdInfoFileInfo(x)); public IDirectoryInfo[] GetDirectories()
} {
return _fileSystem.GetDirectories(_impl.FullName)
.Select(x => new BdInfoDirectoryInfo(_fileSystem, x))
.ToArray();
}
public IFileInfo[] GetFiles(string searchPattern) /// <summary>
{ /// Gets the files.
return Array.ConvertAll( /// </summary>
_fileSystem.GetFiles(_impl.FullName, new[] { searchPattern }, false, false).ToArray(), /// <returns>All files of the directory.</returns>
x => new BdInfoFileInfo(x)); public IFileInfo[] GetFiles()
} {
return _fileSystem.GetFiles(_impl.FullName)
.Select(x => new BdInfoFileInfo(x))
.ToArray();
}
public IFileInfo[] GetFiles(string searchPattern, System.IO.SearchOption searchOption) /// <summary>
{ /// Gets the files matching a pattern.
return Array.ConvertAll( /// </summary>
_fileSystem.GetFiles( /// <param name="searchPattern">The search pattern.</param>
_impl.FullName, /// <returns>All files of the directory matchign the search pattern.</returns>
new[] { searchPattern }, public IFileInfo[] GetFiles(string searchPattern)
false, {
(searchOption & System.IO.SearchOption.AllDirectories) == System.IO.SearchOption.AllDirectories).ToArray(), return _fileSystem.GetFiles(_impl.FullName, new[] { searchPattern }, false, false)
x => new BdInfoFileInfo(x)); .Select(x => new BdInfoFileInfo(x))
} .ToArray();
}
public static IDirectoryInfo FromFileSystemPath(IFileSystem fs, string path) /// <summary>
{ /// Gets the files matching a pattern and search options.
return new BdInfoDirectoryInfo(fs, path); /// </summary>
} /// <param name="searchPattern">The search pattern.</param>
/// <param name="searchOption">The search optin.</param>
/// <returns>All files of the directory matchign the search pattern and options.</returns>
public IFileInfo[] GetFiles(string searchPattern, SearchOption searchOption)
{
return _fileSystem.GetFiles(
_impl.FullName,
new[] { searchPattern },
false,
(searchOption & SearchOption.AllDirectories) == SearchOption.AllDirectories)
.Select(x => new BdInfoFileInfo(x))
.ToArray();
}
/// <summary>
/// Gets the bdinfo of a file system path.
/// </summary>
/// <param name="fs">The file system.</param>
/// <param name="path">The path.</param>
/// <returns>The BD directory information of the path on the file system.</returns>
public static IDirectoryInfo FromFileSystemPath(IFileSystem fs, string path)
{
return new BdInfoDirectoryInfo(fs, path);
} }
} }

@ -6,189 +6,182 @@ using MediaBrowser.Model.Entities;
using MediaBrowser.Model.IO; using MediaBrowser.Model.IO;
using MediaBrowser.Model.MediaInfo; using MediaBrowser.Model.MediaInfo;
namespace MediaBrowser.MediaEncoding.BdInfo namespace MediaBrowser.MediaEncoding.BdInfo;
/// <summary>
/// Class BdInfoExaminer.
/// </summary>
public class BdInfoExaminer : IBlurayExaminer
{ {
private readonly IFileSystem _fileSystem;
/// <summary> /// <summary>
/// Class BdInfoExaminer. /// Initializes a new instance of the <see cref="BdInfoExaminer" /> class.
/// </summary> /// </summary>
public class BdInfoExaminer : IBlurayExaminer /// <param name="fileSystem">The filesystem.</param>
public BdInfoExaminer(IFileSystem fileSystem)
{ {
private readonly IFileSystem _fileSystem; _fileSystem = fileSystem;
}
/// <summary> /// <summary>
/// Initializes a new instance of the <see cref="BdInfoExaminer" /> class. /// Gets the disc info.
/// </summary> /// </summary>
/// <param name="fileSystem">The filesystem.</param> /// <param name="path">The path.</param>
public BdInfoExaminer(IFileSystem fileSystem) /// <returns>BlurayDiscInfo.</returns>
public BlurayDiscInfo GetDiscInfo(string path)
{
if (string.IsNullOrWhiteSpace(path))
{ {
_fileSystem = fileSystem; throw new ArgumentNullException(nameof(path));
} }
/// <summary> var bdrom = new BDROM(BdInfoDirectoryInfo.FromFileSystemPath(_fileSystem, path));
/// Gets the disc info.
/// </summary>
/// <param name="path">The path.</param>
/// <returns>BlurayDiscInfo.</returns>
public BlurayDiscInfo GetDiscInfo(string path)
{
if (string.IsNullOrWhiteSpace(path))
{
throw new ArgumentNullException(nameof(path));
}
var bdrom = new BDROM(BdInfoDirectoryInfo.FromFileSystemPath(_fileSystem, path));
bdrom.Scan(); bdrom.Scan();
// Get the longest playlist // Get the longest playlist
var playlist = bdrom.PlaylistFiles.Values.OrderByDescending(p => p.TotalLength).FirstOrDefault(p => p.IsValid); var playlist = bdrom.PlaylistFiles.Values.OrderByDescending(p => p.TotalLength).FirstOrDefault(p => p.IsValid);
var outputStream = new BlurayDiscInfo var outputStream = new BlurayDiscInfo
{ {
MediaStreams = Array.Empty<MediaStream>() MediaStreams = Array.Empty<MediaStream>()
}; };
if (playlist is null) if (playlist is null)
{ {
return outputStream; return outputStream;
} }
outputStream.Chapters = playlist.Chapters.ToArray(); outputStream.Chapters = playlist.Chapters.ToArray();
outputStream.RunTimeTicks = TimeSpan.FromSeconds(playlist.TotalLength).Ticks; outputStream.RunTimeTicks = TimeSpan.FromSeconds(playlist.TotalLength).Ticks;
var mediaStreams = new List<MediaStream>(); var sortedStreams = playlist.SortedStreams;
var mediaStreams = new List<MediaStream>(sortedStreams.Count);
foreach (var stream in playlist.SortedStreams) foreach (var stream in sortedStreams)
{
switch (stream)
{ {
if (stream is TSVideoStream videoStream) case TSVideoStream videoStream:
{
AddVideoStream(mediaStreams, videoStream); AddVideoStream(mediaStreams, videoStream);
continue; break;
} case TSAudioStream audioStream:
if (stream is TSAudioStream audioStream)
{
AddAudioStream(mediaStreams, audioStream); AddAudioStream(mediaStreams, audioStream);
continue; break;
} case TSTextStream textStream:
if (stream is TSTextStream textStream)
{
AddSubtitleStream(mediaStreams, textStream); AddSubtitleStream(mediaStreams, textStream);
continue; break;
} case TSGraphicsStream graphicStream:
AddSubtitleStream(mediaStreams, graphicStream);
if (stream is TSGraphicsStream graphicsStream) break;
{
AddSubtitleStream(mediaStreams, graphicsStream);
}
} }
}
outputStream.MediaStreams = mediaStreams.ToArray(); outputStream.MediaStreams = mediaStreams.ToArray();
outputStream.PlaylistName = playlist.Name;
if (playlist.StreamClips is not null && playlist.StreamClips.Any()) outputStream.PlaylistName = playlist.Name;
{
// Get the files in the playlist
outputStream.Files = playlist.StreamClips.Select(i => i.StreamFile.Name).ToArray();
}
return outputStream; if (playlist.StreamClips is not null && playlist.StreamClips.Count > 0)
{
// Get the files in the playlist
outputStream.Files = playlist.StreamClips.Select(i => i.StreamFile.Name).ToArray();
} }
/// <summary> return outputStream;
/// Adds the video stream. }
/// </summary>
/// <param name="streams">The streams.</param>
/// <param name="videoStream">The video stream.</param>
private void AddVideoStream(List<MediaStream> streams, TSVideoStream videoStream)
{
var mediaStream = new MediaStream
{
BitRate = Convert.ToInt32(videoStream.BitRate),
Width = videoStream.Width,
Height = videoStream.Height,
Codec = videoStream.CodecShortName,
IsInterlaced = videoStream.IsInterlaced,
Type = MediaStreamType.Video,
Index = streams.Count
};
if (videoStream.FrameRateDenominator > 0)
{
float frameRateEnumerator = videoStream.FrameRateEnumerator;
float frameRateDenominator = videoStream.FrameRateDenominator;
mediaStream.AverageFrameRate = mediaStream.RealFrameRate = frameRateEnumerator / frameRateDenominator; /// <summary>
} /// Adds the video stream.
/// </summary>
/// <param name="streams">The streams.</param>
/// <param name="videoStream">The video stream.</param>
private void AddVideoStream(List<MediaStream> streams, TSVideoStream videoStream)
{
var mediaStream = new MediaStream
{
BitRate = Convert.ToInt32(videoStream.BitRate),
Width = videoStream.Width,
Height = videoStream.Height,
Codec = videoStream.CodecShortName,
IsInterlaced = videoStream.IsInterlaced,
Type = MediaStreamType.Video,
Index = streams.Count
};
if (videoStream.FrameRateDenominator > 0)
{
float frameRateEnumerator = videoStream.FrameRateEnumerator;
float frameRateDenominator = videoStream.FrameRateDenominator;
streams.Add(mediaStream); mediaStream.AverageFrameRate = mediaStream.RealFrameRate = frameRateEnumerator / frameRateDenominator;
} }
/// <summary> streams.Add(mediaStream);
/// Adds the audio stream. }
/// </summary>
/// <param name="streams">The streams.</param>
/// <param name="audioStream">The audio stream.</param>
private void AddAudioStream(List<MediaStream> streams, TSAudioStream audioStream)
{
var stream = new MediaStream
{
Codec = audioStream.CodecShortName,
Language = audioStream.LanguageCode,
Channels = audioStream.ChannelCount,
SampleRate = audioStream.SampleRate,
Type = MediaStreamType.Audio,
Index = streams.Count
};
var bitrate = Convert.ToInt32(audioStream.BitRate);
if (bitrate > 0) /// <summary>
{ /// Adds the audio stream.
stream.BitRate = bitrate; /// </summary>
} /// <param name="streams">The streams.</param>
/// <param name="audioStream">The audio stream.</param>
private void AddAudioStream(List<MediaStream> streams, TSAudioStream audioStream)
{
var stream = new MediaStream
{
Codec = audioStream.CodecShortName,
Language = audioStream.LanguageCode,
Channels = audioStream.ChannelCount,
SampleRate = audioStream.SampleRate,
Type = MediaStreamType.Audio,
Index = streams.Count
};
if (audioStream.LFE > 0) var bitrate = Convert.ToInt32(audioStream.BitRate);
{
stream.Channels = audioStream.ChannelCount + 1;
}
streams.Add(stream); if (bitrate > 0)
{
stream.BitRate = bitrate;
} }
/// <summary> if (audioStream.LFE > 0)
/// Adds the subtitle stream.
/// </summary>
/// <param name="streams">The streams.</param>
/// <param name="textStream">The text stream.</param>
private void AddSubtitleStream(List<MediaStream> streams, TSTextStream textStream)
{ {
streams.Add(new MediaStream stream.Channels = audioStream.ChannelCount + 1;
{
Language = textStream.LanguageCode,
Codec = textStream.CodecShortName,
Type = MediaStreamType.Subtitle,
Index = streams.Count
});
} }
/// <summary> streams.Add(stream);
/// Adds the subtitle stream. }
/// </summary>
/// <param name="streams">The streams.</param> /// <summary>
/// <param name="textStream">The text stream.</param> /// Adds the subtitle stream.
private void AddSubtitleStream(List<MediaStream> streams, TSGraphicsStream textStream) /// </summary>
/// <param name="streams">The streams.</param>
/// <param name="textStream">The text stream.</param>
private void AddSubtitleStream(List<MediaStream> streams, TSTextStream textStream)
{
streams.Add(new MediaStream
{
Language = textStream.LanguageCode,
Codec = textStream.CodecShortName,
Type = MediaStreamType.Subtitle,
Index = streams.Count
});
}
/// <summary>
/// Adds the subtitle stream.
/// </summary>
/// <param name="streams">The streams.</param>
/// <param name="textStream">The text stream.</param>
private void AddSubtitleStream(List<MediaStream> streams, TSGraphicsStream textStream)
{
streams.Add(new MediaStream
{ {
streams.Add(new MediaStream Language = textStream.LanguageCode,
{ Codec = textStream.CodecShortName,
Language = textStream.LanguageCode, Type = MediaStreamType.Subtitle,
Codec = textStream.CodecShortName, Index = streams.Count
Type = MediaStreamType.Subtitle, });
Index = streams.Count
});
}
} }
} }

@ -1,41 +1,68 @@
#pragma warning disable CS1591
using System.IO; using System.IO;
using MediaBrowser.Model.IO; using MediaBrowser.Model.IO;
namespace MediaBrowser.MediaEncoding.BdInfo namespace MediaBrowser.MediaEncoding.BdInfo;
/// <summary>
/// Class BdInfoFileInfo.
/// </summary>
public class BdInfoFileInfo : BDInfo.IO.IFileInfo
{ {
public class BdInfoFileInfo : BDInfo.IO.IFileInfo private FileSystemMetadata _impl;
{
private FileSystemMetadata _impl;
public BdInfoFileInfo(FileSystemMetadata impl) /// <summary>
{ /// Initializes a new instance of the <see cref="BdInfoFileInfo" /> class.
_impl = impl; /// </summary>
} /// <param name="impl">The <see cref="FileSystemMetadata" />.</param>
public BdInfoFileInfo(FileSystemMetadata impl)
{
_impl = impl;
}
public string Name => _impl.Name; /// <summary>
/// Gets the name.
/// </summary>
public string Name => _impl.Name;
public string FullName => _impl.FullName; /// <summary>
/// Gets the full name.
/// </summary>
public string FullName => _impl.FullName;
public string Extension => _impl.Extension; /// <summary>
/// Gets the extension.
/// </summary>
public string Extension => _impl.Extension;
public long Length => _impl.Length; /// <summary>
/// Gets the length.
/// </summary>
public long Length => _impl.Length;
public bool IsDir => _impl.IsDirectory; /// <summary>
/// Gets a value indicating whether this is a directory.
/// </summary>
public bool IsDir => _impl.IsDirectory;
public Stream OpenRead() /// <summary>
{ /// Gets a file as file stream.
return new FileStream( /// </summary>
FullName, /// <returns>A <see cref="FileStream" /> for the file.</returns>
FileMode.Open, public Stream OpenRead()
FileAccess.Read, {
FileShare.Read); return new FileStream(
} FullName,
FileMode.Open,
FileAccess.Read,
FileShare.Read);
}
public StreamReader OpenText() /// <summary>
{ /// Gets a files's content with a stream reader.
return new StreamReader(OpenRead()); /// </summary>
} /// <returns>A <see cref="StreamReader" /> for the file's content.</returns>
public StreamReader OpenText()
{
return new StreamReader(OpenRead());
} }
} }

@ -871,7 +871,7 @@ namespace MediaBrowser.MediaEncoding.Encoder
} }
/// <inheritdoc /> /// <inheritdoc />
public IEnumerable<string> GetPrimaryPlaylistVobFiles(string path, uint? titleNumber) public IReadOnlyList<string> GetPrimaryPlaylistVobFiles(string path, uint? titleNumber)
{ {
// Eliminate menus and intros by omitting VIDEO_TS.VOB and all subsequent title .vob files ending with _0.VOB // Eliminate menus and intros by omitting VIDEO_TS.VOB and all subsequent title .vob files ending with _0.VOB
var allVobs = _fileSystem.GetFiles(path, true) var allVobs = _fileSystem.GetFiles(path, true)
@ -888,7 +888,7 @@ namespace MediaBrowser.MediaEncoding.Encoder
if (vobs.Count > 0) if (vobs.Count > 0)
{ {
return vobs.Select(i => i.FullName); return vobs.Select(i => i.FullName).ToList();
} }
_logger.LogWarning("Could not determine .vob files for title {Title} of {Path}.", titleNumber, path); _logger.LogWarning("Could not determine .vob files for title {Title} of {Path}.", titleNumber, path);
@ -898,12 +898,11 @@ namespace MediaBrowser.MediaEncoding.Encoder
var titles = allVobs var titles = allVobs
.Where(vob => vob.Length >= 900 * 1024 * 1024) .Where(vob => vob.Length >= 900 * 1024 * 1024)
.Select(vob => _fileSystem.GetFileNameWithoutExtension(vob).AsSpan().RightPart('_').ToString()) .Select(vob => _fileSystem.GetFileNameWithoutExtension(vob).AsSpan().RightPart('_').ToString())
.GroupBy(x => x) .Distinct()
.Select(y => y.First())
.ToList(); .ToList();
// Fall back to first title if no big title is found // Fall back to first title if no big title is found
if (titles.FirstOrDefault() == null) if (titles.Count == 0)
{ {
titles.Add(_fileSystem.GetFileNameWithoutExtension(allVobs[0]).AsSpan().RightPart('_').ToString()); titles.Add(_fileSystem.GetFileNameWithoutExtension(allVobs[0]).AsSpan().RightPart('_').ToString());
} }
@ -915,7 +914,8 @@ namespace MediaBrowser.MediaEncoding.Encoder
.ToList(); .ToList();
} }
public IEnumerable<string> GetPrimaryPlaylistM2tsFiles(string path) /// <inheritdoc />
public IReadOnlyList<string> GetPrimaryPlaylistM2tsFiles(string path)
{ {
// Get all playable .m2ts files // Get all playable .m2ts files
var validPlaybackFiles = _blurayExaminer.GetDiscInfo(path).Files; var validPlaybackFiles = _blurayExaminer.GetDiscInfo(path).Files;
@ -926,51 +926,56 @@ namespace MediaBrowser.MediaEncoding.Encoder
// Only return playable local .m2ts files // Only return playable local .m2ts files
return directoryFiles return directoryFiles
.Where(f => validPlaybackFiles.Contains(f.Name, StringComparer.OrdinalIgnoreCase)) .Where(f => validPlaybackFiles.Contains(f.Name, StringComparer.OrdinalIgnoreCase))
.Select(f => f.FullName); .Select(f => f.FullName)
.ToList();
} }
/// <inheritdoc />
public void GenerateConcatConfig(MediaSourceInfo source, string concatFilePath) public void GenerateConcatConfig(MediaSourceInfo source, string concatFilePath)
{ {
// Get all playable files // Get all playable files
var files = new List<string>(); IReadOnlyList<string> files;
var videoType = source.VideoType; var videoType = source.VideoType;
if (videoType == VideoType.Dvd) if (videoType == VideoType.Dvd)
{ {
files = GetPrimaryPlaylistVobFiles(source.Path, null).ToList(); files = GetPrimaryPlaylistVobFiles(source.Path, null);
} }
else if (videoType == VideoType.BluRay) else if (videoType == VideoType.BluRay)
{ {
files = GetPrimaryPlaylistM2tsFiles(source.Path).ToList(); files = GetPrimaryPlaylistM2tsFiles(source.Path);
}
else
{
return;
} }
// Generate concat configuration entries for each file // Generate concat configuration entries for each file and write to file
var lines = new List<string>(); using (StreamWriter sw = new StreamWriter(concatFilePath))
foreach (var path in files)
{ {
var mediaInfoResult = GetMediaInfo( foreach (var path in files)
new MediaInfoRequest {
{ var mediaInfoResult = GetMediaInfo(
MediaType = DlnaProfileType.Video, new MediaInfoRequest
MediaSource = new MediaSourceInfo
{ {
Path = path, MediaType = DlnaProfileType.Video,
Protocol = MediaProtocol.File, MediaSource = new MediaSourceInfo
VideoType = videoType {
} Path = path,
}, Protocol = MediaProtocol.File,
CancellationToken.None).GetAwaiter().GetResult(); VideoType = videoType
}
var duration = TimeSpan.FromTicks(mediaInfoResult.RunTimeTicks.Value).TotalSeconds; },
CancellationToken.None).GetAwaiter().GetResult();
// Add file path stanza to concat configuration
lines.Add("file " + "'" + path + "'"); var duration = TimeSpan.FromTicks(mediaInfoResult.RunTimeTicks.Value).TotalSeconds;
// Add duration stanza to concat configuration // Add file path stanza to concat configuration
lines.Add("duration " + duration); sw.WriteLine("file '{0}'", path);
// Add duration stanza to concat configuration
sw.WriteLine("duration {0}", duration);
}
} }
// Write concat configuration
File.WriteAllLines(concatFilePath, lines);
} }
public bool CanExtractSubtitles(string codec) public bool CanExtractSubtitles(string codec)

@ -107,11 +107,8 @@ namespace MediaBrowser.Model.Dlna
public string MediaSourceId => MediaSource?.Id; public string MediaSourceId => MediaSource?.Id;
public bool IsDirectStream => public bool IsDirectStream => MediaSource?.VideoType is not (VideoType.Dvd or VideoType.BluRay)
!(MediaSource?.VideoType == VideoType.Dvd && PlayMethod is PlayMethod.DirectStream or PlayMethod.DirectPlay;
|| MediaSource?.VideoType == VideoType.BluRay)
&& (PlayMethod == PlayMethod.DirectStream
|| PlayMethod == PlayMethod.DirectPlay);
/// <summary> /// <summary>
/// Gets the audio stream that will be used. /// Gets the audio stream that will be used.

@ -1,39 +1,41 @@
#nullable disable #nullable disable
#pragma warning disable CS1591
using MediaBrowser.Model.Entities; using MediaBrowser.Model.Entities;
namespace MediaBrowser.Model.MediaInfo namespace MediaBrowser.Model.MediaInfo;
/// <summary>
/// Represents the result of BDInfo output.
/// </summary>
public class BlurayDiscInfo
{ {
/// <summary> /// <summary>
/// Represents the result of BDInfo output. /// Gets or sets the media streams.
/// </summary> /// </summary>
public class BlurayDiscInfo /// <value>The media streams.</value>
{ public MediaStream[] MediaStreams { get; set; }
/// <summary>
/// Gets or sets the media streams.
/// </summary>
/// <value>The media streams.</value>
public MediaStream[] MediaStreams { get; set; }
/// <summary> /// <summary>
/// Gets or sets the run time ticks. /// Gets or sets the run time ticks.
/// </summary> /// </summary>
/// <value>The run time ticks.</value> /// <value>The run time ticks.</value>
public long? RunTimeTicks { get; set; } public long? RunTimeTicks { get; set; }
/// <summary> /// <summary>
/// Gets or sets the files. /// Gets or sets the files.
/// </summary> /// </summary>
/// <value>The files.</value> /// <value>The files.</value>
public string[] Files { get; set; } public string[] Files { get; set; }
public string PlaylistName { get; set; } /// <summary>
/// Gets or sets the playlist name.
/// </summary>
/// <value>The playlist name.</value>
public string PlaylistName { get; set; }
/// <summary> /// <summary>
/// Gets or sets the chapters. /// Gets or sets the chapters.
/// </summary> /// </summary>
/// <value>The chapters.</value> /// <value>The chapters.</value>
public double[] Chapters { get; set; } public double[] Chapters { get; set; }
}
} }

@ -1,15 +1,14 @@
namespace MediaBrowser.Model.MediaInfo namespace MediaBrowser.Model.MediaInfo;
/// <summary>
/// Interface IBlurayExaminer.
/// </summary>
public interface IBlurayExaminer
{ {
/// <summary> /// <summary>
/// Interface IBlurayExaminer. /// Gets the disc info.
/// </summary> /// </summary>
public interface IBlurayExaminer /// <param name="path">The path.</param>
{ /// <returns>BlurayDiscInfo.</returns>
/// <summary> BlurayDiscInfo GetDiscInfo(string path);
/// Gets the disc info.
/// </summary>
/// <param name="path">The path.</param>
/// <returns>BlurayDiscInfo.</returns>
BlurayDiscInfo GetDiscInfo(string path);
}
} }

@ -92,7 +92,7 @@ namespace MediaBrowser.Providers.MediaInfo
if (item.VideoType == VideoType.Dvd) if (item.VideoType == VideoType.Dvd)
{ {
// Get list of playable .vob files // Get list of playable .vob files
var vobs = _mediaEncoder.GetPrimaryPlaylistVobFiles(item.Path, null).ToList(); var vobs = _mediaEncoder.GetPrimaryPlaylistVobFiles(item.Path, null);
// Return if no playable .vob files are found // Return if no playable .vob files are found
if (vobs.Count == 0) if (vobs.Count == 0)
@ -105,22 +105,19 @@ namespace MediaBrowser.Providers.MediaInfo
mediaInfoResult = await GetMediaInfo( mediaInfoResult = await GetMediaInfo(
new Video new Video
{ {
Path = vobs.First() Path = vobs[0]
}, },
cancellationToken).ConfigureAwait(false); cancellationToken).ConfigureAwait(false);
// Remove first .vob file // Sum up the runtime of all .vob files skipping the first .vob
vobs.RemoveAt(0); for (var i = 1; i < vobs.Count; i++)
// Sum up the runtime of all .vob files
foreach (var vob in vobs)
{ {
var tmpMediaInfo = await GetMediaInfo( var tmpMediaInfo = await GetMediaInfo(
new Video new Video
{ {
Path = vob Path = vobs[i]
}, },
cancellationToken).ConfigureAwait(false); cancellationToken).ConfigureAwait(false);
mediaInfoResult.RunTimeTicks += tmpMediaInfo.RunTimeTicks; mediaInfoResult.RunTimeTicks += tmpMediaInfo.RunTimeTicks;
} }
@ -131,7 +128,7 @@ namespace MediaBrowser.Providers.MediaInfo
blurayDiscInfo = GetBDInfo(item.Path); blurayDiscInfo = GetBDInfo(item.Path);
// Get playable .m2ts files // Get playable .m2ts files
var m2ts = _mediaEncoder.GetPrimaryPlaylistM2tsFiles(item.Path).ToList(); var m2ts = _mediaEncoder.GetPrimaryPlaylistM2tsFiles(item.Path);
// Return if no playable .m2ts files are found // Return if no playable .m2ts files are found
if (blurayDiscInfo.Files.Length == 0 || m2ts.Count == 0) if (blurayDiscInfo.Files.Length == 0 || m2ts.Count == 0)
@ -144,14 +141,13 @@ namespace MediaBrowser.Providers.MediaInfo
mediaInfoResult = await GetMediaInfo( mediaInfoResult = await GetMediaInfo(
new Video new Video
{ {
Path = m2ts.First() Path = m2ts[0]
}, },
cancellationToken).ConfigureAwait(false); cancellationToken).ConfigureAwait(false);
} }
else else
{ {
mediaInfoResult = await GetMediaInfo(item, cancellationToken).ConfigureAwait(false); mediaInfoResult = await GetMediaInfo(item, cancellationToken).ConfigureAwait(false);
cancellationToken.ThrowIfCancellationRequested();
} }
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
@ -339,10 +335,8 @@ namespace MediaBrowser.Providers.MediaInfo
} }
} }
private void FetchBdInfo(BaseItem item, ref ChapterInfo[] chapters, List<MediaStream> mediaStreams, BlurayDiscInfo blurayInfo) private void FetchBdInfo(Video video, ref ChapterInfo[] chapters, List<MediaStream> mediaStreams, BlurayDiscInfo blurayInfo)
{ {
var video = (Video)item;
if (blurayInfo.Files.Length <= 1) if (blurayInfo.Files.Length <= 1)
{ {
return; return;

Loading…
Cancel
Save