update next up queries

Emby.Server.Implementations/TV/TVSeriesManager.cs

@@ -121,17 +121,15 @@ namespace Emby.Server.Implementations.TV
 
             var allNextUp = series
                 .Select(i => GetNextUp(i, currentUser))
-                .Where(i => i.Item1 != null)
                 // Include if an episode was found, and either the series is not unwatched or the specific series was requested
-                .OrderByDescending(i => i.Item2)
+                .OrderByDescending(i => i.Item1)
-                .ThenByDescending(i => i.Item1.PremiereDate ?? DateTime.MinValue)
                 .ToList();
 
             // If viewing all next up for all series, remove first episodes
             if (string.IsNullOrWhiteSpace(request.SeriesId))
             {
                 var withoutFirstEpisode = allNextUp
-                    .Where(i => !i.Item3)
+                    .Where(i => i.Item1 != DateTime.MinValue)
                     .ToList();
 
                 // But if that returns empty, keep those first episodes (avoid completely empty view)
@@ -142,7 +140,8 @@ namespace Emby.Server.Implementations.TV
             }
 
             return allNextUp
-                .Select(i => i.Item1)
+                .Select(i => i.Item2())
+                .Where(i => i != null)
                 .Take(request.Limit ?? int.MaxValue);
         }
 
@@ -157,7 +156,7 @@ namespace Emby.Server.Implementations.TV
         /// <param name="series">The series.</param>
         /// <param name="user">The user.</param>
         /// <returns>Task{Episode}.</returns>
-        private Tuple<Episode, DateTime, bool> GetNextUp(Series series, User user)
+        private Tuple<DateTime, Func<Episode>> GetNextUp(Series series, User user)
         {
             var lastWatchedEpisode = _libraryManager.GetItemList(new InternalItemsQuery(user)
             {
@@ -171,31 +170,34 @@ namespace Emby.Server.Implementations.TV
 
             }).FirstOrDefault();
 
-            var firstUnwatchedEpisode = _libraryManager.GetItemList(new InternalItemsQuery(user)
+            Func<Episode> getEpisode = () =>
             {
-                AncestorWithPresentationUniqueKey = GetUniqueSeriesKey(series),
+                return _libraryManager.GetItemList(new InternalItemsQuery(user)
-                IncludeItemTypes = new[] { typeof(Episode).Name },
+                {
-                SortBy = new[] { ItemSortBy.SortName },
+                    AncestorWithPresentationUniqueKey = GetUniqueSeriesKey(series),
-                SortOrder = SortOrder.Ascending,
+                    IncludeItemTypes = new[] { typeof(Episode).Name },
-                Limit = 1,
+                    SortBy = new[] { ItemSortBy.SortName },
-                IsPlayed = false,
+                    SortOrder = SortOrder.Ascending,
-                IsVirtualItem = false,
+                    Limit = 1,
-                ParentIndexNumberNotEquals = 0,
+                    IsPlayed = false,
-                MinSortName = lastWatchedEpisode == null ? null : lastWatchedEpisode.SortName
+                    IsVirtualItem = false,
-
+                    ParentIndexNumberNotEquals = 0,
-            }).Cast<Episode>().FirstOrDefault();
+                    MinSortName = lastWatchedEpisode == null ? null : lastWatchedEpisode.SortName
+
+                }).Cast<Episode>().FirstOrDefault();
+            };
 
-            if (lastWatchedEpisode != null && firstUnwatchedEpisode != null)
+            if (lastWatchedEpisode != null)
             {
                 var userData = _userDataManager.GetUserData(user, lastWatchedEpisode);
 
                 var lastWatchedDate = userData.LastPlayedDate ?? DateTime.MinValue.AddDays(1);
 
-                return new Tuple<Episode, DateTime, bool>(firstUnwatchedEpisode, lastWatchedDate, false);
+                return new Tuple<DateTime, Func<Episode>>(lastWatchedDate, getEpisode);
             }
 
             // Return the first episode
-            return new Tuple<Episode, DateTime, bool>(firstUnwatchedEpisode, DateTime.MinValue, true);
+            return new Tuple<DateTime, Func<Episode>>(DateTime.MinValue, getEpisode);
         }
 
         private QueryResult<BaseItem> GetResult(IEnumerable<BaseItem> items, int? totalRecordLimit, NextUpQuery query)