Fix some more issues with disposing Process instances

MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs

@@ -577,10 +577,10 @@ namespace MediaBrowser.MediaEncoding.Encoder
                 WindowStyle = ProcessWindowStyle.Hidden,
                 ErrorDialog = false,
             };
-            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
 
-            _logger.LogDebug("{0} {1}", process.StartInfo.FileName, process.StartInfo.Arguments);
+            _logger.LogDebug("{0} {1}", processStartInfo.FileName, processStartInfo.Arguments);
 
+            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
             using (var processWrapper = new ProcessWrapper(process, this))
             {
                 bool ranToCompletion;
@@ -706,14 +706,14 @@ namespace MediaBrowser.MediaEncoding.Encoder
                 WindowStyle = ProcessWindowStyle.Hidden,
                 ErrorDialog = false
             };
-            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
 
-            _logger.LogInformation(process.StartInfo.FileName + " " + process.StartInfo.Arguments);
+            _logger.LogInformation(processStartInfo.FileName + " " + processStartInfo.Arguments);
 
             await _thumbnailResourcePool.WaitAsync(cancellationToken).ConfigureAwait(false);
 
             bool ranToCompletion = false;
 
+            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
             using (var processWrapper = new ProcessWrapper(process, this))
             {
                 try

MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs

@@ -435,9 +435,11 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                 WindowStyle = ProcessWindowStyle.Hidden,
                 ErrorDialog = false
             };
-            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
-            process.Exited += (sender, args) => ((Process)sender).Dispose();
 
+            int exitCode;
+
+            using (var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true })
+            {
                 _logger.LogInformation("{0} {1}", process.StartInfo.FileName, process.StartInfo.Arguments);
 
                 try
@@ -467,7 +469,8 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                     }
                 }
 
-            var exitCode = ranToCompletion ? process.ExitCode : -1;
+                exitCode = ranToCompletion ? process.ExitCode : -1;
+            }
 
             var failed = false;
 
@@ -583,9 +586,11 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                 WindowStyle = ProcessWindowStyle.Hidden,
                 ErrorDialog = false
             };
-            var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true };
-            process.Exited += (sender, args) => ((Process)sender).Dispose();
 
+            int exitCode;
+
+            using (var process = new Process { StartInfo = processStartInfo, EnableRaisingEvents = true })
+            {
                 _logger.LogInformation("{File} {Arguments}", process.StartInfo.FileName, process.StartInfo.Arguments);
 
                 try
@@ -615,7 +620,8 @@ namespace MediaBrowser.MediaEncoding.Subtitles
                     }
                 }
 
-            var exitCode = ranToCompletion ? process.ExitCode : -1;
+                exitCode = ranToCompletion ? process.ExitCode : -1;
+            }
 
             var failed = false;