update thumbnail generation

MediaBrowser.Api/PluginService.cs

@@ -1,5 +1,4 @@
-using System.Threading;
-using MediaBrowser.Common;
+using MediaBrowser.Common;
 using MediaBrowser.Common.Extensions;
 using MediaBrowser.Common.Security;
 using MediaBrowser.Common.Updates;
@@ -8,12 +7,12 @@ using MediaBrowser.Model.Entities;
 using MediaBrowser.Model.Plugins;
 using MediaBrowser.Model.Serialization;
 using ServiceStack;
-using ServiceStack.Text.Controller;
 using ServiceStack.Web;
 using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 
 namespace MediaBrowser.Api

MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs

@@ -331,8 +331,8 @@ namespace MediaBrowser.MediaEncoding.Encoder
             // -f image2 -f webp
 
             // Use ffmpeg to sample 100 (we can drop this if required using thumbnail=50 for 50 frames) frames and pick the best thumbnail. Have a fall back just in case.
-            var args = useIFrame ? string.Format("-i {0} -threads 0 -v quiet -vframes 1 -vf \"{2},thumbnail=30\" -f image2 \"{1}\"", inputPath, "-", vf) :
-                string.Format("-i {0} -threads 0 -v quiet -vframes 1 -vf \"{2}\" -f image2 \"{1}\"", inputPath, "-", vf);
+            var args = useIFrame ? string.Format("-i {0} -threads 1 -v quiet -vframes 1 -vf \"{2},thumbnail=30\" -f image2 \"{1}\"", inputPath, "-", vf) :
+                string.Format("-i {0} -threads 1 -v quiet -vframes 1 -vf \"{2}\" -f image2 \"{1}\"", inputPath, "-", vf);
 
             var probeSize = GetProbeSizeArgument(new[] { inputPath }, protocol);
 
@@ -479,7 +479,7 @@ namespace MediaBrowser.MediaEncoding.Encoder
             Directory.CreateDirectory(targetDirectory);
             var outputPath = Path.Combine(targetDirectory, filenamePrefix + "%05d.jpg");
 
-            var args = string.Format("-i {0} -threads 0 -v quiet -vf \"{2}\" -f image2 \"{1}\"", inputArgument, outputPath, vf);
+            var args = string.Format("-i {0} -threads 1 -v quiet -vf \"{2}\" -f image2 \"{1}\"", inputArgument, outputPath, vf);
 
             var probeSize = GetProbeSizeArgument(new[] { inputArgument }, protocol);
 
@@ -506,6 +506,10 @@ namespace MediaBrowser.MediaEncoding.Encoder
 
             await resourcePool.WaitAsync(cancellationToken).ConfigureAwait(false);
 
+            bool ranToCompletion;
+
+            try
+            {
                 process.Start();
 
                 // Need to give ffmpeg enough time to make all the thumbnails, which could be a while,
@@ -515,14 +519,18 @@ namespace MediaBrowser.MediaEncoding.Encoder
                 bool isResponsive = true;
                 int lastCount = 0;
 
-            while (isResponsive && !process.WaitForExit(120000))
+                while (isResponsive && !process.WaitForExit(30000))
                 {
-                int jpegCount = Directory.GetFiles(targetDirectory, "*.jpg").Count();
+                    cancellationToken.ThrowIfCancellationRequested();
+
+                    int jpegCount = Directory.GetFiles(targetDirectory)
+                        .Count(i => string.Equals(Path.GetExtension(i), ".jpg", StringComparison.OrdinalIgnoreCase));
+
                     isResponsive = (jpegCount > lastCount);
                     lastCount = jpegCount;
                 }
 
-            bool ranToCompletion = process.HasExited;
+                ranToCompletion = process.HasExited;
 
                 if (!ranToCompletion)
                 {
@@ -539,8 +547,11 @@ namespace MediaBrowser.MediaEncoding.Encoder
                         _logger.ErrorException("Error killing process", ex);
                     }
                 }
-
+            }
+            finally
+            {
                 resourcePool.Release();
+            }
 
             var exitCode = ranToCompletion ? process.ExitCode : -1;