Add try-catch to avoid crashing the whole thing

pull/4263/head
cvium 4 years ago
parent 1b18f86c8b
commit 4a81ee43dc

@ -8,6 +8,7 @@ using Jellyfin.Data.Events;
using MediaBrowser.Controller.Entities; using MediaBrowser.Controller.Entities;
using MediaBrowser.Controller.Library; using MediaBrowser.Controller.Library;
using MediaBrowser.Controller.Providers; using MediaBrowser.Controller.Providers;
using MediaBrowser.Model.Net;
using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging;
namespace Emby.Server.Implementations.Library namespace Emby.Server.Implementations.Library
@ -63,11 +64,20 @@ namespace Emby.Server.Implementations.Library
continue; continue;
} }
var itemId = queuedItem.item.Id.ToString("N", CultureInfo.InvariantCulture);
var itemType = queuedItem.item.GetType();
_logger.LogDebug( _logger.LogDebug(
"Updating remote images for item {ItemId} with media type {ItemMediaType}", "Updating remote images for item {ItemId} with media type {ItemMediaType}",
queuedItem.item.Id.ToString("N", CultureInfo.InvariantCulture), itemId,
queuedItem.item.GetType()); itemType);
try
{
await _libraryManager.UpdateImagesAsync(queuedItem.item, queuedItem.updateReason >= ItemUpdateType.ImageUpdate).ConfigureAwait(false); await _libraryManager.UpdateImagesAsync(queuedItem.item, queuedItem.updateReason >= ItemUpdateType.ImageUpdate).ConfigureAwait(false);
}
catch (HttpException ex)
{
_logger.LogError(ex, "Failed to fetch images for {Type} item with id {ItemId}", itemType, itemId);
}
_queuedItems.TryRemove(queuedItem.item.Id, out _); _queuedItems.TryRemove(queuedItem.item.Id, out _);
} }

Loading…
Cancel
Save