improve error handling when a single repository has issues

Co-authored-by: Cody Robibero <cody@robibe.ro>
pull/3244/head
dkanada 5 years ago committed by GitHub
parent 8ac2f1bb8b
commit 7161a30af7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -139,14 +139,19 @@ namespace Emby.Server.Implementations.Updates
catch (SerializationException ex) catch (SerializationException ex)
{ {
_logger.LogError(ex, "Failed to deserialize the plugin manifest retrieved from {Manifest}", manifest); _logger.LogError(ex, "Failed to deserialize the plugin manifest retrieved from {Manifest}", manifest);
throw; return Enumerable.Empty<PackageInfo>();
} }
} }
} }
catch (UriFormatException ex) catch (UriFormatException ex)
{ {
_logger.LogError(ex, "The URL configured for the plugin repository manifest URL is not valid: {Manifest}", manifest); _logger.LogError(ex, "The URL configured for the plugin repository manifest URL is not valid: {Manifest}", manifest);
throw; return Enumerable.Empty<PackageInfo>();
}
catch (HttpException ex)
{
_logger.LogError(ex, "An error occurred while accessing the plugin manifest: {Manifest}", manifest);
return Enumerable.Empty<PackageInfo>();
} }
} }
@ -159,7 +164,7 @@ namespace Emby.Server.Implementations.Updates
result.AddRange(await GetPackages(repository.Url, cancellationToken).ConfigureAwait(true)); result.AddRange(await GetPackages(repository.Url, cancellationToken).ConfigureAwait(true));
} }
return result.ToList().AsReadOnly(); return result.AsReadOnly();
} }
/// <inheritdoc /> /// <inheritdoc />

Loading…
Cancel
Save