Hook new registration load to changing supporter keys

MediaBrowser.Common.Implementations/Security/PluginSecurityManager.cs

@@ -73,9 +73,9 @@ namespace MediaBrowser.Common.Implementations.Security
         {
             var tasks = new List<Task>();
 
+            ResetSupporterInfo();
             tasks.AddRange(_registeredEntities.Select(i => i.LoadRegistrationInfoAsync()));
             await Task.WhenAll(tasks);
-            ResetSupporterInfo();
         }
 
         /// <summary>
@@ -101,11 +101,8 @@ namespace MediaBrowser.Common.Implementations.Security
                 if (value != MBRegistration.SupporterKey)
                 {
                     MBRegistration.SupporterKey = value;
-                    // Clear this so it will re-evaluate
+                    // re-load registration info
-                    ResetSupporterInfo();
+                    Task.Run(() => LoadAllRegistrationInfo());
-                    // And we'll need to restart to re-evaluate the status of plug-ins
-                    _appHost.NotifyPendingRestart();
-
                 }
             }
         }
@@ -119,9 +116,12 @@ namespace MediaBrowser.Common.Implementations.Security
             get { return MBRegistration.LegacyKey; }
             set
             {
-                MBRegistration.LegacyKey = value;
+                if (value != MBRegistration.LegacyKey)
-                // And we'll need to restart to re-evaluate the status of plug-ins
+                {
-                _appHost.NotifyPendingRestart();
+                    MBRegistration.LegacyKey = value;
+                    // re-load registration info
+                    Task.Run(() => LoadAllRegistrationInfo());
+                }
             }
         }
 

MediaBrowser.Common/Security/IRequiresRegistration.cs

@@ -4,6 +4,12 @@ namespace MediaBrowser.Common.Security
 {
     public interface IRequiresRegistration
     {
+        /// <summary>
+        /// Load all registration information required for this entity.
+        /// Your class should re-load all MBRegistrationRecords when this is called even if they were
+        /// previously loaded.
+        /// </summary>
+        /// <returns></returns>
         Task LoadRegistrationInfoAsync();
     }
 }