Apply review suggestions

pull/8147/head
Shadowghost 2 years ago
parent 3f6354cdb8
commit b725fbe51a

@ -288,7 +288,7 @@ namespace Emby.Dlna.Main
var bindAddresses = _networkManager var bindAddresses = _networkManager
.GetInternalBindAddresses() .GetInternalBindAddresses()
.Where(i => i.Address.AddressFamily == AddressFamily.InterNetwork .Where(i => i.Address.AddressFamily == AddressFamily.InterNetwork
|| (i.AddressFamily == AddressFamily.InterNetworkV6 && i.Address.ScopeId != 0)) || (i.AddressFamily == AddressFamily.InterNetworkV6 && i.Address.ScopeId != 0))
.ToList(); .ToList();
if (bindAddresses.Count == 0) if (bindAddresses.Count == 0)

@ -1094,8 +1094,8 @@ namespace Emby.Server.Implementations
{ {
int? requestPort = request.Host.Port; int? requestPort = request.Host.Port;
if (requestPort == null if (requestPort == null
|| (requestPort == 80 && string.Equals(request.Scheme, "http", StringComparison.OrdinalIgnoreCase)) || (requestPort == 80 && string.Equals(request.Scheme, "http", StringComparison.OrdinalIgnoreCase))
|| (requestPort == 443 && string.Equals(request.Scheme, "https", StringComparison.OrdinalIgnoreCase))) || (requestPort == 443 && string.Equals(request.Scheme, "https", StringComparison.OrdinalIgnoreCase)))
{ {
requestPort = -1; requestPort = -1;
} }

@ -61,7 +61,7 @@ namespace Emby.Server.Implementations.Net
} }
/// <inheritdoc /> /// <inheritdoc />
public ISocket CreateUdpMulticastSocket(IPAddress ipAddress, IPAddress bindIpAddress, int multicastTimeToLive, int localPort) public ISocket CreateUdpMulticastSocket(IPAddress ipAddress, IPAddress? bindIpAddress, int multicastTimeToLive, int localPort)
{ {
ArgumentNullException.ThrowIfNull(ipAddress); ArgumentNullException.ThrowIfNull(ipAddress);

@ -22,7 +22,7 @@ namespace Jellyfin.Server.Tests
true, true,
true, true,
new string[] { "192.168.t", "127.0.0.1", "::1", "1234.1232.12.1234" }, new string[] { "192.168.t", "127.0.0.1", "::1", "1234.1232.12.1234" },
new IPAddress[] { IPAddress.Loopback, }, new IPAddress[] { IPAddress.Loopback },
new IPNetwork[] { new IPNetwork(IPAddress.IPv6Loopback, 128) }); new IPNetwork[] { new IPNetwork(IPAddress.IPv6Loopback, 128) });
data.Add( data.Add(

Loading…
Cancel
Save