Address comments

pull/2917/head
Bond_009 5 years ago
parent a8b59c5d21
commit e21d6160c1

@ -11,9 +11,9 @@ namespace Jellyfin.Model.Tests.Extensions
[InlineData("banana", "Banana")] [InlineData("banana", "Banana")]
[InlineData("Banana", "Banana")] [InlineData("Banana", "Banana")]
[InlineData("ä", "Ä")] [InlineData("ä", "Ä")]
public void StringHelper_ValidArgs_Success(string str, string result) public void StringHelper_ValidArgs_Success(string input, string expectedResult)
{ {
Assert.Equal(result, StringHelper.FirstToUpper(str)); Assert.Equal(expectedResult, StringHelper.FirstToUpper(input));
} }
} }
} }

@ -17,7 +17,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
[InlineData("The Skin I Live In (2011).eng.foreign.srt", "eng", false, true)] [InlineData("The Skin I Live In (2011).eng.foreign.srt", "eng", false, true)]
[InlineData("The Skin I Live In (2011).eng.default.foreign.srt", "eng", true, true)] [InlineData("The Skin I Live In (2011).eng.default.foreign.srt", "eng", true, true)]
[InlineData("The Skin I Live In (2011).default.foreign.eng.srt", "eng", true, true)] [InlineData("The Skin I Live In (2011).default.foreign.eng.srt", "eng", true, true)]
public void SubtitleParser_ValidFileNames_Parses(string input, string language, bool isDefault, bool isForced) public void SubtitleParser_ValidFileName_Parses(string input, string language, bool isDefault, bool isForced)
{ {
var parser = new SubtitleParser(_namingOptions); var parser = new SubtitleParser(_namingOptions);
@ -30,7 +30,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
[Theory] [Theory]
[InlineData("The Skin I Live In (2011).mp4")] [InlineData("The Skin I Live In (2011).mp4")]
public void SubtitleParser_InvalidFileNames_ReturnsNull(string input) public void SubtitleParser_InvalidFileName_ReturnsNull(string input)
{ {
var parser = new SubtitleParser(_namingOptions); var parser = new SubtitleParser(_namingOptions);
@ -38,7 +38,7 @@ namespace Jellyfin.Naming.Tests.Subtitles
} }
[Fact] [Fact]
public void SubtitleParser_EmptyFileNames_ThrowsArgumentException() public void SubtitleParser_EmptyFileName_ThrowsArgumentException()
{ {
Assert.Throws<ArgumentException>(() => new SubtitleParser(_namingOptions).ParseFile(string.Empty)); Assert.Throws<ArgumentException>(() => new SubtitleParser(_namingOptions).ParseFile(string.Empty));
} }

Loading…
Cancel
Save