719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull
2 years ago
0b8faf5db4
Fix minor warnings in Emby.Server.Implementations ( #2149 )
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
2d57e71b44
Don't allow throwing System.Exception ( #8378 )
2 years ago
e263e9c2b1
Merge pull request #7544 from jaantaponen/long-filename-fix
...
(cherry picked from commit 8a1eca0913
3 years ago
1425ef3cb4
Merge pull request #7542 from 1337joe/make-recording-stop
...
Make recording stop at scheduled stop time
(cherry picked from commit 132c85e554
3 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
5732e6188c
Fix some warnings
3 years ago
b6489e73ab
Merge pull request #7241 from Bond-009/async5
3 years ago
e7be01d7a5
Flush to disk async where possible
3 years ago
832da133d8
Always create TaskCompletionSource<T> with TaskCreationOptions.RunContinuationsAsynchronously
3 years ago
ea8f40e84a
More cleanup
3 years ago
b880dc8a4a
Use our own Contains extension
3 years ago
32629cd7da
Use BaseItemKind where possible
3 years ago
474b035d99
Fix some warnings
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
c3523e7cf7
Merge pull request #5905 from BaronGreenback/TVFix
...
Fix for Livetv and DLNA when bind interfaces specified.
3 years ago
5726535a26
Fix some warnings
...
609 left
3 years ago
f03e77a4d5
Merge branch 'master' into TVFix
3 years ago
1156699481
Merge pull request #6657 from Bond-009/dotnetbug
3 years ago
232e48f5e8
Fix warnings in EmbyTV
3 years ago
9af16fcb6c
Remove workaround for dotnet/runtime#42790
3 years ago
1ee58bf020
Enable nullable for ItemDataProvider
3 years ago
f31224fa8f
Remove sync FileStream hack
3 years ago
f6622bd810
Fix issue #6587
3 years ago
653df7d8e5
Specify DateTimeStyles when possible
3 years ago
1a5a74d2a9
Remove more unused args
3 years ago
1603d1928e
Kill ProgressiveFileCopier and seek to end for ongoing livetv
3 years ago
153e920239
Ignore published server url for local access
3 years ago
74fef6c05b
Merge pull request #6177 from Bond-009/async
...
Use async FileStreams where it makes sense
3 years ago
ffe5ae8056
Merge branch 'master' into TVFix
3 years ago
637e86478f
Fix some warnings
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
645825db36
Enable nullable for more files
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
0bc0601442
Fix some warnings
3 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
a9f44c21eb
Add tests for Recordinghelper
4 years ago
ddb04dc12b
Use new ReadAllLines extensions
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
7ff52bf755
Renamed
4 years ago
7936ea59eb
Changed selection method
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
bc1cc2d04a
Remove unused using directives
4 years ago
aa76957338
Remove useless code
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
ece0d67f99
Use FileShare.Read for log files
4 years ago
60ffa6f514
Use FileShare.None when creating files
4 years ago
1c74e2f40e
Fix build
4 years ago
1ea2b200c0
JsonSerializer deserialize from bytes where possible
...
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
| Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 | - | - | 52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 | - | - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 | - | - | 31.27 KB |
```
4 years ago
Claus Vium
Jan Sommer
Bond_009
Cody Robibero
cvium
Patrick Barron
BaronGreenback
David