3c8f7d380f
Improve performance
...
Signed-off-by: Petrus.Z <silencly07@gmail.com>
3 years ago
0a0ddb0eaf
Add AutoCollection option
...
it can determine whether auto create/add movies to collection
Signed-off-by: Petrus.Z <silencly07@gmail.com>
3 years ago
b50c3852ef
Remove unused dependencies
3 years ago
1924d0740d
Fix style and performance issues mentioned in review
...
Signed-off-by: Petrus.Z <silencly07@gmail.com>
3 years ago
74459ec403
Fix issues mentioned in review
...
Signed-off-by: Petrus.Z <silencly07@gmail.com>
3 years ago
5eb1fde88c
Add Collection Validator, create collection based on nfo
...
Based on nfo's set element, automatically add movie to collection.
Signed-off-by: Petrus.Z <silencly07@gmail.com>
3 years ago
4f45c52674
Remove ILibraryManager as a dependency in resolvers etc.
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
5726535a26
Fix some warnings
...
609 left
3 years ago
4dfb7b18ae
Add some docs and tests
3 years ago
2c42d75288
Merge pull request #6027 from fredriklindberg/improve-series-matching
3 years ago
2d4066748d
Merge pull request #6446 from Deathspike/master
3 years ago
2410b3a3cf
Resolve subtitle selection feedback ( #6446 )
3 years ago
b830d38a34
Rework subtitle selection to reduce code clutter
3 years ago
2b004e1f76
Add more sorting to Latest
3 years ago
03f933aaa0
Fix the last few warnings
...
Enables TreatWarningsAsErrors for all projects
3 years ago
e0db541381
Update indentation
3 years ago
876a902356
Fix warnings in Library
3 years ago
79642af3b8
Fix some warnings
3 years ago
4d1d9f23d5
Use new Enum.TryParse(ReadOnlySpan<char>) overload
3 years ago
32ea4806f8
Merge pull request #6538 from cvium/livetv_oh_no
3 years ago
dc8420c7a2
Fix extra folder type resolving.
3 years ago
ea439c5ccf
Improve series name matching
...
Add a series path resolver that attempts to extract only the series
name from a path that contains more information that just the name.
3 years ago
ff328fefc5
Replace GetDirectStreamProviderByUniqueId with GetLiveStreamInfoByUniqueId
3 years ago
026a7af0e8
Don't throw when livestream file isn't found
3 years ago
f3573b061c
Remove the unused arg
3 years ago
1603d1928e
Kill ProgressiveFileCopier and seek to end for ongoing livetv
3 years ago
c794e48562
Merge pull request #6522 from ferferga/efcore-improvements
3 years ago
71ab4a5754
Fix it for real(tm) this time
3 years ago
8dc0911374
Fix log message
3 years ago
3d0b1ccae6
Remove all unused usings
3 years ago
74fef6c05b
Merge pull request #6177 from Bond-009/async
...
Use async FileStreams where it makes sense
3 years ago
637e86478f
Fix some warnings
3 years ago
611c20dba8
Fix indentation
3 years ago
ec13412155
Merge remote-tracking branch 'upstream/master' into warn-259810
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
4cd372109d
Merge pull request #6473 from Bond-009/nullable7
...
Enable nullable for more files
3 years ago
442e756395
Merge pull request #6183 from stanionascu/bdiso-playback
3 years ago
ecb4b8e0aa
Apply suggestions from code review
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
645825db36
Enable nullable for more files
3 years ago
95988ce33d
Fix embedded subtitles taking priority over external ones
3 years ago
915141f196
Fix some warnings
3 years ago
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
351ae66509
Better detection of the ISO DVD/BD types
...
The ISO image will be opened and checked for disc-type specific
folders.
Can be overridden using NAME.dvd.iso / NAME.bluray.iso
3 years ago
cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram
3 years ago
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
9f2e8063ec
Merge pull request #5997 from JKI12/master
...
Fixes for Book Progress
4 years ago
42a2cc1747
Remove some unnecessary allocations
4 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
1b49435a0e
Reduce some allocations
4 years ago
bc017737e6
Changed condition for readbility
...
- Refactored check if item is not audio book or book to be more readable
4 years ago
4367b97a54
Fix build
4 years ago
3cd57cb287
Fixes for Book Progress
...
- Ignore Books when checking for minium progress
4 years ago
95b1cf532b
Merge pull request #5985 from Bond-009/minor11
4 years ago
47e7c1356c
PathExtensions: Fix index out of bounds in TryReplaceSubPath
...
Fixes #5977
4 years ago
bcb4010db6
More improvements
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
f2c10471bf
Code Clean up: Use Pattern Matching ( #5838 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
48e81e65e8
Merge pull request #5938 from cvium/allocationz
4 years ago
cd543f7e50
Merge pull request #5738 from cvium/resolve-from-path
...
Resolve name from episode folder
4 years ago
b9d18f0fa7
Merge branch 'master' into allocationz
4 years ago
c608d5104d
Fix scanning
4 years ago
360d80c873
Merge pull request #5890 from Bond-009/filesystem
...
Reduce string allocations/fs lookups in resolve code
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
7195d3e42f
Merge pull request #5893 from Bond-009/db
...
SqliteItemRepository: remove redundant operations
4 years ago
77261a8445
add UpdatePeopleAsync and add people to both tables
4 years ago
a02e37daa0
SqliteItemRepository: remove redundant operations
...
removed:
* nameof -> FullName lookup
* IndexOf before Replace
* Enum.GetNames -> Enum.Parse roundtrip
4 years ago
b323044139
Reduce string allocations/fs lookups in resolve code
4 years ago
005ae80b31
Update var names
4 years ago
dcd96909cd
Fix Audiobook Resume
...
https://github.com/jellyfin/jellyfin/issues/5703
4 years ago
8933389753
Respect user settings for transcode and remux
4 years ago
e841922ffd
Fix ArgumentOutOfRangeException scanning AudioBooks
...
AudioResolver.ResolveMultipleAudio method can attempt to access the first item in a List without checking if the list is empty which throws an ArgumentOutOfRangeException and stops the 'Scan Library' process.
4 years ago
bc1cc2d04a
Remove unused using directives
4 years ago
8045a488ce
Fix possible ArgumentNullException
...
```
Error Message:
System.ArgumentNullException : Value cannot be null. (Parameter 'source')
Stack Trace:
at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Linq.Enumerable.Select[TSource,TResult](IEnumerable`1 source, Func`2 selector)
at Emby.Server.Implementations.Library.LibraryManager.ResolveItem(ItemResolveArgs args, IItemResolver[] resolvers) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 475
at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, IDirectoryService directoryService, IItemResolver[] resolvers, Folder parent, String collectionType, LibraryOptions libraryOptions) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 618
at Emby.Server.Implementations.Library.LibraryManager.ResolvePath(FileSystemMetadata fileInfo, Folder parent) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 536
at Emby.Server.Implementations.Library.LibraryManager.GetUserRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 812
at Emby.Server.Implementations.Library.LibraryManager.GetCollectionFolders(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2080
at Emby.Server.Implementations.Library.LibraryManager.GetLibraryOptions(BaseItem item) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2116
at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType, IEnumerable`1 savers) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 672
at MediaBrowser.Providers.Manager.ProviderManager.SaveMetadata(BaseItem item, ItemUpdateType updateType) in /home/vsts/work/1/s/MediaBrowser.Providers/Manager/ProviderManager.cs:line 655
at Emby.Server.Implementations.Library.LibraryManager.RunMetadataSavers(BaseItem item, ItemUpdateType updateReason) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 2017
at Emby.Server.Implementations.Library.LibraryManager.UpdateItemsAsync(IReadOnlyList`1 items, BaseItem parent, ItemUpdateType updateReason, CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 1975
at Emby.Server.Implementations.Library.LibraryManager.CreateRootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 775
at Emby.Server.Implementations.Library.LibraryManager.get_RootFolder() in /home/vsts/work/1/s/Emby.Server.Implementations/Library/LibraryManager.cs:line 180
at Emby.Server.Implementations.IO.LibraryMonitor.Start() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitor.cs:line 135
at Emby.Server.Implementations.IO.LibraryMonitorStartup.RunAsync() in /home/vsts/work/1/s/Emby.Server.Implementations/IO/LibraryMonitorStartup.cs:line 26
at Emby.Server.Implementations.ApplicationHost.StartEntryPoints(IEnumerable`1 entryPoints, Boolean isBeforeStartup)+MoveNext() in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 518
at System.Threading.Tasks.Task.WhenAll(IEnumerable`1 tasks)
at Emby.Server.Implementations.ApplicationHost.RunStartupTasksAsync(CancellationToken cancellationToken) in /home/vsts/work/1/s/Emby.Server.Implementations/ApplicationHost.cs:line 502
at Jellyfin.Server.Integration.Tests.JellyfinApplicationFactory.CreateServer(IWebHostBuilder builder) in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/JellyfinApplicationFactory.cs:line 101
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient()
at Jellyfin.Server.Integration.Tests.Controllers.ActivityLogControllerTests.ActivityLog_GetEntries_Ok() in /home/vsts/work/1/s/tests/Jellyfin.Server.Integration.Tests/Controllers/ActivityLogControllerTests.cs:line 21
--- End of stack trace from previous location ---
```
4 years ago
cd0daa7985
Merge pull request #5748 from cvium/playlist-audio-type
...
Set mediatype to Audio for playlists in a music library
4 years ago
ef527df28f
Set mediatype to Audio for playlists in a music library
4 years ago
f2cba352e5
catch ioexception and include stack trace
4 years ago
5c4be2416d
Remove unused import
4 years ago
53db1a1ffc
...
4 years ago
457229c56d
Simplification
4 years ago
69d2368fbc
Copy paste error
4 years ago
e7fc18d0f3
Fix type check
4 years ago
08ccf2a49c
Resolve name from episode folder
4 years ago
a21b2714e7
fetching images should not kill the scanner
4 years ago
a0258618ac
Update Emby.Server.Implementations/Library/Resolvers/TV/SeriesResolver.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
aa76957338
Remove useless code
4 years ago
b49d50e634
Merge pull request #5467 from Ullmie02/nfo-fixes
4 years ago
78f7fdeacc
Rename methods and optimize allocations
4 years ago
066c19a26b
Fix possible null ref exception
4 years ago
14cbd22fbe
Use Helper Methods for provider url parsing
4 years ago
025e351f61
add unit tests
4 years ago
ab0cff8556
do not resolve episode-like files if they are in extras folders
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
5241bd41ef
Add code analysis attributes where appropriate
4 years ago
82d88bdec6
Merge pull request #5409 from ikomhoog/master
4 years ago
90cdd1345d
Merge pull request #5407 from Bond-009/hack
4 years ago
54f81c4da4
Call ToLower on CollectionTypeOptions.ToString
4 years ago
d4201f812c
Changed string.Length == 0 to string.IsNullOrEmpty in case of null
4 years ago
946411be8e
Remove redundant check
4 years ago
67af30d1ff
Remove redundant checks
4 years ago
54211b921c
rider is a prick
4 years ago
bc661c16e1
simplify
4 years ago
37e374d33d
make sure network path substitution matches correctly
4 years ago
81f527f808
CollectionType can be null
4 years ago
1c74e2f40e
Fix build
4 years ago
914e891689
Fix unchecked input
4 years ago
9fcdbd4c4b
remove deprecated settings from server config
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
4549c96f6d
Merge pull request #4906 from Spacetech/library_scan_ignore_inaccessible
...
Ignore inaccessible files & folders during library scans
4 years ago
0f4bbbc63c
Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolver
4 years ago
1fdeac0a7d
Ignore inaccessible files during library scans
4 years ago
7caba04c3c
Merge pull request #4890 from nielsvanvelzen/4888-fix-search-hints
...
Fix search hint endpoint error
4 years ago
f411353c8c
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
c7cb177260
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
77b478c726
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
99adbf0497
Split resume function for Audiobooks
4 years ago
2bb84c0675
Fix limit parameter error for search hints endpoint
4 years ago
043d045448
Put json serializer options in private field
4 years ago
a714008b59
Add missing FileStreams
4 years ago
2a574914ea
Use streams instead of strings
4 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
21d2e9ff0c
Merge pull request #4771 from crobibero/typed-get-preference
...
Use typed UserManager GetPreference
4 years ago
ee23d06154
Use a more descriptive function name
4 years ago
297cb27ab6
remove opf extension for book types
4 years ago
b670937c3d
Use typed UserManager GetPreference
4 years ago
3f6e6c4839
Simplify
4 years ago
3c5bbeb80c
Remove ImageFetcherPostScanTask
4 years ago
020fe37dfe
fix custom library order
4 years ago
b5a7a74e89
Use GetParentItem where applicable
4 years ago
2055d49701
fix inverted condition
4 years ago
c083b29e29
Use Guid as API parameter type where possible
4 years ago
969b9e2a18
Update ImageFetcherPostScanTask.cs
4 years ago
bf54b5579c
Merge branch 'master' into defer_image_fetching
4 years ago
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
4 years ago
e51ddd326c
Fixes spelling.
4 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
2bbfcc264d
Merge branch 'master' into emby-namig-nullable
4 years ago
e66d79fc0c
Merge remote-tracking branch 'upstream/master' into http-exception
4 years ago
95a2de757f
remove custom HttpException
4 years ago
ff49a3bb61
Missed some stuff
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
c0747512d6
Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable
4 years ago
584b4fa41f
Fix Persons, Genres and Studios endpoints
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
60b49e67ea
Re-Sharper inspection issues
4 years ago
59619b6ea7
Enable nullable in Emby.Naming
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
d54de29485
Merge pull request #4315 from Jan-PieterBaert/fix-warnings
...
Fix some warnings
4 years ago
8b419d9ea6
Merge pull request #4199 from ryanpetris/livetv-locking
...
Fix stream performance when opening/closing new streams.
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
4a81ee43dc
Add try-catch to avoid crashing the whole thing
4 years ago
1b18f86c8b
Add missing parameter comments.
4 years ago
5d3449e9dc
Fix xml doc comment
4 years ago
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
4 years ago
3cfbe6e340
better audio file check
4 years ago
75041e7f39
interlocked increment
4 years ago
05fa95f149
Increase scan speed for music libraries
4 years ago
4db5700e18
Don't take a lock if there's no intention to manipulate the list of open streams. Instead, use a ConcurrentDictionary so that, in those situations, thread-safe access to the dictionary is ensured.
4 years ago
edbd4e0db6
Remove extra return statement
4 years ago
441301069e
Fix
4 years ago
48e1cf9fd7
Minor performance improvements to item saving
4 years ago
119f64f5e7
Make some methods async
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
0cf75992a8
Use MemoryCache.Set since SetValue does not flush to cache automatically.
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
e0d2eb8eec
remove useless order step for intros
4 years ago
e5c6eec642
Use MemoryCache in LibraryManager
4 years ago
d7287a05ad
Merge pull request #3684 from Bond-009/warn22
...
Fix warnings
4 years ago
9314a4fcc9
.
4 years ago
7fa80ac3e0
Add more tests, update comment
4 years ago
de708d2fca
Comment
4 years ago
800260af43
Yep. I failed at copy-pasting.
4 years ago
11d5410dbb
Don't ignore dot directories.
...
Use `.ignore` file to hide directory from library scan.
Also, please tell me we handle sample matching somewhere else? This is a mess.
4 years ago
01e781035f
Fix warnings
4 years ago
3ff110984a
Merge branch 'master' into readonlyspan
4 years ago
0aa349fe40
Remove unused dependencies.
4 years ago
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
0d446c8755
Merge pull request #3609 from Bond-009/warn21
...
Fix warnings
4 years ago
e973757485
Simplify logic
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
2fa2952791
Skip image processing for live tv sources
4 years ago
7324b44c43
Fix warnings
4 years ago
b53bf2cd16
Remove obsolete network path code
4 years ago
e152a6c82f
Increase delete logging
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
cb193b6afd
Add support for ReadOnlySpan<char> in IgnorePatterns
4 years ago
9772749d8f
Add more ignorepatterns and tests
4 years ago
bb7444db07
Merge pull request #3439 from cvium/ignore_application_folders
...
Never ignore application folders
4 years ago
9eba11379a
catch skia errors when getting image dimensions
4 years ago
0f07b19ca5
Remove AllowIgnorePath
4 years ago
9dee1eef83
Never ignore application folders
4 years ago
f75024fade
Fix scan crashed
4 years ago
7f307f9082
brace multiline if statements
4 years ago
8de6452967
fix some documentation periods
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
3d9049ef08
fix SA1508
4 years ago
Petrus.Z
cvium
Bond_009
Claus Vium
Deathspike
Roel van Uden
Dmitry Lyzo
Patrick Barron
Patrick Barron
Dixin
Fredrik Lindberg
Fernando Fernández
Cody Robibero
Stanislav Ionascu
Jake King
BaronGreenback
Bill Thornton
artiume
Stephen Moore
Joshua M. Boniface
David
Ikomhoog
dkanada
Ian
Gary Wilber
Niels van Velzen
nyanmisaka
Stepan
Anthony Lavado
Jan-Pieter Baert
Ryan Petris
Odd Stråbø
Bill Thornton
telans