Bond_009
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2 years ago
Bond_009
52194f56b5
Replace != null with is not null
2 years ago
Bond_009
c7d50d640e
Replace == null with is null
2 years ago
Dmitry Lyzo
2eb00bf3c0
fix secondary audio
...
Browsers (Chrome, Firefox) can only play the first track,
even if the second track is the default.
Ignore default flag when testing on secondary audio.
External audio tracks are not secondary.
2 years ago
Maxr1998
bf059d5b58
Backport pull request #8411 from jellyfin/release-10.8.z
...
Allow direct play even if no audio stream is available
Original-merge: bf129ab9b8
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2 years ago
Claus Vium
719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull
2 years ago
Jan Sommer
87d460909f
Fix minor warnings in MediaBrowser.Model/Configuration ( #2149 )
2 years ago
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
Hannes Braun
4edeccc5e0
Remove redundant using directives
2 years ago
luz paz
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2 years ago
Cody Robibero
38102499cb
Merge pull request #7947 from nyanmisaka/video-range-condition
...
(cherry picked from commit f1d56aa5ce
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2 years ago
Joshua M. Boniface
47d150565d
Merge pull request #7712 from jellyfin/fix-hevc-disable-option
...
(cherry picked from commit 5a9e5e0d5d
)
Signed-off-by: crobibero <cody@robibe.ro>
3 years ago
Joshua M. Boniface
2d8f7b46f1
Merge pull request #7699 from Shadowghost/streambuilder-fix
...
(cherry picked from commit b46d61dfdf
)
Signed-off-by: crobibero <cody@robibe.ro>
3 years ago
Cody Robibero
688553b9a8
Merge pull request #7537 from dmitrylyzo/fix-streambuilder
...
(cherry picked from commit 5833c70725
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
3 years ago
Cody Robibero
1960b5bdce
Merge pull request #7523 from crobibero/null-stream
...
Allow media without streams to playback
(cherry picked from commit 577325b788
)
Signed-off-by: crobibero <cody@robibe.ro>
3 years ago
Shadowghost
4e91c3ebdc
Fix DLNA DirectPlay
3 years ago
Dmitry Lyzo
e4137a6279
Fix remuxing
3 years ago
Dmitry Lyzo
1fe82d0deb
Add TranscodingProfile conditions
3 years ago
Cody Robibero
b9c3a497d5
Use requested bitrate for calculations
3 years ago
Cody Robibero
d29c7c1d9e
Revert using Math.Clamp
3 years ago
Cody Robibero
e6df698df1
Merge pull request #7325 from eyezak/issue/6450
3 years ago
Cody Robibero
3ea4174d12
Fix flipped Clamp args
3 years ago
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
3 years ago
Cody Robibero
da41cd365c
Suggestions from review
3 years ago
Cody Robibero
bbd5d11d3b
Remove TranscodeReason.None, Add JsonFlagEnum tests
3 years ago
Cody Robibero
c331e11c24
Clean up EnumFlags serialization
3 years ago
Isaac Gordezky
9ebd521754
Update MediaBrowser.Model/Dlna/StreamBuilder.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
3 years ago
Isaac Gordezky
84a3db6f84
Fix transcode video matching and add tests for Transcode and Safari
3 years ago
Isaac Gordezky
5e779f20ee
Series: issue-6450
...
Issue: https://github.com/jellyfin/jellyfin/issues/6450
Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
3 years ago
Isaac Gordezky
d871dded9f
Convert TranscodeReason to Flags
3 years ago
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
Shadowghost
ca5112f45a
feat(external-media): refactor external subtitle and audio provider
3 years ago
Bond_009
1c14c86b20
Fix some warnings
3 years ago
Cody Robibero
904efeaddc
Add null check for audio stream
3 years ago
Cody Robibero
7bfc6b5679
Remove more warnings
3 years ago
Bond_009
cbfa355e31
Update StyleCop
3 years ago
Cody Robibero
55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop
3 years ago
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
3 years ago
cvium
a7a7173cd5
Force a remux/transcode with external audio files
3 years ago
cvium
b880dc8a4a
Use our own Contains extension
3 years ago
Marius Luca
7d86ef6f22
- add an option for dropping specific subtitle formats using the DLNA SubtitleProfile
3 years ago
Marius Luca
5b5ae1ef52
- enable seek function when direct streaming over DLNA
3 years ago
cvium
6985a4f255
Fix SortCriteria and refactor SetSorting
3 years ago
Cody Robibero
64652b6392
Fix and disable new dotnet6 warnings
3 years ago
zehner
bbf40d6be2
Update StreamBuilder.cs
...
LogLevel INFO => DEBUG
3 years ago
Bond_009
1b6eb2ff2d
Enable nullable for more files
3 years ago
KonH
6cbfdea4c0
Fix warning: Type cast is redundant ( #2149 )
3 years ago
KonH
d45fcdd5af
Fix warning: Redundant control flow jump statement ( #2149 )
3 years ago
Bond_009
0d16c48998
Fix some warnings
3 years ago
Fernando Fernández
3d0b1ccae6
Remove all unused usings
3 years ago
Bond_009
637e86478f
Fix some warnings
3 years ago
Cody Robibero
cba07b1ca6
Remove more and more warnings
3 years ago
MrTimscampi
22efb69e92
Document SubtitleDeliveryMethod
3 years ago
Bond-009
b6df851363
Merge pull request #5984 from Bond-009/container
...
Add regression test for ContainerProfile.ContainsContainer
4 years ago
Bond_009
39931fe3ad
Add regression test for ContainerProfile.ContainsContainer
4 years ago
Maxr1998
65a9a4771a
Fix direct play for DirectPlayProfiles without any codecs set
...
70771fdcd6
broke direct play by treating empty container/codec strings as unsupported in `ContainerProfile.ContainsContainer()`` (which is also used for video and audio codec checks). Instead, they should be treated as supported, for both the positive and negative list option.
4 years ago
Bill Thornton
df40828e1f
Merge pull request #5941 from Maxr1998/device-profile-docs
...
Improve documentation for DeviceProfile
4 years ago
crobibero
1a178e8490
Remove Required attributes
4 years ago
Maxr1998
031a5c122d
Improve documentation for DeviceProfile
4 years ago
Maxr1998
b2bb062ced
Revert shortened 'is ... or' check
4 years ago
Maxr1998
244ad5b225
Apply review feedback
4 years ago
Maxr1998
70771fdcd6
Nullability handling for device profile classes
4 years ago
Bond-009
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
4 years ago
Bond-009
f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
...
PlayTo Fix: Use external ip not internal interface
4 years ago
Bond-009
184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
...
Various DLNA Optimizations
4 years ago
BaronGreenback
bb6fddde9a
Group Methods
4 years ago
BaronGreenback
3199d1c902
Fix: PlayTo using external ip not internal
4 years ago
Bond-009
fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type
4 years ago
Dmitry Lyzo
36da7a06d7
Less negation
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
Bond-009
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values
4 years ago
BaronGreenback
d9a50cb510
Various DLNA Optimizations
4 years ago
Max Rumpf
21e7ceae8e
StreamBuilder tweaks ( #5668 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
Dmitry Lyzo
364e8931af
Check appropriate profile type
4 years ago
cvium
74e14b4ca5
fix isdirectstream default
4 years ago
cvium
7dedeb6c79
change HLS endpoint defaults to false
4 years ago
Bond_009
401bafbfd0
Address comments
4 years ago
Bond_009
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
4 years ago
Bond_009
65bab55ca0
Minor improvements
4 years ago
crobibero
c8a95e0926
Fix null reference when logging
4 years ago
Bond_009
e4fd61411f
Minor improvements
4 years ago
nyanmisaka
b4598bd71b
Merge remote-tracking branch 'upstream/master' into fmp4-hls
4 years ago
nyanmisaka
b02ceea91b
increase bitrate to 20Mbps for 1440p transcoding
4 years ago
Nyanmisaka
5ff08338d5
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
Greenback
9a323f6df0
More spelling corrections.
4 years ago
Joshua M. Boniface
e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
...
Add FLAC and define the corresponding target sample rate
4 years ago
Joshua M. Boniface
e86db484ef
Merge pull request #4136 from BaronGreenback/Comment1
...
DLNA Classes - No code change, just added commenting to classes.
4 years ago
nyanmisaka
488dbdb31d
Merge remote-tracking branch 'upstream/master' into fmp4-hls
4 years ago
Bond_009
ff49a3bb61
Missed some stuff
4 years ago
BaronGreenback
27bb17ef9d
Merge branch 'master' into Comment1
4 years ago
nyanmisaka
57e5b59b93
adjust bitrate limit for HLS audio codecs
4 years ago
nyanmisaka
85965741f5
add initial support for HEVC over FMP4-HLS
4 years ago
nyanmisaka
00f0c14d7b
respect music quality settings when transcoding
4 years ago
Stéphane Senart
5979151f11
[AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate
4 years ago
Stéphane Senart
28ee4f0a7f
[AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate
4 years ago
BaronGreenback
63be65dd91
Merge branch 'master' into Comment1
4 years ago
Jan-Pieter Baert
ec91d3893d
Fix SA 1116 warnings
4 years ago
Maxr1998
e01209a6f5
Log stream type and codec for missing direct play profile
4 years ago
Matt Montgomery
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
dkanada
028c681c15
Merge pull request #3928 from Mygod/patch-1
...
Add 1440p to the mix
4 years ago
Jim Cartlidge
68de105dc2
Comments part 1
4 years ago