f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
719b707281
feat(external-media): refactor to generic provider, extend tests and file recognition, consolidate and extend NamingOptions
3 years ago
488ce51032
Remove some allocations ( #7246 )
3 years ago
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
3 years ago
a60cb280a3
Properly populate QueryResult
3 years ago
f28384ba30
Ignore JSON serialization for special features of movie.
...
When refreshing the metadata of the video with a local trailer, the server gets
stuck trying to read the database and save the item at the same time.
3 years ago
a0f248e200
Merge pull request #7134 from adavier/trakt-episode-links
3 years ago
a26509a98a
Keep from serializing trailers into database
3 years ago
9574d13059
Implement trakt episode links using the implementation from Series.cs
...
The code is the same as `MediaBrowser.Controller/Entities/TV/Series.cs`, using the imdbID to generate Trakt links.
The trakt url for episodes is `https://trakt.tv/episodes/{0} `.
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
cbfa355e31
Update StyleCop
3 years ago
a8a8ce4e7b
Fix build from PR merging
3 years ago
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
3 years ago
00211ca056
Merge pull request #7028 from cvium/everything_went_wrong
3 years ago
05c8834a3a
Don't cache special feature ids
3 years ago
9158511017
Don't skip extras refresh when replacing metadata or doing a full refresh
3 years ago
b880dc8a4a
Use our own Contains extension
3 years ago
83a94aa612
Fix extras folders
3 years ago
91f3ce3109
Use == instead of Object.Equals to avoid closure allocation
3 years ago
9a0618552b
Merge branch 'master' into what_could_go_wrong
3 years ago
0edf77994a
Cache BaseItemKind
3 years ago
c5569c701c
Folder can't have extras
3 years ago
32629cd7da
Use BaseItemKind where possible
3 years ago
fde84a1e00
Refactor extras parsing
3 years ago
180e2dc329
Prevent crashes in specific scenarios
3 years ago
9978164438
Add support for external audio files
3 years ago
b2b4bd82d7
Merge pull request #6862 from 1337joe/query-instead-of-filtering
3 years ago
9ba7bf96ef
Query MediaSourceManager directly in image providers
...
Add doc comments/minor tweaks to AudioImageProvider
3 years ago
7cf5767949
Query media streams by type instead of filtering
3 years ago
257e1be95f
Fix some warnings
3 years ago
5b1b2621ab
Fix build
3 years ago
b50c3852ef
Remove unused dependencies
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
5726535a26
Fix some warnings
...
609 left
3 years ago
64652b6392
Fix and disable new dotnet6 warnings
3 years ago
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
3 years ago
924c6682b9
Remove unused IHasScreenshots interface
3 years ago
416894008e
Minor improvements
...
* Removed some allocations
* Removed some useless abstractions
3 years ago
7fcf01235c
Change RemoveImages to array, improve download test
3 years ago
b478b115e3
Refactor to validate all images up front
3 years ago
e3fccd5ae6
Fix warning: Qualifier is redundant ( #2149 )
3 years ago
9234e5bf80
Remove all instances of en-US culture
3 years ago
27e32083a1
Update LINQ query according to code review feedback.
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
3 years ago
dc8420c7a2
Fix extra folder type resolving.
3 years ago
0d16c48998
Fix some warnings
3 years ago
b8eb8940c7
Merge pull request #6257 from MrTimscampi/music-library-backdrop
...
Use artist backdrop for generated library image
3 years ago
66659b0842
Merge pull request #6089 from BaronGreenback/IsRoot_fix
...
Set UserRootFolder.IsRoot to true
3 years ago
637e86478f
Fix some warnings
3 years ago
3ec7ecf399
Merge pull request #6358 from MrTimscampi/audio-people
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
3300d2d7d3
Enable people for audio files
3 years ago
e7a3552aae
Update per feedback
3 years ago
312e2685f8
Update MediaBrowser.Controller/Entities/IHasMediaSources.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
e3df4dcaae
Fix warnings in MediaBrowser.Controller
3 years ago
ad6f27143f
Update MediaBrowser.Controller/Entities/Folder.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
3 years ago
e72868f72b
Update AggregateFolder.cs
4 years ago
0ce7a15534
Fix more warnings
4 years ago
a16e66615c
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
32616d15f2
Update MediaBrowser.Controller/Entities/AggregateFolder.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
a7cc77e7fa
Fix partial set of MediaBrowser.Controller/Entities warnings
4 years ago
c22582b5aa
Merge pull request #6281 from crobibero/controller-warn-04
4 years ago
915141f196
Fix some warnings
4 years ago
65f8d8c0cd
[CA1801] Parameter is never used. Remove the parameter or use it in the method body.
4 years ago
8a65a6dfc3
Use artist backdrop for generated library image
4 years ago
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
4 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
4 years ago
cb77f8ee28
Merge pull request #6172 from Bond-009/nullable6
...
Remove useless nullable directives
4 years ago
cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram
4 years ago
383c2d7374
Remove useless nullable directives
4 years ago
ed2f08d05f
Merge pull request #6156 from Bond-009/minor14
...
Minor fixes
4 years ago
f17d43c564
Merge pull request #6071 from BaronGreenback/DLNAFolderFixPart1
...
Make DLNA folders to work as expected.
4 years ago
b8f5a14384
Merge pull request #6117 from LinFor/pr_originaltitle_in_lookupinfo
...
Add OriginalTitle to ItemLookupInfo
4 years ago
c78457e6d3
Minor fixes
4 years ago
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
05c241da78
Add OriginalTitle to ItemLookupInfo
4 years ago
42a2cc1747
Remove some unnecessary allocations
4 years ago
51fb6e1d2d
Merge branch 'master' into IsRoot_fix
4 years ago
d0537a3271
Set isRoot to true
4 years ago
8d2e5ef8c6
Merge pull request #6042 from crobibero/mbc-warn-2
4 years ago
2b321d8b89
Enable nullable for InternalItemsQuery
4 years ago
48bb338352
Enable child items to be returned if a musicAlbum
4 years ago
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
4 years ago
e3f55a0c54
Reduce warnings in MediaBrowser.Controller ( #6006 )
...
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
4 years ago
bcb4010db6
More improvements
4 years ago
787bcd4a83
Remove dead code
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
f2c10471bf
Code Clean up: Use Pattern Matching ( #5838 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
b9d18f0fa7
Merge branch 'master' into allocationz
4 years ago
360d80c873
Merge pull request #5890 from Bond-009/filesystem
...
Reduce string allocations/fs lookups in resolve code
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
4 years ago
b323044139
Reduce string allocations/fs lookups in resolve code
4 years ago
f46195899e
Improve perf of db save and query
4 years ago
24103d0953
Merge pull request #5876 from Bond-009/nullref5
...
DeepCopy: Throw ArgumentNullException if one of the args is null
4 years ago
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf
4 years ago
63e9b1ae2d
DeepCopy: Throw ArgumentNullException if one of the args is null
4 years ago
bc1cc2d04a
Remove unused using directives
4 years ago
bb6fddde9a
Group Methods
4 years ago
d44b2e2ee5
fixes
4 years ago
723b6abcb3
Optimize the way items are grouped into collections
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
c5a870051a
Use distinct for artists to avoid double refreshing
4 years ago
65bab55ca0
Minor improvements
4 years ago
223b42aed3
Create BaseItemKind enum
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
043d045448
Put json serializer options in private field
4 years ago
b9dbdc7e54
Remove custom Json serializer from MediaBrowser.Controller
4 years ago
ee23d06154
Use a more descriptive function name
4 years ago
f5cce9e630
Use typed UserManager GetPreference
4 years ago
b670937c3d
Use typed UserManager GetPreference
4 years ago
15a3d8d626
Forgot to revert some other changes, dunno if needed
4 years ago
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
...
Increase library scan and metadata refresh speed
4 years ago
f4edca7c27
Move MetadataRefreshThrottler to BaseItemManager
4 years ago
a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
...
Playback (direct-stream/transcode) of BDISO/BDAV containers
4 years ago
e8cb9cea7d
Merge branch 'master' into library_scan_speed
4 years ago
bf54b5579c
Merge branch 'master' into defer_image_fetching
4 years ago
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
4 years ago
4a22380565
Merge remote-tracking branch 'upstream/master' into library_scan_speed
4 years ago
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
...
Corrects spelling in comments
4 years ago
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
...
Add BaseItemManager
4 years ago
9a323f6df0
More spelling corrections.
4 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
d0cf60e145
Fixes #4465 by adding the missing extras folders.
4 years ago
e6d8c02944
Merge remote-tracking branch 'upstream/master' into library_scan_speed
4 years ago
584b4fa41f
Fix Persons, Genres and Studios endpoints
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
3bb8884e16
Merge branch 'master' into bdiso-playback
4 years ago
64b32d3290
Use BaseItemManager
4 years ago
5a9c218324
Fix build
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
4 years ago
a51adec836
fix parallelism when set to 0
4 years ago
8f2fbf7a99
Switch to TPL dataflow for subfolder scan
4 years ago
cd4641dca0
Remove PlayableStreamFileNames as unused
...
Since ffmpeg can play and transcode ISO files and BDMV folders directly,
there's no use of that property.
4 years ago
c2276b17cb
Increase library scan and metadata refresh speed
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
5e76d5fd56
Merge pull request #3879 from cvium/fix_theme_songs
...
Populate ThemeVideoIds and ThemeSongIds
4 years ago
abc527329d
Sort by SortName after scanning
4 years ago
208b00fbb1
Add the item path to the ItemLookupInfo class.
...
This is important for the Shoko Anime Meatdata provider plugin.
4 years ago
c4d8275fc1
Fix duplicate
4 years ago
404bb4f835
Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release
4 years ago
119f64f5e7
Make some methods async
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
68edccd9f4
More warn
4 years ago
2b400c99ef
Fix warnings
4 years ago
e10693cbe0
Remove some LINQ queries
4 years ago
1ae3dc202c
Populate ThemeVideoIds and ThemeSongIds
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
5 years ago
Bond_009
Shadowghost
Claus Vium
Cody Robibero
Dmitry Lyzo
Joe Rogers
adavier
cvium
Jonas Resch
KonH
Dixin
dkanada
MrTimscampi
Rich Lander
PingWin
BaronGreenback
David
Gary Wilber
Joshua M. Boniface
Kayila
Anthony Lavado
Stan
Jan-Pieter Baert
Matt Montgomery
Erwin de Haan