82080bd1ef
Apply review suggestions
1 year ago
8d158df678
Add migration to properly set playlist owner
1 year ago
76ae599bd3
Fix playlist creation and removal
1 year ago
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
1 year ago
52194f56b5
Replace != null with is not null
1 year ago
c7d50d640e
Replace == null with is null
1 year ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2 years ago
7bfc6b5679
Remove more warnings
2 years ago
474b035d99
Fix some warnings
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
65f8d8c0cd
[CA1801] Parameter is never used. Remove the parameter or use it in the method body.
3 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
3 years ago
bb6fddde9a
Group Methods
3 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
2b832de289
Fix build
4 years ago
119f64f5e7
Make some methods async
4 years ago
01e781035f
Fix warnings
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
24f54837e1
Switch to M3uContent
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
c464f700db
Remove redundant qualifiers
4 years ago
9ad839c776
Initial migration code
4 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
9a7875b6f9
Do not check for duplicates if they are allowed in playlist configuration
4 years ago
d276e0f8f4
Use Distinct() to filter out duplicates when adding items to playlist
4 years ago
487aa376b4
Merge remote-tracking branch 'upstream/master' into 1914-prevent-duplicates-in-playlists
4 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
4 years ago
3cb98fba55
Use ToList() instead of ToArray() on sequences of unknown size
4 years ago
6438771212
Exit method early if there are no unique playlist items to add
4 years ago
4d32b59a0b
Performance improvements
...
Use arrays instead of lists; use Array.CopyTo to concat playlist items; only count number of duplicates once
4 years ago
77533fd433
Revert unnecessary style change
4 years ago
dde0277050
Check for duplicates when adding items to a playlist
4 years ago
1b2453b4e9
fix playlist deletion
4 years ago
d9a03c9bb1
Fix more warnings
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
b9a111432a
Unwrapped all /(Write|Read)All(Text|Bytes)/ functions.
5 years ago
581a7fe078
Unwrapped `MoveDirectory`, `DirectoryExists`, `FileExists` & removed `MoveFile`
5 years ago
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
5 years ago
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
5 years ago
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
5 years ago
65bd052f3e
ReSharper conform to 'var' settings
5 years ago
39ef1106d7
Visual Studio Reformat: Emby.Server.Implementations Part Liv-P
5 years ago
846456b41e
Reformatted the files with notes.
5 years ago
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
5 years ago
b7ebb67cbb
Remove the need for NullLogger
5 years ago
Shadowghost
Shadowghost
Bond_009
Cody Robibero
BaronGreenback
telans
Patrick Barron
Vasily
Mark Monteiro
dkanada
Erwin de Haan
William Taylor