719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull
2 years ago
87d460909f
Fix minor warnings in MediaBrowser.Model/Configuration ( #2149 )
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
4edeccc5e0
Remove redundant using directives
2 years ago
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
3 years ago
38102499cb
Merge pull request #7947 from nyanmisaka/video-range-condition
...
(cherry picked from commit f1d56aa5ce
3 years ago
47d150565d
Merge pull request #7712 from jellyfin/fix-hevc-disable-option
...
(cherry picked from commit 5a9e5e0d5d
3 years ago
2d8f7b46f1
Merge pull request #7699 from Shadowghost/streambuilder-fix
...
(cherry picked from commit b46d61dfdf
3 years ago
688553b9a8
Merge pull request #7537 from dmitrylyzo/fix-streambuilder
...
(cherry picked from commit 5833c70725
3 years ago
1960b5bdce
Merge pull request #7523 from crobibero/null-stream
...
Allow media without streams to playback
(cherry picked from commit 577325b788
3 years ago
4e91c3ebdc
Fix DLNA DirectPlay
3 years ago
e4137a6279
Fix remuxing
3 years ago
1fe82d0deb
Add TranscodingProfile conditions
3 years ago
b9c3a497d5
Use requested bitrate for calculations
3 years ago
d29c7c1d9e
Revert using Math.Clamp
3 years ago
e6df698df1
Merge pull request #7325 from eyezak/issue/6450
3 years ago
3ea4174d12
Fix flipped Clamp args
3 years ago
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
3 years ago
da41cd365c
Suggestions from review
3 years ago
bbd5d11d3b
Remove TranscodeReason.None, Add JsonFlagEnum tests
3 years ago
c331e11c24
Clean up EnumFlags serialization
3 years ago
9ebd521754
Update MediaBrowser.Model/Dlna/StreamBuilder.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
3 years ago
84a3db6f84
Fix transcode video matching and add tests for Transcode and Safari
3 years ago
5e779f20ee
Series: issue-6450
...
Issue: https://github.com/jellyfin/jellyfin/issues/6450
Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
3 years ago
d871dded9f
Convert TranscodeReason to Flags
3 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
ca5112f45a
feat(external-media): refactor external subtitle and audio provider
3 years ago
1c14c86b20
Fix some warnings
3 years ago
904efeaddc
Add null check for audio stream
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
cbfa355e31
Update StyleCop
3 years ago
55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop
3 years ago
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
3 years ago
a7a7173cd5
Force a remux/transcode with external audio files
3 years ago
b880dc8a4a
Use our own Contains extension
3 years ago
7d86ef6f22
- add an option for dropping specific subtitle formats using the DLNA SubtitleProfile
3 years ago
5b5ae1ef52
- enable seek function when direct streaming over DLNA
3 years ago
6985a4f255
Fix SortCriteria and refactor SetSorting
3 years ago
64652b6392
Fix and disable new dotnet6 warnings
3 years ago
bbf40d6be2
Update StreamBuilder.cs
...
LogLevel INFO => DEBUG
3 years ago
1b6eb2ff2d
Enable nullable for more files
3 years ago
6cbfdea4c0
Fix warning: Type cast is redundant ( #2149 )
3 years ago
d45fcdd5af
Fix warning: Redundant control flow jump statement ( #2149 )
3 years ago
0d16c48998
Fix some warnings
4 years ago
3d0b1ccae6
Remove all unused usings
4 years ago
637e86478f
Fix some warnings
4 years ago
cba07b1ca6
Remove more and more warnings
4 years ago
22efb69e92
Document SubtitleDeliveryMethod
4 years ago
b6df851363
Merge pull request #5984 from Bond-009/container
...
Add regression test for ContainerProfile.ContainsContainer
4 years ago
39931fe3ad
Add regression test for ContainerProfile.ContainsContainer
4 years ago
65a9a4771a
Fix direct play for DirectPlayProfiles without any codecs set
...
70771fdcd6
4 years ago
df40828e1f
Merge pull request #5941 from Maxr1998/device-profile-docs
...
Improve documentation for DeviceProfile
4 years ago
1a178e8490
Remove Required attributes
4 years ago
031a5c122d
Improve documentation for DeviceProfile
4 years ago
b2bb062ced
Revert shortened 'is ... or' check
4 years ago
244ad5b225
Apply review feedback
4 years ago
70771fdcd6
Nullability handling for device profile classes
4 years ago
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
4 years ago
f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
...
PlayTo Fix: Use external ip not internal interface
4 years ago
184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
...
Various DLNA Optimizations
4 years ago
bb6fddde9a
Group Methods
4 years ago
3199d1c902
Fix: PlayTo using external ip not internal
4 years ago
fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type
4 years ago
36da7a06d7
Less negation
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values
4 years ago
d9a50cb510
Various DLNA Optimizations
4 years ago
21e7ceae8e
StreamBuilder tweaks ( #5668 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
364e8931af
Check appropriate profile type
4 years ago
74e14b4ca5
fix isdirectstream default
4 years ago
7dedeb6c79
change HLS endpoint defaults to false
4 years ago
401bafbfd0
Address comments
4 years ago
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
4 years ago
65bab55ca0
Minor improvements
4 years ago
c8a95e0926
Fix null reference when logging
4 years ago
e4fd61411f
Minor improvements
4 years ago
b4598bd71b
Merge remote-tracking branch 'upstream/master' into fmp4-hls
4 years ago
b02ceea91b
increase bitrate to 20Mbps for 1440p transcoding
4 years ago
5ff08338d5
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
9a323f6df0
More spelling corrections.
4 years ago
e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
...
Add FLAC and define the corresponding target sample rate
4 years ago
e86db484ef
Merge pull request #4136 from BaronGreenback/Comment1
...
DLNA Classes - No code change, just added commenting to classes.
4 years ago
488dbdb31d
Merge remote-tracking branch 'upstream/master' into fmp4-hls
4 years ago
ff49a3bb61
Missed some stuff
4 years ago
27bb17ef9d
Merge branch 'master' into Comment1
4 years ago
57e5b59b93
adjust bitrate limit for HLS audio codecs
4 years ago
85965741f5
add initial support for HEVC over FMP4-HLS
4 years ago
00f0c14d7b
respect music quality settings when transcoding
4 years ago
5979151f11
[AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate
4 years ago
28ee4f0a7f
[AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate
4 years ago
63be65dd91
Merge branch 'master' into Comment1
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
e01209a6f5
Log stream type and codec for missing direct play profile
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
028c681c15
Merge pull request #3928 from Mygod/patch-1
...
Add 1440p to the mix
4 years ago
68de105dc2
Comments part 1
5 years ago
eedb520af1
Removed code that wasn't used.
5 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
5 years ago
2b400c99ef
Fix warnings
5 years ago
8b9a380466
Add 1440p to the mix
...
Partially addresses #3112 .
5 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
5 years ago
ab396225ea
Migrate Display Preferences to EF Core
5 years ago
f3151e7dc7
Merge pull request #3505 from Bond-009/minor3
...
Minor fixes
5 years ago
ae6eaa7f02
Minor fixes
5 years ago
6d1b00da64
Use Array.Empty
5 years ago
5bb639a59a
newlines after braces
5 years ago
7f307f9082
brace multiline if statements
5 years ago
98db8f72e0
fix SA1503 for one line if statements
5 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
5 years ago
247f9c61e6
fix SA1513/SA1516
5 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
5 years ago
3d9049ef08
fix SA1508
5 years ago
acd4389653
fix SA1005
5 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
7659a2ab32
Remove ListHelper extensions
5 years ago
fc049caba2
Merge branch 'master' into nullable3
5 years ago
8e514f8d63
Fix check for profile supporting a codec - it should first check if profile is talking about media type
...
For example, audio-only profiles have "VideoCodec" set to "null" which translates to "any codec", which breaks some logic later on
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
f47ad85011
Fix warnings MediaBrowser.Model
5 years ago
fdbb329118
Remove StringHelper functions
5 years ago
675754bc5c
Possible fix for MrMC
6 years ago
ddd1a282ea
Remove IpAddressInfo and IpEndPointInfo classes
6 years ago
93e535d3a1
Trying to make sense of the streaming code
...
Mostly small changes as I was looking through the code.
* async void -> async Task
* Properly implemented dispose methods
* Pass the logstream directly to the JobLogger
* Style fixes
6 years ago
d18823ced1
Fix potential NullReferenceException
6 years ago
a709cbdc64
Fix more analyzer warnings
6 years ago
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
6 years ago
2f8f9e6853
Address comments
6 years ago
06d9423f00
Clean up last bits
6 years ago
37be6c87eb
Make ConditionProcessor static
6 years ago
c9b88ab741
Clean up streambuilder
6 years ago
38f96af079
Reformat JustAMan review pt2 changes
...
Refs #575
6 years ago
e867446437
ReSharper format: conform inline 'out' parameters.
6 years ago
65bd052f3e
ReSharper conform to 'var' settings
6 years ago
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
6 years ago
8f41ba4d3a
Find+Sed BOM removal *.cs: MediaBrowser.LocalMetadata-MediaBrowser.Model
6 years ago
382e8699a2
EditorConfig reformat: MediaBrowser.Model
6 years ago
1a4b271314
Visual Studio Reformat: MediaBrowser.Model
6 years ago
e2751d42e8
Merge branch 'dev' into code-cleanup
6 years ago
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
6 years ago
bd169e4fd4
remove trailing whitespace
6 years ago
ba1794f64b
Remove tabs and trailing whitespace
6 years ago
340a2c6512
Post GPL cleanup
6 years ago
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
6 years ago
6e5d2aadaa
Remove custom ToArray extension
6 years ago
a86b71899e
Add GPL modules
6 years ago
48facb797e
Update to 3.5.2 and .net core 2.1
7 years ago
5207067811
fix live tv over dlna
7 years ago
Claus Vium
Jan Sommer
Bond_009
Hannes Braun
luz paz
Cody Robibero
Joshua M. Boniface
Shadowghost
Dmitry Lyzo
Isaac Gordezky
Isaac Gordezky
cvium
Marius Luca
zehner
KonH
Fernando Fernández
MrTimscampi
Maxr1998
Bill Thornton
BaronGreenback
Dmitry Lyzo
nyanmisaka
Stéphane Senart
Jan-Pieter Baert
Matt Montgomery
dkanada
Patrick Barron
Mygod
telans
Vasily
Mark Monteiro
William Lees
Erwin de Haan
hawken
Andrew Rabert
stefan
Luke Pulverenti