a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
bffda19bbc
Backport pull request #8166 from jellyfin/release-10.8.z
...
Bind @userid only when it's in the statement
Authored-by: Joseph <1315585+joseph39@users.noreply.github.com>
Merged-by: Claus Vium <cvium@users.noreply.github.com>
Original-merge: 057e8ef240
2 years ago
fe32b5e333
Merge pull request #7964 from jellyfin/dovi-side-data
...
(cherry picked from commit 39d185c7b1
2 years ago
5b0af106c2
Merge pull request #7940 from Shadowghost/fix-recommendations
...
(cherry picked from commit 6749313249
2 years ago
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438
3 years ago
efcdab116f
Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
...
(cherry picked from commit 60affd0965
3 years ago
78a8c26690
Don't allow unknown sort-by
3 years ago
1a307db7eb
Add label for external audio/sub tracks
3 years ago
23ea14aa27
Clean up SqliteItemRepository
...
* remove dead code
* reduce allocations
3 years ago
1c14c86b20
Fix some warnings
3 years ago
a60cb280a3
Properly populate QueryResult
3 years ago
7d63377194
Use provided SortOrder
3 years ago
f802763e8f
Reverse all order-by
3 years ago
c3071f8996
Fix orderby query
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
ea8f40e84a
More cleanup
3 years ago
cbfa355e31
Update StyleCop
3 years ago
8ddba55214
Use string builder instead of string interpolation
3 years ago
0dd304f86c
Log warning for unknown BaseItemKind to Type mapping
3 years ago
249a1ca955
Add mapping from BaseItemKind to Type.FullName for querying
3 years ago
87439665d7
Use array instead of HashSet
3 years ago
32629cd7da
Use BaseItemKind where possible
3 years ago
21007aec20
Fix warnings in Data
3 years ago
5fd315b17c
Address comments
3 years ago
4d1d9f23d5
Use new Enum.TryParse(ReadOnlySpan<char>) overload
3 years ago
3d0b1ccae6
Remove all unused usings
3 years ago
637e86478f
Fix some warnings
3 years ago
ec13412155
Merge remote-tracking branch 'upstream/master' into warn-259810
3 years ago
286dabdc4b
Add SqliteItemRepository.ItemImageInfoFromValueString as a fuzzing
...
target
and add test cases
3 years ago
ecb4b8e0aa
Apply suggestions from code review
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
5fb72951a0
Add test for ReadOnlySpan.Count extension
3 years ago
9111730a0a
More review
4 years ago
0835b26889
review
4 years ago
42a2cc1747
Remove some unnecessary allocations
4 years ago
3b59064f97
Bump SQLitePCL.pretty.netstandard to 3.0.1
4 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
e8790bfa96
Merge pull request #6054 from cvium/allocationz_2_extreme_db_plsdonthurtme
4 years ago
e0f793799a
Fix build
4 years ago
1027792b16
Review changes
4 years ago
2b321d8b89
Enable nullable for InternalItemsQuery
4 years ago
be4aeb5c2c
Rename SQL extension methods
4 years ago
1b49435a0e
Reduce some allocations
4 years ago
50f617357b
Merge pull request #5929 from crobibero/sort
4 years ago
d729a76707
Merge pull request #5934 from Bond-009/utf8
...
SqliteItemRepository: Parse ChannelId directly from utf-8 data
4 years ago
c0feb3694b
rename to SplitEnumerator and fix test
4 years ago
b9d18f0fa7
Merge branch 'master' into allocationz
4 years ago
874f92e93a
Add tests for SqliteItemRepository.(De)SerializeProviderIds
4 years ago
8a6b9e1fb6
Add tests for SqliteItemRepository.(De)SerializeImages
4 years ago
716cbb0695
remove span based setproviderid
4 years ago
a6726730fc
revert the last bits of the getcount experiment
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
34313ef216
SqliteItemRepository: Parse ChannelId directly from utf-8 data
4 years ago
d27ca993a5
Add ability to sort on Genre, MusicGenre, Artist
4 years ago
a02e37daa0
SqliteItemRepository: remove redundant operations
...
removed:
* nameof -> FullName lookup
* IndexOf before Replace
* Enum.GetNames -> Enum.Parse roundtrip
4 years ago
db530e61f5
move IsPlayed to outerquery
...
IsPlayed is a column in UserDatas and does not belong in the inner query. None of the other UserDatas columns are in the innerquery.
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
4 years ago
65bab55ca0
Minor improvements
4 years ago
60b7e49a7f
Suggestions from code review
4 years ago
b7443f6042
Optimize FavoritePersons query
4 years ago
185476c08a
Add support for query negation
4 years ago
0758d84a61
Test query value
4 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
b99519898d
Remove duplicate /Similar endpoints and add poor matching for artists and albums
4 years ago
584b4fa41f
Fix Persons, Genres and Studios endpoints
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
6f9beef732
Fix SA1012 and SA1013 warnings
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
15be11fca8
Fix build
4 years ago
48e1cf9fd7
Minor performance improvements to item saving
4 years ago
5f64ab02a0
bump System.Text.Json
4 years ago
340f83c3f5
Ignore null json values
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
2b400c99ef
Fix warnings
4 years ago
4980db1594
Fix spelling
4 years ago
2b355c36ff
Minor improvements
...
OFC I reduced some allocations
4 years ago
996d0c07d0
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
4 years ago
85e43d657f
Update Emby.Server.Implementations/Data/SqliteItemRepository.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
aa32aba0f8
Remove some unnecessary string allocations.
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
01e781035f
Fix warnings
4 years ago
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
4d681e3cad
Optimize StringBuilder.Append calls
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
8de6452967
fix some documentation periods
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
299e49f39d
Fix a small number of compile warnings
5 years ago
22a860a806
Fix a small number of compile warnings
5 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
5 years ago
Bond_009
Joshua Boniface
Cody Robibero
Joe Rogers
Patrick Barron
Fernando Fernández
cvium
Claus Vium
Matt Montgomery
Anthony Lavado
Jan-Pieter Baert
Patrick Barron
telans
aled
Vasily