d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
05c241da78
Add OriginalTitle to ItemLookupInfo
4 years ago
42a2cc1747
Remove some unnecessary allocations
4 years ago
51fb6e1d2d
Merge branch 'master' into IsRoot_fix
4 years ago
d0537a3271
Set isRoot to true
4 years ago
8d2e5ef8c6
Merge pull request #6042 from crobibero/mbc-warn-2
4 years ago
2b321d8b89
Enable nullable for InternalItemsQuery
4 years ago
48bb338352
Enable child items to be returned if a musicAlbum
4 years ago
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
4 years ago
e3f55a0c54
Reduce warnings in MediaBrowser.Controller ( #6006 )
...
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
4 years ago
bcb4010db6
More improvements
4 years ago
787bcd4a83
Remove dead code
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
f2c10471bf
Code Clean up: Use Pattern Matching ( #5838 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
b9d18f0fa7
Merge branch 'master' into allocationz
4 years ago
360d80c873
Merge pull request #5890 from Bond-009/filesystem
...
Reduce string allocations/fs lookups in resolve code
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
4 years ago
b323044139
Reduce string allocations/fs lookups in resolve code
4 years ago
f46195899e
Improve perf of db save and query
4 years ago
24103d0953
Merge pull request #5876 from Bond-009/nullref5
...
DeepCopy: Throw ArgumentNullException if one of the args is null
4 years ago
48ed4b016c
Merge pull request #5808 from cvium/semi-fix-collection-perf
4 years ago
63e9b1ae2d
DeepCopy: Throw ArgumentNullException if one of the args is null
4 years ago
bc1cc2d04a
Remove unused using directives
4 years ago
bb6fddde9a
Group Methods
4 years ago
d44b2e2ee5
fixes
4 years ago
723b6abcb3
Optimize the way items are grouped into collections
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
c5a870051a
Use distinct for artists to avoid double refreshing
4 years ago
65bab55ca0
Minor improvements
4 years ago
223b42aed3
Create BaseItemKind enum
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
043d045448
Put json serializer options in private field
4 years ago
b9dbdc7e54
Remove custom Json serializer from MediaBrowser.Controller
4 years ago
ee23d06154
Use a more descriptive function name
4 years ago
f5cce9e630
Use typed UserManager GetPreference
4 years ago
b670937c3d
Use typed UserManager GetPreference
4 years ago
15a3d8d626
Forgot to revert some other changes, dunno if needed
4 years ago
f1cc01f324
Merge pull request #4242 from Spacetech/library_scan_speed
...
Increase library scan and metadata refresh speed
4 years ago
f4edca7c27
Move MetadataRefreshThrottler to BaseItemManager
4 years ago
a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
...
Playback (direct-stream/transcode) of BDISO/BDAV containers
4 years ago
e8cb9cea7d
Merge branch 'master' into library_scan_speed
4 years ago
bf54b5579c
Merge branch 'master' into defer_image_fetching
4 years ago
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
4 years ago
4a22380565
Merge remote-tracking branch 'upstream/master' into library_scan_speed
4 years ago
212c5318ae
Merge pull request #4507 from BaronGreenback/Spelling
...
Corrects spelling in comments
4 years ago
15b9f993c6
Merge pull request #4342 from crobibero/base-item-manager
...
Add BaseItemManager
4 years ago
9a323f6df0
More spelling corrections.
4 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
d0cf60e145
Fixes #4465 by adding the missing extras folders.
4 years ago
e6d8c02944
Merge remote-tracking branch 'upstream/master' into library_scan_speed
4 years ago
584b4fa41f
Fix Persons, Genres and Studios endpoints
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
3bb8884e16
Merge branch 'master' into bdiso-playback
4 years ago
64b32d3290
Use BaseItemManager
4 years ago
5a9c218324
Fix build
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
4 years ago
a51adec836
fix parallelism when set to 0
4 years ago
8f2fbf7a99
Switch to TPL dataflow for subfolder scan
4 years ago
cd4641dca0
Remove PlayableStreamFileNames as unused
...
Since ffmpeg can play and transcode ISO files and BDMV folders directly,
there's no use of that property.
4 years ago
c2276b17cb
Increase library scan and metadata refresh speed
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
5e76d5fd56
Merge pull request #3879 from cvium/fix_theme_songs
...
Populate ThemeVideoIds and ThemeSongIds
4 years ago
abc527329d
Sort by SortName after scanning
4 years ago
208b00fbb1
Add the item path to the ItemLookupInfo class.
...
This is important for the Shoko Anime Meatdata provider plugin.
4 years ago
c4d8275fc1
Fix duplicate
4 years ago
404bb4f835
Enable TreatWarningsAsErrors for MediaBrowser.Controller in Release
4 years ago
119f64f5e7
Make some methods async
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
68edccd9f4
More warn
4 years ago
2b400c99ef
Fix warnings
4 years ago
e10693cbe0
Remove some LINQ queries
4 years ago
1ae3dc202c
Populate ThemeVideoIds and ThemeSongIds
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
6d1b00da64
Use Array.Empty
4 years ago
1398c2117c
Revert ILoggerFactory usage in BaseItem.cs
4 years ago
6556bec646
brace multiline if statements (cont.)
4 years ago
7f307f9082
brace multiline if statements
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
8de6452967
fix some documentation periods
4 years ago
afe09612e8
fix SA1119
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
afc9224ede
fix SA1111
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
4 years ago
fc02157b42
Fix build errors
4 years ago
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
4 years ago
299e49f39d
Fix a small number of compile warnings
4 years ago
ad5c41b542
Merge pull request #3258 from aled/2149-fix-a-small-number-of-compile-warnings-1
...
Fix a small number of compile warnings
4 years ago
98142613e8
Apply review suggestions and fix bug
4 years ago
22a860a806
Fix a small number of compile warnings
4 years ago
613748b45d
Make books resumable and have duration of 1 second
5 years ago
44957c5a9a
Use typed logger where possible
5 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
5 years ago
9208acd5ae
Convert non-local image to local before computing blurhash
5 years ago
31f725fdbf
Fix a bug in Emby.Notifications and clean up
5 years ago
eef7cfd912
Make SonarCloud less angry
5 years ago
1f83a21288
Rename Hash to BlurHash in all properties and methods for clarity
5 years ago
3fb4c1356c
Make blurhash be computed during regular scans if it was not already computed
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
b9fc0d2628
Add BlurHash support to backend
5 years ago
9ad839c776
Initial migration code
5 years ago
ed1dc5c922
Remove JsonIgnore from the DateLastSaved property of BaseItem
5 years ago
a73e1f18b6
Minor improvements
5 years ago
64a255f090
Fix misformed xml doc comment
5 years ago
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
5 years ago
0951dc632b
Update MediaBrowser.Controller/Entities/InternalPeopleQuery.cs
...
Co-Authored-By: Mark Monteiro <marknr.monteiro@protonmail.com>
5 years ago
d6224ddeda
Update InternalPeopleQuery.cs
5 years ago
3161e85f76
Address comments
5 years ago
f31efce52d
Merge branch 'master' into usings
5 years ago
1a4d9d4c53
Code review suggestions
5 years ago
3ab50f5a3f
Address comments
5 years ago
787049f35f
Merge branch 'master' into minor
5 years ago
cc8294842a
Add ExtraType.Unknown enum value and use it instead of null
5 years ago
e266ad51c5
Simplify logic; remove unnecessary methods
5 years ago
ea306e8f6d
Do not assign an invalid value of zero to ExtraType
5 years ago
5fcbedc194
Display extras with an unknown type
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
6897a19051
Add missing null check when retrieving extras
5 years ago
a96c0a72b8
Merge pull request #2549 from dkanada/refactor
...
Refactor some provider classes
5 years ago
008a76cf4d
Merge pull request #2502 from JustAMan/baseitem-equals
...
Adds BaseItem.Equals method that compares items by their Id
5 years ago
52fde64f10
remove unused files and fix some future warnings
5 years ago
f4ccee5801
Add inheritdoc comment and squash simple method bodies
5 years ago
456f571343
Follow code review suggestions
5 years ago
007c5b9f67
Implement BaseItem.GetHashCode override
5 years ago
c07e1e4f84
Merge pull request #2476 from JustAMan/playto-sort
...
Bring back sorting when needed to fix PlayTo
5 years ago
f21cd30039
Lower log level for BaseItem.Equals to debug
5 years ago
1c21248e2e
Merge pull request #2474 from JustAMan/simplify-sorting
...
Simplify AlphanumericComparer, reduce code duplication
5 years ago
ba8d8cede9
Replace foreach with for - MOAR SPEED
5 years ago
9a9f2aa293
Apply suggestions from code review
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
11abe31e0d
Speed up equality comparison of BaseItem
5 years ago
7f38af3701
Remove custom queue class as it is not needed
5 years ago
f81cd037f0
Small speed improvement - no need to convert an array to a list to just iterate over it
5 years ago
ae1f975b99
Implement fast sorting
5 years ago
0f0b89f344
Trying to be more safe
5 years ago
e125db4fe3
Bring back sorting when needed to fix PlayTo
...
This is partial revert of https://github.com/jellyfin/jellyfin/pull/1011
5 years ago
d1670f8180
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
5 years ago
8e20d2e931
Simplify AlphanumericComparer, reduce code duplication
5 years ago
a07ee65365
Minor improvements
5 years ago
65a9d618cc
add config options for musicbrainz
5 years ago
b02a3a29f5
Fix photo serialization
5 years ago
6a6472bb8a
Update MediaBrowser.Controller/Entities/PersonInfo.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
c9e11c95ee
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
32dcd372f4
Fix some warnings in MediaBrowser.Controller
5 years ago
87d2479b78
Fix warnings
5 years ago
d3de91dab6
Fix another issue with DLNA responses not properly paginating
...
The `UserRootFolder.GetItemsInternal` method now applies any sorting and
pagination requested by the `InternalItemsQuery` that was passed to it.
Previous pagination fix : #2304
Original issue #2303
5 years ago
bb236b9591
Merge branch 'master' into warn12
5 years ago
aca31457c0
merge branch master into media-attachments
5 years ago
7f5a174dff
Merge branch 'master' into warn12
5 years ago
2ef4ffd698
More warnings (removed)
5 years ago
0bf8bfbb0c
Merge branch 'master' into mediaencoding
5 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
cc5acf37f7
Make probesize and analyzeduration configurable and simplify circular
...
dependencies
Makes the probesize and analyzeduration configurable with env args.
(`JELLYFIN_FFmpeg_probesize` and `FFmpeg_analyzeduration`)
5 years ago
51cdc6ea16
Merge pull request #1926 from Bond-009/auth
...
Add clearer exceptions, warnings and docs
5 years ago
f51f59d675
Merge pull request #1965 from Bond-009/dbjson
...
Deserialize with the correct type (and warning fixes)
5 years ago
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
5 years ago
846857b60e
Deserialize with the correct type (and warning fixes)
5 years ago
d9a03c9bb1
Fix more warnings
5 years ago
f22ca6dd9e
Retrieve media attachments in BaseItem.
5 years ago
fef35d0505
Add clearer exceptions, warnings and docs
5 years ago
bbc0875387
Don't shuffle some types by default
5 years ago
5edb8159a7
Fix Json serialization error
5 years ago
bae5e3795e
Fix SetImage to avoid out of range exception ( #1798 )
...
* Fix SetImage to avoid out of range exception
* Actually use the new images we've retrieved
5 years ago
c9820d30ed
Fix multiple mistakes and warnings
5 years ago
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
5 years ago
e4f893a0eb
More warning fixes
5 years ago
fdc24ec2ee
Fix LocalTrailers playback.
5 years ago
8d3b5c851d
Improvements to UserManager
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
fc439cc02a
Merge pull request #1448 from joshuaboniface/nice-userconfig-paths
...
Use the username for the user config path
5 years ago
b25c08e79a
Merge pull request #1156 from Bond-009/sep
...
Small cleanups here and there
5 years ago
d1d0ddf62f
Use the username for the user config path
...
Use the username to construct the UserConfigurationDirectory,
instead of the user ID, and move the old ID-based path to the new
path if needed when loading (temporary transitional code). Removes
administrator guesswork as to what user each directory belongs to,
which I found very annoying when investigating user configs.
6 years ago
2d011b781e
Merge pull request #1383 from jellyfin/release-10.3.z
...
Backmerge for Release 10.3.3
6 years ago
0ef52c739e
Review changes
...
Untested
6 years ago
b8a09339cd
Enforce extras folder structure according to Emby's wiki
6 years ago
c1daea0ec7
Change owner and parent id of extras to the main media item
6 years ago
2f33e99006
Speed up DeepCopy
6 years ago
6566c91360
Seperate changes from #1023
...
The unrelated changes from #1023 (and more)
6 years ago
80fb3dc2cb
Fix error
6 years ago
4625592a83
Quick nullref fix
6 years ago
c5fce647de
Cleanup/simplification
...
* Removed useless copies/allocations
* Reduced unneeded complexity
6 years ago
1731bf7372
Remove ordering items
6 years ago
2690ac299b
Only refresh metadata if extras changed
6 years ago
9753a76905
Populate video extras again
6 years ago
1385d89df6
Remove MoreLINQ
6 years ago
c713824bf9
Merge pull request #734 from Bond-009/culture
...
Fix more analyzer warnings
6 years ago
8985fb8d58
Remove support for games as a media type
6 years ago
f7a46c7a56
Remove more Connect related stuff
6 years ago
1ea219bf3f
Merge branch 'master' into culture
6 years ago
8487319374
Merge pull request #726 from EraYaN/remove-wrappers-for-system-io
...
Clean up IFileSystem wrappers around stdlib.
6 years ago
450f246f95
Unwrapped `GetFileNameWithoutExtension`
6 years ago
Cody Robibero
PingWin
cvium
BaronGreenback
Bond-009
Claus Vium
David
Gary Wilber
Joshua M. Boniface
Kayila
Anthony Lavado
Stan
Jan-Pieter Baert
Matt Montgomery
Erwin de Haan
Patrick Barron
telans
dkanada
aled
Daniyar Itegulov
Vasily
Jesús Higueras
Anthony Lavado
Mark Monteiro
Vasily
Carey Metcalfe
Andrew Mahone
SL1288
Andrew Rabert
Anthony Lavado
Torsten