open-source-mirrors
/
overseerr
mirror of https://github.com/sct/overseerr
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: improved handling of edge case that could cause availability sync to fail (#3497)

Browse Source
pull/3514/head
Brandon Cohen 11 months ago committed by GitHub
parent 2c3f533076
commit d0836ce0ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 165 additions and 138 deletions
Show Stats Download Patch File Download Diff File

303
server/lib/availabilitySync.ts
Unescape View File

@ -30,23 +30,24 @@ class AvailabilitySync {
this.sonarrSeasonsCache = {}; this.sonarrSeasonsCache = {};
this.radarrServers = settings.radarr.filter((server) => server.syncEnabled); this.radarrServers = settings.radarr.filter((server) => server.syncEnabled);
this.sonarrServers = settings.sonarr.filter((server) => server.syncEnabled); this.sonarrServers = settings.sonarr.filter((server) => server.syncEnabled);
await this.initPlexClient();
if (!this.plexClient) { try {
return; await this.initPlexClient();
}
logger.info(`Starting availability sync...`, { if (!this.plexClient) {
label: 'AvailabilitySync', return;
}); }
const mediaRepository = getRepository(Media);
const requestRepository = getRepository(MediaRequest);
const seasonRepository = getRepository(Season);
const seasonRequestRepository = getRepository(SeasonRequest);
const pageSize = 50; logger.info(`Starting availability sync...`, {
label: 'AvailabilitySync',
});
const mediaRepository = getRepository(Media);
const requestRepository = getRepository(MediaRequest);
const seasonRepository = getRepository(Season);
const seasonRequestRepository = getRepository(SeasonRequest);
const pageSize = 50;
try {
for await (const media of this.loadAvailableMediaPaginated(pageSize)) { for await (const media of this.loadAvailableMediaPaginated(pageSize)) {
if (!this.running) { if (!this.running) {
throw new Error('Job aborted'); throw new Error('Job aborted');
@ -239,51 +240,60 @@ class AvailabilitySync {
const isTVType = media.mediaType === 'tv'; const isTVType = media.mediaType === 'tv';
const request = await requestRepository.findOne({ try {
relations: { const request = await requestRepository.findOne({
media: true, relations: {
}, media: true,
where: { media: { id: media.id }, is4k: is4k ? true : false }, },
}); where: { media: { id: media.id }, is4k: is4k ? true : false },
});
logger.info(
`Media ID ${media.id} does not exist in your ${is4k ? '4k' : 'non-4k'} ${
isTVType ? 'Sonarr' : 'Radarr'
} and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' }
);
await mediaRepository.update(
media.id,
is4k
? {
status4k: MediaStatus.UNKNOWN,
serviceId4k: null,
externalServiceId4k: null,
externalServiceSlug4k: null,
ratingKey4k: null,
}
: {
status: MediaStatus.UNKNOWN,
serviceId: null,
externalServiceId: null,
externalServiceSlug: null,
ratingKey: null,
}
);
if (isTVType) { logger.info(
const seasonRepository = getRepository(Season); `Media ID ${media.id} does not exist in your ${
is4k ? '4k' : 'non-4k'
} ${
isTVType ? 'Sonarr' : 'Radarr'
} and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' }
);
await seasonRepository?.update( await mediaRepository.update(
{ media: { id: media.id } }, media.id,
is4k is4k
? { status4k: MediaStatus.UNKNOWN } ? {
: { status: MediaStatus.UNKNOWN } status4k: MediaStatus.UNKNOWN,
serviceId4k: null,
externalServiceId4k: null,
externalServiceSlug4k: null,
ratingKey4k: null,
}
: {
status: MediaStatus.UNKNOWN,
serviceId: null,
externalServiceId: null,
externalServiceSlug: null,
ratingKey: null,
}
); );
}
await requestRepository.delete({ id: request?.id }); if (isTVType) {
const seasonRepository = getRepository(Season);
await seasonRepository?.update(
{ media: { id: media.id } },
is4k
? { status4k: MediaStatus.UNKNOWN }
: { status: MediaStatus.UNKNOWN }
);
}
await requestRepository.delete({ id: request?.id });
} catch (ex) {
logger.debug(`Failure updating media ID ${media.id}`, {
errorMessage: ex.message,
label: 'AvailabilitySync',
});
}
} }
private async mediaExistsInRadarr( private async mediaExistsInRadarr(
@ -539,83 +549,90 @@ class AvailabilitySync {
} }
} }
const seasonToBeDeleted = await seasonRequestRepository.findOne({ try {
relations: { const seasonToBeDeleted = await seasonRequestRepository.findOne({
request: { relations: {
media: true, request: {
media: true,
},
}, },
}, where: {
where: { request: {
request: { is4k: seasonExistsInSonarr ? true : false,
is4k: seasonExistsInSonarr ? true : false, media: {
media: { id: media.id,
id: media.id, },
}, },
seasonNumber: season.seasonNumber,
}, },
seasonNumber: season.seasonNumber, });
},
});
// If season does not exist, we will change status to unknown and delete related season request
// If parent media request is empty(all related seasons have been removed), parent is automatically deleted
if (
!seasonExistsInSonarr &&
(seasonExistsInSonarr4k || seasonExistsInPlex4k) &&
!seasonExistsInPlex
) {
if (season.status !== MediaStatus.UNKNOWN) {
logger.info(
`Season ${season.seasonNumber}, media ID ${media.id} does not exist in your non-4k Sonarr and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' }
);
await seasonRepository.update(season.id, {
status: MediaStatus.UNKNOWN,
});
if (seasonToBeDeleted) {
await seasonRequestRepository.remove(seasonToBeDeleted);
}
if (media.status === MediaStatus.AVAILABLE) { // If season does not exist, we will change status to unknown and delete related season request
// If parent media request is empty(all related seasons have been removed), parent is automatically deleted
if (
!seasonExistsInSonarr &&
(seasonExistsInSonarr4k || seasonExistsInPlex4k) &&
!seasonExistsInPlex
) {
if (season.status !== MediaStatus.UNKNOWN) {
logger.info( logger.info(
`Marking media ID ${media.id} as PARTIALLY_AVAILABLE because season removal has occurred.`, `Season ${season.seasonNumber}, media ID ${media.id} does not exist in your non-4k Sonarr and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' } { label: 'AvailabilitySync' }
); );
await mediaRepository.update(media.id, { await seasonRepository.update(season.id, {
status: MediaStatus.PARTIALLY_AVAILABLE, status: MediaStatus.UNKNOWN,
}); });
}
}
}
if ( if (seasonToBeDeleted) {
(seasonExistsInSonarr || seasonExistsInPlex) && await seasonRequestRepository.remove(seasonToBeDeleted);
!seasonExistsInSonarr4k && }
!seasonExistsInPlex4k
) {
if (season.status4k !== MediaStatus.UNKNOWN) {
logger.info(
`Season ${season.seasonNumber}, media ID ${media.id} does not exist in your 4k Sonarr and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' }
);
await seasonRepository.update(season.id, {
status4k: MediaStatus.UNKNOWN,
});
if (seasonToBeDeleted) { if (media.status === MediaStatus.AVAILABLE) {
await seasonRequestRepository.remove(seasonToBeDeleted); logger.info(
`Marking media ID ${media.id} as PARTIALLY_AVAILABLE because season removal has occurred.`,
{ label: 'AvailabilitySync' }
);
await mediaRepository.update(media.id, {
status: MediaStatus.PARTIALLY_AVAILABLE,
});
}
} }
}
if (media.status4k === MediaStatus.AVAILABLE) { if (
(seasonExistsInSonarr || seasonExistsInPlex) &&
!seasonExistsInSonarr4k &&
!seasonExistsInPlex4k
) {
if (season.status4k !== MediaStatus.UNKNOWN) {
logger.info( logger.info(
`Marking media ID ${media.id} as PARTIALLY_AVAILABLE because season removal has occurred.`, `Season ${season.seasonNumber}, media ID ${media.id} does not exist in your 4k Sonarr and Plex instance. Status will be changed to unknown.`,
{ label: 'AvailabilitySync' } { label: 'AvailabilitySync' }
); );
await mediaRepository.update(media.id, { await seasonRepository.update(season.id, {
status4k: MediaStatus.PARTIALLY_AVAILABLE, status4k: MediaStatus.UNKNOWN,
}); });
if (seasonToBeDeleted) {
await seasonRequestRepository.remove(seasonToBeDeleted);
}
if (media.status4k === MediaStatus.AVAILABLE) {
logger.info(
`Marking media ID ${media.id} as PARTIALLY_AVAILABLE because season removal has occurred.`,
{ label: 'AvailabilitySync' }
);
await mediaRepository.update(media.id, {
status4k: MediaStatus.PARTIALLY_AVAILABLE,
});
}
} }
} }
} catch (ex) {
logger.debug(`Failure updating media ID ${media.id}`, {
errorMessage: ex.message,
label: 'AvailabilitySync',
});
} }
if ( if (
@ -654,7 +671,10 @@ class AvailabilitySync {
} }
} catch (ex) { } catch (ex) {
if (!ex.message.includes('response code: 404')) { if (!ex.message.includes('response code: 404')) {
throw ex; logger.debug(`Failed to retrieve plex metadata`, {
errorMessage: ex.message,
label: 'AvailabilitySync',
});
} }
} }
// Base case if both media versions exist in plex // Base case if both media versions exist in plex
@ -714,36 +734,43 @@ class AvailabilitySync {
let seasonExistsInPlex = false; let seasonExistsInPlex = false;
let seasonExistsInPlex4k = false; let seasonExistsInPlex4k = false;
if (ratingKey) { try {
const children = if (ratingKey) {
this.plexSeasonsCache[ratingKey] ?? const children =
(await this.plexClient?.getChildrenMetadata(ratingKey)) ?? this.plexSeasonsCache[ratingKey] ??
[]; (await this.plexClient?.getChildrenMetadata(ratingKey)) ??
this.plexSeasonsCache[ratingKey] = children; [];
const seasonMeta = children?.find( this.plexSeasonsCache[ratingKey] = children;
(child) => child.index === season.seasonNumber const seasonMeta = children?.find(
); (child) => child.index === season.seasonNumber
);
if (seasonMeta) { if (seasonMeta) {
seasonExistsInPlex = true; seasonExistsInPlex = true;
}
} }
} if (ratingKey4k) {
const children4k =
if (ratingKey4k) { this.plexSeasonsCache[ratingKey4k] ??
const children4k = (await this.plexClient?.getChildrenMetadata(ratingKey4k)) ??
this.plexSeasonsCache[ratingKey4k] ?? [];
(await this.plexClient?.getChildrenMetadata(ratingKey4k)) ?? this.plexSeasonsCache[ratingKey4k] = children4k;
[]; const seasonMeta4k = children4k?.find(
this.plexSeasonsCache[ratingKey4k] = children4k; (child) => child.index === season.seasonNumber
const seasonMeta4k = children4k?.find( );
(child) => child.index === season.seasonNumber
);
if (seasonMeta4k) { if (seasonMeta4k) {
seasonExistsInPlex4k = true; seasonExistsInPlex4k = true;
}
}
} catch (ex) {
if (!ex.message.includes('response code: 404')) {
logger.debug(`Failed to retrieve plex's children metadata`, {
errorMessage: ex.message,
label: 'AvailabilitySync',
});
} }
} }
// Base case if both season versions exist in plex // Base case if both season versions exist in plex
if (seasonExistsInPlex && seasonExistsInPlex4k) { if (seasonExistsInPlex && seasonExistsInPlex4k) {
return true; return true;

Write Preview
Loading…
Cancel
Save