feat: discover slider edit arrow buttons for reordering (#3259)

pull/3260/head
Brandon Cohen 2 years ago committed by GitHub
parent d7bfc73727
commit da00d454e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -12,6 +12,8 @@ import { MagnifyingGlassIcon } from '@heroicons/react/24/outline';
import { import {
ArrowUturnLeftIcon, ArrowUturnLeftIcon,
Bars3Icon, Bars3Icon,
ChevronDownIcon,
ChevronUpIcon,
PencilIcon, PencilIcon,
XMarkIcon, XMarkIcon,
} from '@heroicons/react/24/solid'; } from '@heroicons/react/24/solid';
@ -42,9 +44,12 @@ type DiscoverSliderEditProps = {
onDelete: () => void; onDelete: () => void;
onPositionUpdate: ( onPositionUpdate: (
updatedItemId: number, updatedItemId: number,
position: keyof typeof Position position: keyof typeof Position,
isClickable: boolean
) => void; ) => void;
children: React.ReactNode; children: React.ReactNode;
disableUpButton: boolean;
disableDownButton: boolean;
}; };
const DiscoverSliderEdit = ({ const DiscoverSliderEdit = ({
@ -53,6 +58,8 @@ const DiscoverSliderEdit = ({
onEnable, onEnable,
onDelete, onDelete,
onPositionUpdate, onPositionUpdate,
disableUpButton,
disableDownButton,
}: DiscoverSliderEditProps) => { }: DiscoverSliderEditProps) => {
const intl = useIntl(); const intl = useIntl();
const { addToast } = useToasts(); const { addToast } = useToasts();
@ -112,7 +119,7 @@ const DiscoverSliderEdit = ({
); );
if (items?.[0]) { if (items?.[0]) {
const dropped = Number(items[0]); const dropped = Number(items[0]);
onPositionUpdate(dropped, hoverPosition); onPositionUpdate(dropped, hoverPosition, false);
} }
}, },
}); });
@ -271,7 +278,27 @@ const DiscoverSliderEdit = ({
</Button> </Button>
</> </>
)} )}
<div className="absolute top-4 right-4 flex-1 pl-4 text-right md:relative md:top-0 md:right-0"> <div className="absolute right-4 flex px-2 md:relative md:right-0">
<button
className={'hover:text-white disabled:text-gray-800'}
onClick={() =>
onPositionUpdate(Number(slider.id), Position.Above, true)
}
disabled={disableUpButton}
>
<ChevronUpIcon className="h-8 w-8 md:h-6 md:w-8" />
</button>
<button
className={'hover:text-white disabled:text-gray-800'}
onClick={() =>
onPositionUpdate(Number(slider.id), Position.Below, true)
}
disabled={disableDownButton}
>
<ChevronDownIcon className="h-8 w-8 md:h-6 md:w-8" />
</button>
</div>
<div className="absolute top-4 right-4 flex-1 text-right md:relative md:top-0 md:right-0">
<Tooltip content={intl.formatMessage(messages.enable)}> <Tooltip content={intl.formatMessage(messages.enable)}>
<div> <div>
<SlideCheckbox <SlideCheckbox

@ -384,7 +384,7 @@ const Discover = () => {
tempSliders[index].enabled = !tempSliders[index].enabled; tempSliders[index].enabled = !tempSliders[index].enabled;
setSliders(tempSliders); setSliders(tempSliders);
}} }}
onPositionUpdate={(updatedItemId, position) => { onPositionUpdate={(updatedItemId, position, hasClickedArrows) => {
const originalPosition = sliders.findIndex( const originalPosition = sliders.findIndex(
(item) => item.id === updatedItemId (item) => item.id === updatedItemId
); );
@ -393,7 +393,13 @@ const Discover = () => {
const tempSliders = sliders.slice(); const tempSliders = sliders.slice();
tempSliders.splice(originalPosition, 1); tempSliders.splice(originalPosition, 1);
tempSliders.splice( hasClickedArrows
? tempSliders.splice(
position === 'Above' ? index - 1 : index + 1,
0,
originalItem
)
: tempSliders.splice(
position === 'Above' && index > originalPosition position === 'Above' && index > originalPosition
? Math.max(index - 1, 0) ? Math.max(index - 1, 0)
: index, : index,
@ -403,6 +409,8 @@ const Discover = () => {
setSliders(tempSliders); setSliders(tempSliders);
}} }}
disableUpButton={index === 0}
disableDownButton={index === sliders.length - 1}
> >
{sliderComponent} {sliderComponent}
</DiscoverSliderEdit> </DiscoverSliderEdit>

Loading…
Cancel
Save