refactor: Fix several warnings related to .NET 8 updates

Also deleted ConfigurationException since it is unused.

src/Recyclarr.Cli/Cache/CacheException.cs

@@ -1,17 +1,3 @@
-using System.Runtime.Serialization;
-
 namespace Recyclarr.Cli.Cache;
 
-[Serializable]
-public class CacheException : Exception
-{
-    public CacheException(string? message)
-        : base(message)
-    {
-    }
-
-    protected CacheException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
-}
+public class CacheException(string? message) : Exception(message);

src/Recyclarr.Cli/Console/Commands/MigrateCommand.cs

@@ -35,7 +35,7 @@ public class MigrateCommand(
             msg.AppendLine($"Failure Reason:    {e.OriginalException.Message}");
 
             // ReSharper disable once InvertIf
-            if (e.Remediation.Any())
+            if (e.Remediation.Count != 0)
             {
                 msg.AppendLine("\nPossible remediation steps:");
                 foreach (var remedy in e.Remediation)

src/Recyclarr.Cli/Pipelines/MediaNaming/MediaNamingDataLister.cs

@@ -2,7 +2,6 @@ using System.Diagnostics.CodeAnalysis;
 using Recyclarr.Common;
 using Recyclarr.TrashGuide.MediaNaming;
 using Spectre.Console;
-using Spectre.Console.Rendering;
 
 namespace Recyclarr.Cli.Pipelines.MediaNaming;
 
@@ -53,7 +52,7 @@ public class MediaNamingDataLister(
         console.Write(DictionaryToTableSonarr("Anime Episode Format", guideData.Episodes.Anime));
     }
 
-    private static IRenderable DictionaryToTableRadarr(string title, IReadOnlyDictionary<string, string> formats)
+    private static Rows DictionaryToTableRadarr(string title, IReadOnlyDictionary<string, string> formats)
     {
         var table = new Table()
             .AddColumns("Key", "Format");
@@ -73,7 +72,7 @@ public class MediaNamingDataLister(
         return new Rows(Markup.FromInterpolated($"[orange3]{title}[/]"), table);
     }
 
-    private static IRenderable DictionaryToTableSonarr(string title, IReadOnlyDictionary<string, string> formats)
+    private static Rows DictionaryToTableSonarr(string title, IReadOnlyDictionary<string, string> formats)
     {
         var table = new Table()
             .AddColumns("Key", "Sonarr Version", "Format");

src/Recyclarr.Cli/Pipelines/MediaNaming/PipelinePhases/MediaNamingConfigPhase.cs

@@ -31,7 +31,7 @@ public class MediaNamingConfigPhase(IMediaNamingGuideService guide, ISonarrCapab
         return new ProcessedNamingConfig {Dto = dto, InvalidNaming = _errors};
     }
 
-    private MediaNamingDto ProcessRadarrNaming(RadarrConfiguration config)
+    private RadarrMediaNamingDto ProcessRadarrNaming(RadarrConfiguration config)
     {
         var guideData = guide.GetRadarrNamingData();
         var configData = config.MediaNaming;

src/Recyclarr.Cli/Pipelines/MediaNaming/PipelinePhases/MediaNamingPhaseLogger.cs

@@ -7,7 +7,7 @@ public class MediaNamingPhaseLogger(ILogger log)
     // Returning 'true' means to exit. 'false' means to proceed.
     public bool LogConfigPhaseAndExitIfNeeded(ProcessedNamingConfig config)
     {
-        if (config.InvalidNaming.Any())
+        if (config.InvalidNaming.Count != 0)
         {
             foreach (var (topic, invalidValue) in config.InvalidNaming)
             {
@@ -24,7 +24,7 @@ public class MediaNamingPhaseLogger(ILogger log)
             _ => throw new ArgumentException("Unsupported configuration type in LogConfigPhase method")
         };
 
-        if (!differences.Any())
+        if (differences.Count == 0)
         {
             log.Debug("No media naming changes to process");
             return true;
@@ -42,7 +42,7 @@ public class MediaNamingPhaseLogger(ILogger log)
             _ => throw new ArgumentException("Unsupported configuration type in LogPersistenceResults method")
         };
 
-        if (differences.Any())
+        if (differences.Count != 0)
         {
             log.Information("Media naming has been updated");
             log.Debug("Naming differences: {Diff}", differences);

src/Recyclarr.Cli/Pipelines/QualityProfile/PipelinePhases/QualityProfileApiPersistencePhase.cs

@@ -16,7 +16,7 @@ public class QualityProfileApiPersistencePhase(
 
         // Profiles without changes (false) get logged
         var unchangedProfiles = profilesWithStats[false].ToList();
-        if (unchangedProfiles.Any())
+        if (unchangedProfiles.Count != 0)
         {
             log.Debug("These profiles have no changes and will not be persisted: {Profiles}",
                 unchangedProfiles.Select(x => x.Profile.ProfileName));

src/Recyclarr.Cli/Pipelines/QualityProfile/PipelinePhases/QualityProfileConfigPhase.cs

@@ -67,7 +67,7 @@ public class QualityProfileConfigPhase(ILogger log, ProcessedCustomFormatCache c
             .Select(x => (x.Name, x.TrashId))
             .ToList();
 
-        if (!scoreless.Any())
+        if (scoreless.Count == 0)
         {
             return;
         }

src/Recyclarr.Cli/Pipelines/QualityProfile/PipelinePhases/QualityProfileNoticePhase.cs

@@ -38,7 +38,7 @@ public class QualityProfileNoticePhase(ILogger log)
 
         var invalidQualityNames = transactions.UpdatedProfiles
             .Select(x => (x.ProfileName, x.UpdatedQualities.InvalidQualityNames))
-            .Where(x => x.InvalidQualityNames.Any())
+            .Where(x => x.InvalidQualityNames.Count != 0)
             .ToList();
 
         foreach (var (profileName, invalidNames) in invalidQualityNames)
@@ -48,7 +48,7 @@ public class QualityProfileNoticePhase(ILogger log)
         }
 
         var invalidCfExceptNames = transactions.UpdatedProfiles
-            .Where(x => x.InvalidExceptCfNames.Any())
+            .Where(x => x.InvalidExceptCfNames.Count != 0)
             .Select(x => (x.ProfileName, x.InvalidExceptCfNames));
 
         foreach (var (profileName, invalidNames) in invalidCfExceptNames)

src/Recyclarr.Cli/Pipelines/QualityProfile/PipelinePhases/QualityProfilePreviewPhase.cs

@@ -19,7 +19,7 @@ public class QualityProfilePreviewPhase(IAnsiConsole console)
                 new Markup("[b]Profile Updates[/]"),
                 SetupProfileTable(profile)));
 
-            if (profile.ProfileConfig.Profile.Qualities.Any())
+            if (profile.ProfileConfig.Profile.Qualities.Count != 0)
             {
                 profileTree.AddNode(SetupQualityItemTable(profile));
             }
@@ -68,7 +68,7 @@ public class QualityProfilePreviewPhase(IAnsiConsole console)
         static string Null<T>(T? val) => val is null ? "<unset>" : val.ToString() ?? "<invalid>";
     }
 
-    private static IRenderable SetupQualityItemTable(UpdatedQualityProfile profile)
+    private static Rows SetupQualityItemTable(UpdatedQualityProfile profile)
     {
         static IRenderable BuildName(ProfileItemDto item)
         {
@@ -121,7 +121,7 @@ public class QualityProfilePreviewPhase(IAnsiConsole console)
             .Where(x => x.Reason != FormatScoreUpdateReason.NoChange && x.Dto.Score != x.NewScore)
             .ToList();
 
-        if (!updatedScores.Any())
+        if (updatedScores.Count == 0)
         {
             return new Markup("[hotpink]No score changes[/]");
         }

src/Recyclarr.Cli/Pipelines/QualityProfile/PipelinePhases/QualityProfileTransactionPhase.cs

@@ -105,7 +105,7 @@ public class QualityProfileTransactionPhase
         QualityProfileDto profileDto)
     {
         var except = resetConfig.Except;
-        if (!except.Any())
+        if (except.Count == 0)
         {
             return Array.Empty<string>();
         }

src/Recyclarr.Cli/Pipelines/QualityProfile/QualityProfileSyncPipeline.cs

@@ -19,7 +19,7 @@ public class QualityProfileSyncPipeline(ILogger log, IQualityProfilePipelinePhas
     public async Task Execute(ISyncSettings settings, IServiceConfiguration config)
     {
         var guideData = phases.ConfigPhase.Execute(config);
-        if (!guideData.Any())
+        if (guideData.Count == 0)
         {
             log.Debug("No quality profiles to process");
             return;

src/Recyclarr.Cli/Pipelines/ReleaseProfile/Filters/ReleaseProfileDataFilterer.cs

@@ -56,7 +56,7 @@ public class ReleaseProfileDataFilterer(ILogger log)
         ReleaseProfileData selectedProfile,
         SonarrProfileFilterConfig profileFilter)
     {
-        if (profileFilter.Include.Any())
+        if (profileFilter.Include.Count != 0)
         {
             log.Debug("Using inclusion filter");
             return selectedProfile with
@@ -67,7 +67,7 @@ public class ReleaseProfileDataFilterer(ILogger log)
             };
         }
 
-        if (profileFilter.Exclude.Any())
+        if (profileFilter.Exclude.Count != 0)
         {
             log.Debug("Using exclusion filter");
             return selectedProfile with

src/Recyclarr.Cli/Pipelines/ReleaseProfile/PipelinePhases/ReleaseProfileTransactionPhase.cs

@@ -36,7 +36,7 @@ public class ReleaseProfileTransactionPhase(ServiceTagCache tagCache)
         return new ReleaseProfileTransactionData(updated, created, deleted);
     }
 
-    private static IReadOnlyList<SonarrReleaseProfile> DeleteOldManagedProfiles(
+    private static List<SonarrReleaseProfile> DeleteOldManagedProfiles(
         IList<SonarrReleaseProfile> serviceData,
         IReadOnlyList<ProcessedReleaseProfileData> configProfiles)
     {
@@ -60,7 +60,7 @@ public class ReleaseProfileTransactionPhase(ServiceTagCache tagCache)
         profileToUpdate.Required = profile.Profile.Required.Select(x => x.Term).ToList();
         profileToUpdate.IncludePreferredWhenRenaming = profile.Profile.IncludePreferredWhenRenaming;
         profileToUpdate.Tags = profile.Tags
-            .Select(x => tagCache.GetTagIdByName(x))
+            .Select(tagCache.GetTagIdByName)
             .NotNull()
             .ToList();
     }

src/Recyclarr.Cli/Pipelines/ReleaseProfile/ReleaseProfileDataLister.cs

@@ -64,8 +64,8 @@ public class ReleaseProfileDataLister(IAnsiConsole console, IReleaseProfileGuide
 
     private void PrintTerms(IEnumerable<TermData> terms, string category)
     {
-        var filteredTerms = terms.Where(x => x.TrashId.Any()).ToList();
-        if (!filteredTerms.Any())
+        var filteredTerms = terms.Where(x => x.TrashId.Length != 0).ToList();
+        if (filteredTerms.Count == 0)
         {
             return;
         }
@@ -74,7 +74,7 @@ public class ReleaseProfileDataLister(IAnsiConsole console, IReleaseProfileGuide
         foreach (var term in filteredTerms)
         {
             var line = new StringBuilder($"            - {term.TrashId}");
-            if (term.Name.Any())
+            if (term.Name.Length != 0)
             {
                 line.Append($" # {term.Name}");
             }

src/Recyclarr.Cli/Processors/Config/ConfigListLocalProcessor.cs

@@ -27,7 +27,7 @@ public class ConfigListLocalProcessor(
             BuildInstanceTree(rows, configs, SupportedServices.Radarr);
             BuildInstanceTree(rows, configs, SupportedServices.Sonarr);
 
-            if (!rows.Any())
+            if (rows.Count == 0)
             {
                 rows.Add(new Markup("([red]Empty[/])"));
             }
@@ -53,12 +53,12 @@ public class ConfigListLocalProcessor(
     }
 
     private static void BuildInstanceTree(
-        ICollection<IRenderable> rows,
+        List<IRenderable> rows,
         IReadOnlyCollection<IServiceConfiguration> registry,
         SupportedServices service)
     {
         var configs = registry.GetConfigsOfType(service).ToList();
-        if (!configs.Any())
+        if (configs.Count == 0)
         {
             return;
         }

src/Recyclarr.Cli/Processors/Config/ConfigListTemplateProcessor.cs

@@ -36,7 +36,7 @@ public class ConfigListTemplateProcessor(IAnsiConsole console, IConfigTemplateGu
         console.Write(table);
     }
 
-    private static IEnumerable<Markup> RenderTemplates(
+    private static List<Markup> RenderTemplates(
         Table table,
         IEnumerable<TemplatePath> templatePaths,
         SupportedServices service)

src/Recyclarr.Cli/Processors/Config/ConfigManipulator.cs

@@ -18,7 +18,7 @@ public class ConfigManipulator(
     ConfigValidationExecutor validator)
     : IConfigManipulator
 {
-    private static IReadOnlyDictionary<string, TConfig> InvokeCallbackForEach<TConfig>(
+    private static Dictionary<string, TConfig> InvokeCallbackForEach<TConfig>(
         Func<string, ServiceConfigYaml, ServiceConfigYaml> editCallback,
         IReadOnlyDictionary<string, TConfig>? configs)
         where TConfig : ServiceConfigYaml

src/Recyclarr.Cli/Processors/Config/TemplateConfigCreator.cs

@@ -14,7 +14,7 @@ public class TemplateConfigCreator(
 {
     public bool CanHandle(ICreateConfigSettings settings)
     {
-        return settings.Templates.Any();
+        return settings.Templates.Count != 0;
     }
 
     public void Create(ICreateConfigSettings settings)

src/Recyclarr.Cli/Processors/Delete/DeleteCustomFormatsProcessor.cs

@@ -29,7 +29,7 @@ public class DeleteCustomFormatsProcessor(
 
         if (!settings.All)
         {
-            if (!settings.CustomFormatNames.Any())
+            if (settings.CustomFormatNames.Count == 0)
             {
                 throw new CommandException("Custom format names must be specified if the `--all` option is not used.");
             }

src/Recyclarr.Cli/Processors/FatalException.cs

@@ -1,19 +1,3 @@
-using System.Runtime.Serialization;
-using JetBrains.Annotations;
-
 namespace Recyclarr.Cli.Processors;
 
-[Serializable]
-public class FatalException : Exception
-{
-    public FatalException(string? message, Exception? innerException = null)
-        : base(message, innerException)
-    {
-    }
-
-    [UsedImplicitly]
-    protected FatalException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
-}
+public class FatalException(string? message, Exception? innerException = null) : Exception(message, innerException);

src/Recyclarr.Common/Extensions/CollectionExtensions.cs

@@ -7,11 +7,7 @@ public static class CollectionExtensions
     // From: https://stackoverflow.com/a/34362585/157971
     public static IReadOnlyCollection<T> AsReadOnly<T>(this ICollection<T> source)
     {
-        if (source is null)
-        {
-            throw new ArgumentNullException(nameof(source));
-        }
-
+        ArgumentNullException.ThrowIfNull(source);
         return source as IReadOnlyCollection<T> ?? new ReadOnlyCollectionAdapter<T>(source);
     }
 
@@ -75,7 +71,7 @@ public static class CollectionExtensions
     public static IList<T>? ToListOrNull<T>(this IEnumerable<T> source)
     {
         var list = source.ToList();
-        return list.Any() ? list : null;
+        return list.Count != 0 ? list : null;
     }
 
     public static IEnumerable<T> Flatten<T>(this IEnumerable<T> items, Func<T, IEnumerable<T>> flattenWhich)

src/Recyclarr.Common/FluentValidation/RuntimeValidationService.cs

@@ -29,7 +29,7 @@ public class RuntimeValidationService : IRuntimeValidationService
             throw new ValidationException($"No validator is available for type: {instance.GetType().FullName}");
         }
 
-        IValidatorSelector validatorSelector = ruleSets.Any()
+        IValidatorSelector validatorSelector = ruleSets.Length != 0
             ? new RulesetValidatorSelector(ruleSets)
             : new DefaultValidatorSelector();
 

src/Recyclarr.Common/ResourceDataReader.cs

@@ -9,7 +9,8 @@ public class ResourceDataReader(Assembly assembly, string subdirectory = "") : I
 
     public ResourceDataReader(Type typeWithNamespaceToUse, string subdirectory = "")
         : this(Assembly.GetAssembly(typeWithNamespaceToUse)
-            ?? throw new ArgumentException("Cannot get assembly from type", nameof(typeWithNamespaceToUse)), subdirectory)
+            ?? throw new ArgumentException("Cannot get assembly from type", nameof(typeWithNamespaceToUse)),
+            subdirectory)
     {
         _namespace = typeWithNamespaceToUse.Namespace;
     }

src/Recyclarr.Config/ConfigExtensions.cs

@@ -44,7 +44,7 @@ public static class ConfigExtensions
         this IEnumerable<IServiceConfiguration> configs,
         ConfigFilterCriteria criteria)
     {
-        if (criteria.Instances is null || !criteria.Instances.Any())
+        if (criteria.Instances is null || criteria.Instances.Count == 0)
         {
             return Array.Empty<string>();
         }

src/Recyclarr.Config/ConfigurationRegistry.cs

@@ -14,14 +14,14 @@ public class ConfigurationRegistry(IConfigurationLoader loader, IConfigurationFi
         filterCriteria ??= new ConfigFilterCriteria();
 
         var manualConfigs = filterCriteria.ManualConfigFiles;
-        var configs = manualConfigs is not null && manualConfigs.Any()
+        var configs = manualConfigs is not null && manualConfigs.Count != 0
             ? PrepareManualConfigs(manualConfigs)
             : finder.GetConfigFiles();
 
         return LoadAndFilterConfigs(configs, filterCriteria).ToList();
     }
 
-    private IReadOnlyCollection<IFileInfo> PrepareManualConfigs(IEnumerable<string> manualConfigs)
+    private List<IFileInfo> PrepareManualConfigs(IEnumerable<string> manualConfigs)
     {
         var configFiles = manualConfigs
             .Select(x => fs.FileInfo.New(x))
@@ -42,19 +42,19 @@ public class ConfigurationRegistry(IConfigurationLoader loader, IConfigurationFi
         var loadedConfigs = configs.SelectMany(x => loader.Load(x)).ToList();
 
         var dupeInstances = loadedConfigs.GetDuplicateInstanceNames().ToList();
-        if (dupeInstances.Any())
+        if (dupeInstances.Count != 0)
         {
             throw new DuplicateInstancesException(dupeInstances);
         }
 
         var invalidInstances = loadedConfigs.GetInvalidInstanceNames(filterCriteria).ToList();
-        if (invalidInstances.Any())
+        if (invalidInstances.Count != 0)
         {
             throw new InvalidInstancesException(invalidInstances);
         }
 
         var splitInstances = loadedConfigs.GetSplitInstances().ToList();
-        if (splitInstances.Any())
+        if (splitInstances.Count != 0)
         {
             throw new SplitInstancesException(splitInstances);
         }

src/Recyclarr.Config/Parsing/ConfigurationFinder.cs

@@ -7,7 +7,7 @@ namespace Recyclarr.Config.Parsing;
 
 public class ConfigurationFinder(IAppPaths paths) : IConfigurationFinder
 {
-    private IReadOnlyCollection<IFileInfo> FindDefaultConfigFiles()
+    private List<IFileInfo> FindDefaultConfigFiles()
     {
         var configs = new List<IFileInfo>();
 

src/Recyclarr.Config/Parsing/ErrorHandling/ConfigurationException.cs

@@ -1,56 +0,0 @@
-using System.Runtime.Serialization;
-using System.Text;
-using FluentValidation.Results;
-
-namespace Recyclarr.Config.Parsing.ErrorHandling;
-
-[Serializable]
-public class ConfigurationException : Exception
-{
-    protected ConfigurationException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
-
-    private ConfigurationException(string propertyName, Type deserializableType, IEnumerable<string> messages)
-    {
-        PropertyName = propertyName;
-        DeserializableType = deserializableType;
-        ErrorMessages = messages.ToList();
-    }
-
-    public ConfigurationException(string propertyName, Type deserializableType, string message)
-        : this(propertyName, deserializableType, new[] {message})
-    {
-    }
-
-    public ConfigurationException(
-        string propertyName,
-        Type deserializableType,
-        IEnumerable<ValidationFailure> validationFailures)
-        : this(propertyName, deserializableType, validationFailures.Select(e => e.ToString()))
-    {
-    }
-
-    public IReadOnlyCollection<string> ErrorMessages { get; } = new List<string>();
-    public string PropertyName { get; } = "";
-    public Type DeserializableType { get; } = default!;
-
-    public override string Message => BuildMessage();
-
-    private string BuildMessage()
-    {
-        const string delim = "\n   - ";
-        var builder = new StringBuilder(
-            $"An exception occurred while deserializing type '{DeserializableType}' for YML property '{PropertyName}'");
-
-        // ReSharper disable once InvertIf
-        if (ErrorMessages.Count > 0)
-        {
-            builder.Append(":" + delim);
-            builder.Append(string.Join(delim, ErrorMessages));
-        }
-
-        return builder.ToString();
-    }
-}

src/Recyclarr.Config/Parsing/ErrorHandling/FeatureRemovalException.cs

@@ -1,17 +1,3 @@
-using System.Runtime.Serialization;
-
 namespace Recyclarr.Config.Parsing.ErrorHandling;
 
-[Serializable]
-public class FeatureRemovalException : Exception
-{
-    protected FeatureRemovalException(SerializationInfo info, StreamingContext context)
-        : base(info, context)
-    {
-    }
-
-    public FeatureRemovalException(string message, string docLink)
-        : base($"{message} See: {docLink}")
-    {
-    }
-}
+public class FeatureRemovalException(string message, string docLink) : Exception($"{message} See: {docLink}");

src/Recyclarr.Config/Parsing/PostProcessing/ImplicitUrlAndKeyPostProcessor.cs

@@ -13,7 +13,7 @@ public class ImplicitUrlAndKeyPostProcessor(ILogger log, ISecretsProvider secret
         };
     }
 
-    private IReadOnlyDictionary<string, T>? ProcessService<T>(IReadOnlyDictionary<string, T>? services)
+    private Dictionary<string, T>? ProcessService<T>(IReadOnlyDictionary<string, T>? services)
         where T : ServiceConfigYaml
     {
         return services?.ToDictionary(x => x.Key, x => FillUrlAndKey(x.Key, x.Value));

src/Recyclarr.Config/Parsing/PostProcessing/IncludePostProcessor.cs

@@ -21,7 +21,7 @@ public class IncludePostProcessor(
         };
     }
 
-    private IReadOnlyDictionary<string, T>? ProcessIncludes<T>(
+    private Dictionary<string, T>? ProcessIncludes<T>(
         IReadOnlyDictionary<string, T>? configs,
         ServiceConfigMerger<T> merger,
         SupportedServices serviceType)

src/Recyclarr.TrashGuide/ConfigTemplateGuideService.cs

@@ -39,7 +39,7 @@ public class ConfigTemplateGuideService(IConfigTemplatesRepo repo) : IConfigTemp
         return _includeData ??= LoadTemplateData("includes.json");
     }
 
-    private IReadOnlyCollection<TemplatePath> LoadTemplateData(string templateFileName)
+    private List<TemplatePath> LoadTemplateData(string templateFileName)
     {
         var templatesPath = repo.Path.File(templateFileName);
         if (!templatesPath.Exists)

src/Recyclarr.TrashGuide/CustomFormat/CustomFormatCategoryParser.cs

@@ -50,17 +50,17 @@ public partial class CustomFormatCategoryParser : ICustomFormatCategoryParser
                 break;
             }
 
-            if (line.Any())
+            if (line.Length != 0)
             {
                 var fields = GetTableRow(line);
-                if (fields.Any())
+                if (fields.Count != 0)
                 {
                     tableRows.Add(fields);
                     continue;
                 }
             }
 
-            if (tableRows.Any())
+            if (tableRows.Count != 0)
             {
                 break;
             }

src/Recyclarr.TrashGuide/CustomFormat/CustomFormatLoader.cs

@@ -5,6 +5,7 @@ using Recyclarr.Json.Loading;
 
 namespace Recyclarr.TrashGuide.CustomFormat;
 
+// ReSharper disable once SuggestBaseTypeForParameterInConstructor
 public class CustomFormatLoader(ServiceJsonLoader loader, ICustomFormatCategoryParser categoryParser, IFileSystem fs)
     : ICustomFormatLoader
 {

src/Recyclarr.TrashGuide/MediaNaming/MediaNamingGuideService.cs

@@ -19,7 +19,7 @@ public class MediaNamingGuideService(IRepoMetadataBuilder metadataBuilder, Guide
         };
     }
 
-    private static IReadOnlyDictionary<string, string> JoinDictionaries(
+    private static Dictionary<string, string> JoinDictionaries(
         IEnumerable<IReadOnlyDictionary<string, string>> dictionaries)
     {
         return dictionaries

src/Recyclarr.TrashGuide/ReleaseProfile/ReleaseProfileDataValidator.cs

@@ -26,7 +26,7 @@ public class ReleaseProfileDataValidator : AbstractValidator<ReleaseProfileData>
         RuleFor(x => x.Name).NotEmpty();
         RuleFor(x => x.TrashId).NotEmpty();
         RuleFor(x => x)
-            .Must(x => x.Required.Any() || x.Ignored.Any() || x.Preferred.Any())
+            .Must(x => x.Required.Count != 0 || x.Ignored.Count != 0 || x.Preferred.Count != 0)
             .WithMessage("Must have at least one of Required, Ignored, or Preferred terms");
     }
 }

src/Recyclarr.Yaml/YamlDotNet/CannotBeEmptyAttribute.cs

@@ -1,5 +1,6 @@
 using System.Collections;
 using System.ComponentModel.DataAnnotations;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Recyclarr.Yaml.YamlDotNet;
 
@@ -7,6 +8,7 @@ namespace Recyclarr.Yaml.YamlDotNet;
 // ReSharper disable once UnusedType.Global
 public sealed class CannotBeEmptyAttribute : RequiredAttribute
 {
+    [SuppressMessage("ReSharper", "NotDisposedResource")]
     public override bool IsValid(object? value)
     {
         return base.IsValid(value) &&

src/Recyclarr.Yaml/YamlDotNet/ReadOnlyCollectionNodeTypeResolver.cs

@@ -19,11 +19,10 @@ public sealed class ReadOnlyCollectionNodeTypeResolver : INodeTypeResolver
         return true;
     }
 
-    private static readonly IReadOnlyDictionary<Type, Type> CustomGenericInterfaceImplementations =
-        new Dictionary<Type, Type>
-        {
-            {typeof(IReadOnlyCollection<>), typeof(List<>)},
-            {typeof(IReadOnlyList<>), typeof(List<>)},
-            {typeof(IReadOnlyDictionary<,>), typeof(Dictionary<,>)}
-        };
+    private static readonly Dictionary<Type, Type> CustomGenericInterfaceImplementations = new()
+    {
+        {typeof(IReadOnlyCollection<>), typeof(List<>)},
+        {typeof(IReadOnlyList<>), typeof(List<>)},
+        {typeof(IReadOnlyDictionary<,>), typeof(Dictionary<,>)}
+    };
 }

src/tests/Recyclarr.TestLibrary/AutoFixture/CustomizeWithAttribute.cs

@@ -11,10 +11,7 @@ public sealed class CustomizeWithAttribute : CustomizeAttribute
 
     public CustomizeWithAttribute(Type customizationType)
     {
-        if (customizationType == null)
-        {
-            throw new ArgumentNullException(nameof(customizationType));
-        }
+        ArgumentNullException.ThrowIfNull(customizationType);
 
         if (!typeof(ICustomization).IsAssignableFrom(customizationType))
         {

src/tests/Recyclarr.TestLibrary/FluentAssertions/FluentAssertionsExtensions.cs

@@ -20,7 +20,7 @@ public static class FluentAssertionsExtensions
             {
                 using var scope = new AssertionScope();
                 item.Should().MatchRegex(regexPattern);
-                return !scope.Discard().Any();
+                return scope.Discard().Length == 0;
             });
         }
 
@@ -34,7 +34,7 @@ public static class FluentAssertionsExtensions
         {
             using var scope = new AssertionScope();
             item.Should().MatchRegex(regexPattern);
-            return !scope.Discard().Any();
+            return scope.Discard().Length == 0;
         });
 
         return new AndWhichConstraint<TAssertions, string>((TAssertions) assert, matched);
@@ -55,7 +55,7 @@ public static class FluentAssertionsExtensions
             {
                 using var scope = new AssertionScope();
                 item.Should().NotMatchRegex(regexPattern);
-                return !scope.Discard().Any();
+                return scope.Discard().Length == 0;
             });
         }
 
@@ -69,7 +69,7 @@ public static class FluentAssertionsExtensions
         {
             using var scope = new AssertionScope();
             item.Should().NotMatchRegex(regexPattern);
-            return !scope.Discard().Any();
+            return scope.Discard().Length == 0;
         });
 
         return new AndWhichConstraint<TAssertions, string>((TAssertions) assert, matched);