Downgrade the artifact upload/download actions to v3 since none of the
v4 versions seem to address the "Not a valid zip file" issue.
Modified the codesign job to additionally run on PRs, so that when
Renovate upgrades the upload/download artifacts, we can tell from the PR
if the ZIP file issue is fixed.
For more info, see:
- https://github.com/actions/download-artifact/issues/328
- https://github.com/docker/build-push-action/issues/1167
This was removed by mistake a while back, because the docker build no
longer used the MUSL artifacts. However we still need those artifacts to
attach to github releases, so its removal was an oversight.
Configure SonarCloud to use the latest git tag as the version identifier
instead of the current commit. This ensures that SonarCloud considers
all code changes since the last tagged release, aligning with our setup
to track new code issues from the most recent release.
The `-dev.` docker tags create a lot of noise and cloud out the actual
non-prerelease versions in the tag listings on Docker Hub and GHCR.
Additionally, there's no built-in retention policies in these registries
and manual attempts to clean up old dev images are difficult.
Users that are interested in immutable tags can pin the `edge` tag to a
digest.
For easier integration into docker buildx, Recyclarr is now built inside
of the Dockerfile as a dedicated build stage. This simplified the CI
workflows and local testing a bit.
The changes for this new process were driven by Microsoft's recommended
approach to building .NET applications inside Docker, which is
documented here:
https://github.com/dotnet/dotnet-docker/blob/main/samples/README.md
Use the fork again until the upstream starts merging pull requests. It
is out of date with its forks. The main motivation for this change is to
get off the now deprecated Node v16.
The Apple Signing step grabs an existing artifact, signs the binaries,
and then re-uploads the artifact, replacing the original one. The
upgrade to v4 of the `actions/upload-artifact` action broke this
behavior due to a breaking change documented in [the release notes][1]:
> Due to how Artifacts are created in this new version, it is no longer
> possible to upload to the same named Artifact multiple times. You must
> either split the uploads into multiple Artifacts with different names,
> or only upload once. Otherwise you will encounter an error.
The fix is to use the `overwrite: true` setting to force the old
behavior of replacing the previous (unsigned) artifact.
[1]: https://github.com/actions/upload-artifact/blob/main/README.md#breaking-changes
- Remove schemas because there doesn't seem to be any jobs that operate
on these files. I don't remember the reason that it was added in the
first place; but can deal with that later if I notice something wrong.
- Add props/targets files so that we rebuild when we update package
versions, etc.
- Use `sonar.token` instead of `sonar.login` since the latter is
deprecated.
- Explicitly install Java 17 since v11 (bundled by default) is
deprecated by Sonarcloud.
Caching was not implemented this time around because it's not possible
to cache analysis results yet, only the installed binaries. See this
thread for information:
https://community.sonarsource.com/t/proper-caching-for-ci-builds/98320/2
Robert Dailey
renovate[bot]