cleanup, fixed handling connection error exception

sherlock.py

@@ -1,18 +1,12 @@
-import requests
-import json
 import os
+import json
+import requests
 
 # TODO: fix tumblr
 
-def write_to_file(url, fname):
+def print_banner():
-	with open(fname, "a") as f:
+    print("                                              .\"\"\"-.")
-		f.write(url+"\n")
+    print("                                             /      \\")
-
-
-def main():
-    # Not sure why, but the banner messes up if i put into one print function
-    print("\033[37;1m                                              .\"\"\"-.")
-    print("\033[37;1m                                             /      \\")
     print("\033[37;1m ____  _               _            _        |  _..--'-.")
     print("\033[37;1m/ ___|| |__   ___ _ __| | ___   ___| |__    >.`__.-\"\"\;\"`")
     print("\033[37;1m\___ \| '_ \ / _ \ '__| |/ _ \ / __| |/ /   / /(     ^\\")
@@ -21,67 +15,80 @@ def main():
     print("\033[37;1m                                           .'`-._ `.\    | J /")
     print("\033[37;1m                                          /      `--.|   \__/\033[0m")
 
-    username = input("\033[92;1m[\033[37;1m?\033[92;1m]\033[92;1m Input Username: \033[0m")
+def search_accounts(username, social_networks_params):
-    print()
+    existing_accounts = list()
-
-    fname = username+".txt"
-
-    if os.path.isfile(fname):
-    	os.remove(fname)
-    	print("\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Removing previous file:\033[1;37m {}\033[0m".format(fname))
-
 
-    print("\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Checking username\033[0m\033[1;37m {}\033[0m\033[1;92m on: \033[0m".format(username))
-    raw = open("data.json", "r", encoding="utf-8")
-    data = json.load(raw)
-
-    # User agent is needed because some sites does not 
-    # return the correct information because it thinks that
-    # we are bot
     headers = {
         'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0'
     }
 
-    for social_network in data:
+    for social_network in social_networks_params:
-        url = data.get(social_network).get("url").format(username)
+        url = social_networks_params.get(social_network).get("url").format(username)
-        error_type = data.get(social_network).get("errorType")
+        error_type = social_networks_params.get(social_network).get("errorType")
-
+        try:
-        cant_have_period = data.get(social_network).get("noPeriod")
+            response = requests.get(url, headers=headers)
-
+        except Exception as e:
-        if cant_have_period == "True":
+            print(f"error connecting to {url}: {e}")
-            print("\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {}:\033[93;1m Not Found!".format(social_network))
             continue
 
-        r = requests.get(url, headers=headers)
-    
         if error_type == "message":
-            error = data.get(social_network).get("errorMsg")
+            error = social_networks_params.get(social_network).get("errorMsg")
-            # Checks if the error message is in the HTML
+            if error in response.text:
-            if not error in r.text:
+                print(f"\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {social_network}:\033[93;1m Not Found!")
-                print("\033[37;1m[\033[92;1m+\033[37;1m]\033[92;1m {}:\033[0m".format(social_network), url)
+                continue
-                write_to_file(url, fname)                	
+
-            
-            else:
-            	print("\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {}:\033[93;1m Not Found!".format(social_network))
-            
         elif error_type == "status_code":
-            # Checks if the status code of the repsonse is 404
+            if response.status_code == 404:
-            if not r.status_code == 404:
+                print(f"\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {social_network}:\033[93;1m Not Found!")
-                print("\033[37;1m[\033[92;1m+\033[37;1m]\033[92;1m {}:\033[0m".format(social_network), url)
+                continue
-                write_to_file(url, fname)
-            
-            else:
-            	print("\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {}:\033[93;1m Not Found!".format(social_network))
 
         elif error_type == "response_url":
-            error = data.get(social_network).get("errorUrl")
+            error = social_networks_params.get(social_network).get("errorUrl")
-            # Checks if the redirect url is the same as the one defined in data.json
+            if error in response.url:
-            if not error in r.url:
+                print(f"\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {social_network}:\033[93;1m Not Found!")
-                print("\033[37;1m[\033[92;1m+\033[37;1m]\033[92;1m {}:\033[0m".format(social_network), url)
+                continue
-                write_to_file(url, fname)
+
-            else:
+        print(f"\033[37;1m[\033[92;1m+\033[37;1m]\033[92;1m {social_network}:\033[0m", url)
-            	print("\033[37;1m[\033[91;1m-\033[37;1m]\033[92;1m {}:\033[93;1m Not Found!".format(social_network))
+        existing_accounts.append(url)
-
+
-    print("\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Saved: \033[37;1m{}\033[0m".format(username+".txt"))
+    return existing_accounts
-        	
+
-main()
+def save_account_urls(account_urls, filename):
+    with open(filename, "a") as file:
+        file.writelines(account_urls)
+
+def remove_old_file(filename):
+    if os.path.isfile(filename):
+        os.remove(filename)
+        print(f"\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Removing previous file:\033[1;37m {filename}\033[0m")
+
+def get_social_networks_params():
+    with open("data.json", "r") as file:
+        social_networks_params = json.load(file)
+    return social_networks_params
+
+def main():
+    print_banner()
+    username = input("\033[92;1m[\033[37;1m?\033[92;1m]\033[92;1m Input Username: \033[0m")
+    print()
+
+    filename = f"{username}.txt"
+    remove_old_file(filename)
+
+    social_networks_params = get_social_networks_params()
+    if social_networks_params is None:
+        print("Error loading social networks parameters. Exiting.")
+        return
+
+    print(f"\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Checking username\033[0m\033[1;37m {username}\033[0m\033[1;92m on: \033[0m")
+
+    existing_accounts = search_accounts(username, social_networks_params)
+    if len(existing_accounts) == 0:
+        print("No accounts found. Exiting without saving.")
+        return
+
+    save_account_urls(existing_accounts, filename)
+    print(f"\033[1;92m[\033[0m\033[1;77m*\033[0m\033[1;92m] Saved: \033[37;1m{filename}\033[0m")
+
+if '__main__' in __name__:
+    main()