Fix WebSocket disconnecting when exception is thrown during processing (#11395)

4 weeks ago · 43569082f9
parent e42325883f
commit 43569082f9
1 changed files with 14 additions and 7 deletions
--- a/Emby.Server.Implementations/HttpServer/WebSocketConnection.cs
+++ b/Emby.Server.Implementations/HttpServer/WebSocketConnection.cs
@ -198,6 +198,8 @@ namespace Emby.Server.Implementations.HttpServer
                await SendKeepAliveResponse().ConfigureAwait(false);
            }
            else
+            {
+                try
                {
                    await OnReceive(
                        new WebSocketMessageInfo
@ -207,6 +209,11 @@ namespace Emby.Server.Implementations.HttpServer
                            Connection = this
                        }).ConfigureAwait(false);
                }
+                catch (Exception exception)
+                {
+                    _logger.LogWarning(exception, "Failed to process WebSocket message");
+                }
+            }
        }

        internal InboundWebSocketMessage<object>? DeserializeWebSocketMessage(ReadOnlySequence<byte> bytes, out long bytesConsumed)