025e351f61
add unit tests
4 years ago
ab0cff8556
do not resolve episode-like files if they are in extras folders
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
5241bd41ef
Add code analysis attributes where appropriate
4 years ago
82d88bdec6
Merge pull request #5409 from ikomhoog/master
4 years ago
90cdd1345d
Merge pull request #5407 from Bond-009/hack
4 years ago
54f81c4da4
Call ToLower on CollectionTypeOptions.ToString
4 years ago
d4201f812c
Changed string.Length == 0 to string.IsNullOrEmpty in case of null
4 years ago
946411be8e
Remove redundant check
4 years ago
67af30d1ff
Remove redundant checks
4 years ago
54211b921c
rider is a prick
4 years ago
bc661c16e1
simplify
4 years ago
37e374d33d
make sure network path substitution matches correctly
4 years ago
81f527f808
CollectionType can be null
4 years ago
1c74e2f40e
Fix build
4 years ago
914e891689
Fix unchecked input
4 years ago
9fcdbd4c4b
remove deprecated settings from server config
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
4549c96f6d
Merge pull request #4906 from Spacetech/library_scan_ignore_inaccessible
...
Ignore inaccessible files & folders during library scans
4 years ago
0f4bbbc63c
Fix 3169 and 2879 by making MusicArtistResolver run ahead of MusicAlbumResolver
4 years ago
1fdeac0a7d
Ignore inaccessible files during library scans
4 years ago
7caba04c3c
Merge pull request #4890 from nielsvanvelzen/4888-fix-search-hints
...
Fix search hint endpoint error
4 years ago
f411353c8c
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
c7cb177260
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
77b478c726
Update Emby.Server.Implementations/Library/UserDataManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
99adbf0497
Split resume function for Audiobooks
4 years ago
2bb84c0675
Fix limit parameter error for search hints endpoint
4 years ago
043d045448
Put json serializer options in private field
4 years ago
a714008b59
Add missing FileStreams
4 years ago
2a574914ea
Use streams instead of strings
4 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
21d2e9ff0c
Merge pull request #4771 from crobibero/typed-get-preference
...
Use typed UserManager GetPreference
4 years ago
ee23d06154
Use a more descriptive function name
4 years ago
297cb27ab6
remove opf extension for book types
4 years ago
b670937c3d
Use typed UserManager GetPreference
4 years ago
3f6e6c4839
Simplify
4 years ago
3c5bbeb80c
Remove ImageFetcherPostScanTask
4 years ago
020fe37dfe
fix custom library order
4 years ago
b5a7a74e89
Use GetParentItem where applicable
4 years ago
2055d49701
fix inverted condition
4 years ago
c083b29e29
Use Guid as API parameter type where possible
4 years ago
969b9e2a18
Update ImageFetcherPostScanTask.cs
4 years ago
bf54b5579c
Merge branch 'master' into defer_image_fetching
4 years ago
7457c4a95d
Merge pull request #4499 from crobibero/more-param
...
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids
4 years ago
e51ddd326c
Fixes spelling.
4 years ago
3cc0dd7e12
Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.
4 years ago
2bbfcc264d
Merge branch 'master' into emby-namig-nullable
4 years ago
e66d79fc0c
Merge remote-tracking branch 'upstream/master' into http-exception
4 years ago
95a2de757f
remove custom HttpException
4 years ago
ff49a3bb61
Missed some stuff
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
c0747512d6
Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable
4 years ago
584b4fa41f
Fix Persons, Genres and Studios endpoints
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
60b49e67ea
Re-Sharper inspection issues
4 years ago
59619b6ea7
Enable nullable in Emby.Naming
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
d54de29485
Merge pull request #4315 from Jan-PieterBaert/fix-warnings
...
Fix some warnings
4 years ago
8b419d9ea6
Merge pull request #4199 from ryanpetris/livetv-locking
...
Fix stream performance when opening/closing new streams.
4 years ago
ec91d3893d
Fix SA 1116 warnings
4 years ago
4a81ee43dc
Add try-catch to avoid crashing the whole thing
4 years ago
1b18f86c8b
Add missing parameter comments.
4 years ago
5d3449e9dc
Fix xml doc comment
4 years ago
763862cbd8
Defer image pre-fetching until the end of a refresh/scan
4 years ago
3cfbe6e340
better audio file check
4 years ago
75041e7f39
interlocked increment
4 years ago
05fa95f149
Increase scan speed for music libraries
4 years ago
4db5700e18
Don't take a lock if there's no intention to manipulate the list of open streams. Instead, use a ConcurrentDictionary so that, in those situations, thread-safe access to the dictionary is ensured.
4 years ago
edbd4e0db6
Remove extra return statement
4 years ago
441301069e
Fix
4 years ago
48e1cf9fd7
Minor performance improvements to item saving
4 years ago
119f64f5e7
Make some methods async
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
0cf75992a8
Use MemoryCache.Set since SetValue does not flush to cache automatically.
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
e0d2eb8eec
remove useless order step for intros
4 years ago
e5c6eec642
Use MemoryCache in LibraryManager
4 years ago
d7287a05ad
Merge pull request #3684 from Bond-009/warn22
...
Fix warnings
4 years ago
9314a4fcc9
.
4 years ago
7fa80ac3e0
Add more tests, update comment
4 years ago
de708d2fca
Comment
4 years ago
800260af43
Yep. I failed at copy-pasting.
4 years ago
11d5410dbb
Don't ignore dot directories.
...
Use `.ignore` file to hide directory from library scan.
Also, please tell me we handle sample matching somewhere else? This is a mess.
4 years ago
01e781035f
Fix warnings
4 years ago
3ff110984a
Merge branch 'master' into readonlyspan
4 years ago
0aa349fe40
Remove unused dependencies.
4 years ago
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
0d446c8755
Merge pull request #3609 from Bond-009/warn21
...
Fix warnings
4 years ago
e973757485
Simplify logic
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
2fa2952791
Skip image processing for live tv sources
4 years ago
7324b44c43
Fix warnings
4 years ago
b53bf2cd16
Remove obsolete network path code
4 years ago
e152a6c82f
Increase delete logging
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
cb193b6afd
Add support for ReadOnlySpan<char> in IgnorePatterns
4 years ago
9772749d8f
Add more ignorepatterns and tests
4 years ago
bb7444db07
Merge pull request #3439 from cvium/ignore_application_folders
...
Never ignore application folders
4 years ago
9eba11379a
catch skia errors when getting image dimensions
4 years ago
0f07b19ca5
Remove AllowIgnorePath
4 years ago
9dee1eef83
Never ignore application folders
4 years ago
f75024fade
Fix scan crashed
4 years ago
7f307f9082
brace multiline if statements
4 years ago
8de6452967
fix some documentation periods
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
4 years ago
fc02157b42
Fix build errors
4 years ago
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
4 years ago
ad5c41b542
Merge pull request #3258 from aled/2149-fix-a-small-number-of-compile-warnings-1
...
Fix a small number of compile warnings
4 years ago
7ed5cf3dca
Force configuration paths to not be ignored.
4 years ago
22a860a806
Fix a small number of compile warnings
4 years ago
613748b45d
Make books resumable and have duration of 1 second
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
2dbb9d4895
Fix build
5 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
5 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
5 years ago
b9618c8c01
Merge pull request #2676 from GranPC/public-pr/blurhash
...
Implement Blurhash generation for images
5 years ago
26eef1bbf8
Move logic of computing Blurhash components to ImageProcessor
...
Also rename last few instances of GetImageHash to GetImageBlurHash for clarity
5 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
5 years ago
9208acd5ae
Convert non-local image to local before computing blurhash
5 years ago
ed791dee46
Do not compute dimensions or blurhash for remote images
5 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
edcfcadcd3
Make sure blurhash is recomputed if image changed or metadata refresh toggled
5 years ago
6c9dc04189
Handle errors during blurhash generation so it does not fail the scan
5 years ago
eef7cfd912
Make SonarCloud less angry
5 years ago
01ce56016a
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
# MediaBrowser.Api/UserService.cs
# MediaBrowser.Controller/Library/IUserManager.cs
5 years ago
0be3dfe7c5
Revert "Fix emby/user/public API leaking sensitive data"
5 years ago
29443e3681
Apply suggestions from code review
...
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
5 years ago
1f83a21288
Rename Hash to BlurHash in all properties and methods for clarity
5 years ago
8b517e9bef
Fix nullref for imageProcessor in LibraryManager
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
0efb81b21e
Add lost+found to ignore list
...
https://forum.jellyfin.org/t/library-not-loading/2086
5 years ago
186b7f303c
More small optimizations
5 years ago
a226a4ee03
Compute hash only when one is not computed in DB, small optimizations here and there
5 years ago
bfb644d5f5
Fix nullref exception
5 years ago
02da312f8a
Fix compilation after rebase
5 years ago
fe480caf54
Add endpoint to update all items in library
5 years ago
b9fc0d2628
Add BlurHash support to backend
5 years ago
2d2c1d9473
Merge pull request #3099 from rigtorp/ignore-patterns
...
Use glob patterns to ignore files
5 years ago
f144acdc96
Use glob patterns to ignore files
5 years ago
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
5 years ago
4eb4ad3be7
Update Books Resolver File Types
5 years ago
9ad839c776
Initial migration code
5 years ago
62420a6eb1
Remove support for injecting ILogger directly
5 years ago
62da4d0e5c
Merge pull request #2492 from Polpetta/fix-api-private-data-leak
...
Fix emby/user/public API leaking sensitive data
5 years ago
57cf19f058
Fix variable declaration and follow sonarcloud suggestions
5 years ago
472efeeec4
Remove extra line in UserManager
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
5 years ago
5922c35d69
Merge pull request #2920 from Bond-009/tests2
...
Add some simple tests
5 years ago
97d7ffc458
Merge pull request #2861 from mark-monteiro/fix-auth-response-codes
...
Fix Auth Response Codes
5 years ago
07326c1d9b
Merge branch 'master' into fix-auth-response-codes
5 years ago
c430a7ed8f
Address comments
5 years ago
bc4e72b29b
Create ApplicationHost logger correctly
5 years ago
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
5 years ago
7f4a229cd2
Add some simple tests
5 years ago
d30fd3b3d2
Changed '\d' to '[0-9]'.
5 years ago
92f273cb0c
Limit imdbid to 8 digits.
5 years ago
d7a71cee3c
Fix imdbid regex
5 years ago
e1fb24c9ee
Merge pull request #2830 from Bond-009/dvdlib
...
DvdLib: remove dependency on MediaBrowser.Model
5 years ago
bcf53b3226
Merge pull request #2746 from dafo90/master
...
Authentication request log with IP
5 years ago
fc049caba2
Merge branch 'master' into nullable3
5 years ago
9c7b3850f9
Throw AuthenticationException instead of ArgumentNullException when a user does not exist
5 years ago
53380689ad
Return correct status codes for authentication and authorization errors
...
- Use AuthenticatonException to return 401
- Use SecurityException to return 403
- Update existing throws to throw the correct exception for the circumstance
5 years ago
1e1295bebf
Merge remote-tracking branch 'upstream/master' into register-services-correctly
5 years ago
d8a7462205
DvdLib: remove dependency on MediaBrowser.Model
5 years ago
06c5b73c15
Merge pull request #2755 from Bond-009/dbcleanup
...
Clean up SqliteItemRepository
5 years ago
dd128b5e30
Log message for each exception during login
5 years ago
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
5 years ago
62b0db59aa
Fix Authentication request log
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
615717e562
Register and construct IUserDataManager and IUserDataRepository correctly
5 years ago
4daa5436fc
Register and construct IUserManager and IUserRepository correctly
5 years ago
fe9f4e06d1
Register and construct LibraryManager correctly
5 years ago
7fd25f94f3
Inject and construct ISearchEngine and IMusicManager correctly
5 years ago
573da63d41
Register and construct IMediaSourceManager correctly
5 years ago
8e7b15285e
Clean up SqliteItemRepository
5 years ago
2fb9e36493
Authentication request log with IP
5 years ago
34204046dd
Remove duplicate array of extras directory names
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
5 years ago
464039043d
Merge pull request #2491 from mark-monteiro/2425-fix-playlists
...
Fix Playlist Deletion
5 years ago
13d30a0a79
Merge pull request #2436 from dkanada/music
...
Add config options for MusicBrainz
5 years ago
5d760b7ee8
Fix emby/user/public API leaking private data
...
This commit fixes the emby/user/public API that was returning more data
than necessary. Now only the following information are returned:
- the account name
- the primary image tag
- the field hasPassword
- the field hasConfiguredPassword, useful for the first wizard only
(see
https://github.com/jellyfin/jellyfin/issues/880#issuecomment-465370051 )
- the primary image aspect ratio
A new DTO class, PrivateUserDTO has been created, and the route has been
modified in order to return that data object.
5 years ago
1204818698
Clean up and document PlaylistResolver
5 years ago
41a26f8ecd
Correctly resolve playlists that are stored using a directory path
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
6715450598
Merge pull request #2427 from Bond-009/minor
...
Minor improvements
5 years ago
65a9d618cc
add config options for musicbrainz
5 years ago
adc9fc282c
Minor improvements
5 years ago
3bd7633cbf
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
a9e744bea0
Curly braces on new lines
5 years ago
3d9dc59554
Omitting the parameter ExtraChapters
5 years ago
f4d0fa8dc8
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
cvium
Bond_009
Joshua M. Boniface
Claus Vium
Ikomhoog
dkanada
Ian
Gary Wilber
artiume
Niels van Velzen
David
crobibero
nyanmisaka
BaronGreenback
Stepan
Anthony Lavado
Jan-Pieter Baert
Ryan Petris
Patrick Barron
Odd Stråbø
Patrick Barron
Bill Thornton
telans
aled
Daniyar Itegulov
Vasily
Vasily
Jesús Higueras
Erik Rigtorp
Davide Polonio
Mark Monteiro
randrey
dafo90
Ulrich Wagner